zeronetworks / community Goto Github PK

• Line 605 Field = "Firewall Policies" should probably read Field = "Firewall Profiles"

• Line 611 ExpectedOutput = "Running" , "Running" is not an output of the script in line 608 (also the ExpectedOutput seems not to be used by the script)

• Line 612 the checkOutput = { if($this.Output.result) {"Warning"} else {$true} } is always true and test always results in a Warning changing it to checkOutput = { if("Not Allowed" -in $this.Output.result) {"Warning"} else {$true} } makes the test Pass

Firewall Profiles: [Pass]

     Name    Enabled Inbound Outbound Is Local FW Rules Allowed?
     ----    ------- ------- -------- --------------------------
     Domain     True   Block    Block Allowed
     Private    True   Block    Block Allowed
     Public     True   Block    Block Allowed

• Line 600 the checkOutput = { if( ($this.Output | Out-String) -match "True") {"Warning"} else {$true} } always results in a Warning when there are NO "Active Rules Zero Networks is not managing" because of the logic in line 282 if (-not $this.output) {$this.output = "Error getting output"; $this.Result = "Fail"} where an empty output is always treated as a Fail by default, in this case an empty output is what we expect to Pass. Changing line 282 to if ((-not $this.output) -and $this.Result -eq "False") {$this.output = "Error getting output"; $this.Result = "Fail"} seems to rectify behavior and not affect other parts of the script

Active Rules Zero Networks is not managing: [Pass]