zenixls2 / alacritty Goto Github PK

For bug reports, the following information can help speed up the process. Please
describe the bug that you have found and what you would expect to happen
instead.

System

OS: Gentoo GNU/Linux (kernel 6.6.2-gentoo-dist)
Version: alacritty 0.8.0-dev (7291702f)
Linux/BSD: dwm

Logs

[2023-11-26 20:06:30.901956050] [ERROR] [alacritty] Alacritty encountered an unrecoverable error:

                                                    	There was an error initializing the shaders: Failed compiling shader: 0:1(10): error: GLSL 3.30 is not supported. Supported versions are: 1.10, 1.20, and 1.00 ES

With some GTP helps I discovered it has something to do with my OpenGL version and that it has everything to do with my graphic hardware, what is bad as I'm on a Notebook full intel stuff.
Anyway this is my glxinfo | grep "OpenGL version" output:

OpenGL version string: 2.1 Mesa 23.3.0-rc5

What GPT says this Alacritty fork expects the version 3.0, but it is not what the log says. Anyway I hope someone can help cuz I got no idea what to do.

window: 
    opacity: 0.9

when I use this on vanilla Alacritty it works, but on this one it doesn't, unsure whether this is because this project hasn't been touched since 2021 or if its just some kind of other text I need to write. Any help would be appreciated

System

OS: Linux arch + i3
Version: 0.8.0-dev (3ed0430)
Linux/BSD: picom

• compare using some microbench
• integrate into this project once allsorts outperforms.

Please merge with master repo, we need the features from there and ligature as well

For bug reports, the following information can help speed up the process. Please
describe the bug that you have found and what you would expect to happen
instead.

System

OS: PopOS 21.10
Version: Not Installed Yet
Linux/BSD: Gnome Cosmic

Logs

error: failed to run custom build command for `servo-fontconfig-sys v5.1.0`

Caused by:
  process didn't exit successfully: `/home/jcostanzo/Development/alacritty/target/release/build/servo-fontconfig-sys-37fd5b771c6a163e/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=FONTCONFIG_NO_PKG_CONFIG
  cargo:rerun-if-env-changed=PKG_CONFIG
  cargo:rerun-if-env-changed=FONTCONFIG_STATIC
  cargo:rerun-if-env-changed=FONTCONFIG_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_STATIC
  cargo:rerun-if-env-changed=PKG_CONFIG_ALL_DYNAMIC
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_PATH
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_LIBDIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64-unknown-linux-gnu
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR_x86_64_unknown_linux_gnu
  cargo:rerun-if-env-changed=HOST_PKG_CONFIG_SYSROOT_DIR
  cargo:rerun-if-env-changed=PKG_CONFIG_SYSROOT_DIR

  --- stderr
  thread 'main' panicked at '`"pkg-config" "--libs" "--cflags" "fontconfig" "fontconfig >= 2.11.1"` did not exit successfully: exit status: 1
  --- stderr
  Package fontconfig was not found in the pkg-config search path.
  Perhaps you should add the directory containing `fontconfig.pc'
  to the PKG_CONFIG_PATH environment variable
  No package 'fontconfig' found
  Package fontconfig was not found in the pkg-config search path.
  Perhaps you should add the directory containing `fontconfig.pc'
  to the PKG_CONFIG_PATH environment variable
  No package 'fontconfig' found
  ', /home/jcostanzo/.cargo/registry/src/github.com-1ecc6299db9ec823/servo-fontconfig-sys-5.1.0/build.rs:34:17
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

Fork the topic from mainstream.
Any issue related to my fork should go here.

Notice that this fork might take a long time to develop and possibly not (able to) merge back to the mainstream.

I found that recent builds leak memory. Compared with non-ligature alacritty (today's master) and it also does not leak/

System

OS: Linux (Ubutnty 16.04)
Version: alacritty 0.6.0-dev (143b399)
Linux/BSD: X11 GnomeShell

Logs

Font/Terminal size: Width: 1920, Height: 1053, Font: Iosevka Term

I think recent build leak memory. Here is a build that does not leak: alacritty 0.5.0-dev (2c6f47f) - it's from a few weeks ago.

I think may be related to the caching of the rendered lines.

Experiments:

1. Run htop, observe alacritty memory increase:

luben    10493  1.1  0.2 591084 41684 pts/13   Sl+  15:25   0:00 ./target/release/alacritty
luben    10493  0.6  0.2 594948 46372 pts/13   Sl+  15:25   0:00 ./target/release/alacritty
luben    10493  0.4  0.3 598024 49480 pts/13   Sl+  15:25   0:00 ./target/release/alacritty
luben    10493  0.3  0.3 601392 52756 pts/13   Sl+  15:25   0:00 ./target/release/alacritty
luben    10493  0.3  0.3 604532 55892 pts/13   Sl+  15:25   0:00 ./target/release/alacritty
luben    10493  0.2  0.3 607696 58972 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.3 610812 62216 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.4 613888 65288 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.4 616972 68288 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.4 620084 71484 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.4 623008 74512 pts/13   Sl+  15:25   0:01 ./target/release/alacritty
luben    10493  0.2  0.4 626080 77560 pts/13   Sl+  15:25   0:01 ./target/release/alacritty

2. run tree ~/rust (200k files)

$ ps axu | grep target/release/alacritty | grep -v grep
luben    10493  0.3  0.5 629908 81480 pts/13   Sl+  15:25   0:03 ./target/release/alacritty
$ tree ~/rust
...
$ ps axu | grep target/release/alacritty | grep -v grep
luben    10493  0.5  0.6 661372 112912 pts/13  Sl+  15:25   0:06 ./target/release/alacritty
$ tree ~/rust
...
$ ps axu | grep target/release/alacritty | grep -v grep
luben    10493  0.6  0.8 689816 141404 pts/13  Sl+  15:25   0:08 ./target/release/alacritty

$ tree ~/rust
...
$ ps axu | grep target/release/alacritty | grep -v grep
luben    10493  0.7  1.0 718504 169944 pts/13  Sl+  15:25   0:10 ./target/release/alacritty

I noticed the problem with a build from a few days ago that has grown to 1.5G of memory in a few days. I have rebuilt it today with all recent commits and I still see it leaking memory.

BTW, I had to comment the call to FT_Set_Default_Properties in crossfont as my freetype does not support it (also for building master). Nothing else is patched.

System

OS: macOS 11.2.3

Issue

The ligature branch does not seem to render east asian characters (Chinese, Japanese, Korean) correctly.

Behavior on ligature branch:

Behavior on current master release (0.7.2(5ac8060)):

Expected behavior (screenshot taken from macOS terminal v2.11)

Notice in the current master release (0.7.2), the Korean(appears first in the screenshot) characters are still not rendered properly, but at least the Chinese(3rd in the screenshot) and Japanese(2nd in the screenshot) characters seems to be alright.

For bug reports, the following information can help speed up the process. Please
describe the bug that you have found and what you would expect to happen
instead.

When I try to use this specific icon ﯲ in ranger and the ligatures are turned on in Alacritty the text is rendered from right to left.

System

OS: Arch Linux
Version: 0.8.0-dev
Linux/BSD: X11 + bspwm

Otherwise every time when upstream updates freetype-rs, compilation will fail, and need another pr in servo's freetype repo to fix.

Also this will free the top cargo.toml from overwriting the dependency.

Hi @zenixls2,

Thanks for working on ligature. I tried running 3ed0430 and it looks like there is an issue rendering ❯. See the screenshots below:

ligature branch:

Alacritty 0.7.2 (5ac8060)

Test case:
printf '\xe2\x9d\xad'

System

OS: macOS
Version: alacritty 0.8.0-dev (3ed0430) and alacritty 0.7.2 (5ac8060)

Alacritty doesn't launch at all without WAYLAND_DISPLAY="", unlike master.

System

OS: Arch Linux
Version: alacritty 0.10.0-dev (cf35a20)
Linux/BSD: KDE Wayland (NVIDIA GBM)

Logs

Crashes: [wayland-client error] Attempted to dispatch unknown opcode 0 for wl_shm, aborting.
Font/Terminal size: alacritty -vv returns same as above
Keyboard and bindings: alacritty --print-events returns same as above

Compare to master branch, several issues found in ligature branch.

• Searched items' color not correctly inverted on search
• Cursor not color inverted when overlap the searched item

System

OS: Linux
Version: alacritty 0.6.0-dev (3757e3c)
Linux/BSD: Wayland (but I don't know in which mode alacritty is working btw i have xwayland), swaywm

Logs

Crashes: no
Font/Terminal size: FiraCode Regular (one from arch linux repo) \ fullscreen borderless
Keyboard and bindings: --

DESCRIPTION:
After resizing font with ctrl+ eventually ctrl- font rendering breaks althought when you type something after resize it is rendered correctly

Master branch doesn't have such issue.
The issue doesn't happen when ligature option been turned off.

Hi! First of all, huge thanks for doing this, this is fantastic!

I pulled down your ligatures branch and was able to build it on Windows, but it crashes on start-up. I see that you made some changes on your fork of the crossfont repo, which did touch some DirectWrite stuff. But not really sure if it's unsupported or an unexpected failure. The error I get is:

PS C:\Users\Alex\alacritty-fork> .\target\release\alacritty.exe
PS C:\Users\Alex\alacritty-fork> Created log file at "C:\Users\Alex\AppData\Local\Temp\Alacritty-15304.log"
[2020-08-03 16:57:57.489506100] [ERROR] Alacritty encountered an unrecoverable error:

        A DirectWrite rendering error occurred: 0x80070057

It's building and running successfully on my WSL2 + VcXsrv setup, which is awesome. But I'd prefer to run it natively in Windows if possible.

Happy to provide any additional information if I can help!

Hey! This is going to sound really noob, but where can I enable the ligatures?

I tried:

font:
  ligatures: true

System

OS: Linux xps 5.7.11-arch1-1 #1 SMP PREEMPT Wed, 29 Jul 2020 21:38:21 +0000 x86_64 GNU/Linux
Version: alacritty 0.6.0-dev (cdff663)
Linux/BSD: X11/i3/Picom

Logs

Crashes: STDERR, STDOUT
Font/Terminal size:

[2020-08-02 12:28:17.089978295] [INFO] Initializing glyph cache...
[2020-08-02 12:28:17.123830907] [INFO] ... finished initializing glyph cache in 0.033808101s
[2020-08-02 12:28:17.123889023] [INFO] Cell Size: 13 x 26
[2020-08-02 12:28:17.123902874] [INFO] Padding: 0 x 0
[2020-08-02 12:28:17.123918620] [INFO] Width: 800, Height: 600
[2020-08-02 12:28:17.134138618] [INFO] PTY dimensions: Line(23) x Column(61)
[2020-08-02 12:28:17.147467346] [INFO] Initialisation complete
[2020-08-02 12:28:17.148896314] [INFO] Width: 1276, Height: 468

Keyboard and bindings: alacritty --print-events

Some dependencies have two versions, upgrade winpty to remove the old one