Period end time is not business hours about biz HOT 2 CLOSED

Yes, the exclusion is definitely intentional.

This is one of those things, like business day calculations, where the "right" answer is ambiguous and highly context-dependent as I can see arguments for both sides depending on your use case.

I'm inclined to leave it more strict (i.e. excluding the end_time) as the default behavior. On the bright side, this is another one of those aspects that you can wrap if you'd like.

Here's one way:

def in_hours?(schedule, time)
  schedule.periods.before(time).first.end_time == time
end

from biz.

Ok, sounds good. Thanks!

from biz.