How to handle cases where two schedules don't intersect at all? about biz HOT 1 CLOSED

Hey there, @bbbneo333! Thanks for using the gem and for reaching out with your question.

The issue with creating a intersected schedule with an empty set of hours versus failing hard with an exception is that an empty schedule would be functionally pointless in every scenario where it is to be used: Time calculations would always return zero, selecting a group of periods would always return an empty set, and determining whether a time was in business hours would always return false.

Now, we could implement a null object pattern within the gem for this case, but I don't know if it's worth the overhead of maintenance given the niche applicability.

With that said, here are a couple suggested approaches for your use case:

# exception handling

def schedules_intersect?(schedule1, schedule2)
  (schedule1 & schedule2).intervals.any?
rescue Biz::Error::Configuration => error
  error.message == 'hours not provided' ? false : raise
end

schedules_intersect?(s1, s2)

# null-object pattern

class NullSchedule
  def intervals
    []
  end
end

def intersected_schedule(schedule1, schedule2)
  schedule1 & schedule2
rescue Biz::Error::Configuration => error
  error.message == 'hours not provided' ? NullSchedule.new : raise
end

intersected_schedule(s1, s2).intervals.any?

I'm going to close this issue for now as I don't think there's anything actionable, but please do let me know how you addressed your issue and/or if the above suggestions were helpful.

from biz.