zegnat / browserext-window-merger Goto Github PK

Research possibility to support Waterfox.

Waterfox seems like a popular Firefox fork that may warrant specifically supporting. See how this goes together with #6. I do not feel much for supporting a platform I do not use, but if ESR support equals to Waterfox support there is no reason not to allow them to use it.

Inspired by jonathanKingston#6: offer an alternative merging strategy where tabs will be added right after the current active one instead of at the end.

Currently imagining this as an browser-wide addon setting that will just switch the merging strategy for all merges.

Merging does not trigger a redraw of the context menu, so unless you leave the current windowit will continue to show non-existing windows as options.

Per a review on AMO, people might be looking for the merge feature under the browser’s Tools menu. It might be worth adding the menu there as well.

Should this be configurable at all in the settings? Or is it OK to always show a merge option in the tools menu? I am currently leaning towards not making this configurable.

Add some indicator (maybe underscore?) to windows that are minimized. Sort them at the end of the list of windows.

I almost never want to merge a window that I have not looked at. It might just end up merging the wrong thing. So it should be easier to ignore minimized windows in the list.

Is it possible to implement the ability to right click a tab in the tab bar to access the functionality of the extension? Perhaps set an option to right click a page or right click a tab in the tab bar to access the extension?

Also, is it possible to implement an undo merge function? 

I want the extension to be available at least to the latest ESR release. To date that is 60.9.0.

Currently the extension requires at least Fx 62 to run its JS. See #5.

I see the Right-Click functionality but did not notice an icon created in the toolbar. Should it be there?

Thanks for making this!

Maybe exposing a bug in Firefox.

Firefox Multi Account Containers also known as Multi-Account Containers 7.3.0 enabled with Window Merger 0.6.0 and various other extensions.

Cross-reference mozilla/multi-account-containers#1996 (comment)

Zooming in to https://user-images.githubusercontent.com/192271/116799072-baa0bf00-aaed-11eb-9167-14f6144de7f7.png (first of the four shots):

Zooming in to https://user-images.githubusercontent.com/192271/116799079-c3919080-aaed-11eb-854b-11fa8cd22668.png (second shot):

In the first shot, two items are missing from the page context menu:

• Firefox Multi Account Containers
• Merge Windows

My preferences for this extension are not unusual:

I just saw a new issue (jonathanKingston#11) being filed on the upstream Merge Windows add-on where a user had problems merging a popup window (in that case generated by a different browser extension) into an existing window.

This bug does not exist in Window Merger because this extension does not allow merging popup windows. But it does begs the question: should it allow merging popup windows?

I haven’t personally run into this use-case, nor had any input from anyone else who has. But it would not be too hard to support.

If tabs are not loaded prior to merge, they should remain not loaded after the merge.

Thanks

When I first tested with recent Waterfox Classic 56.2.13, menu options were apparent. From a screen recording:

– however the windows did not merge.

The browser crashed (maybe because I was thrashing the OS, FreeBSD-CURRENT, at the time, with software builds).

After relaunching the app: menu options are no longer apparent:

Can you add compatibility with Waterfox Classic? (Historically: Waterfox 56.0 was based on Firefox 56.0.2.)

Or does the extension need a strict_min_version?

I have not yet decided if I would want this as part of Window Merger or a separate extension.

After a long research session, I will often use Window Merger to unify my windows. Sometimes this means I first select tabs (e.g. all tabs of a specific domain) in a window, then move the selected tabs to a new window, just so I can merge this new window in a different existing one. I would safe myself some time and hassle if I could skip the creating of a new window.

Sadly Firefox by default only offers Move to Start, Move to End, and Move to New Window.

I imagine opening the context menu (ie. right click menu) on the tab strip with one or more tabs selected, and then having to option to "Merge into..." which will list all the known browser windows.

If I hit merge without wanting to, this can really make it hard to get back to the previous state. Especially if multiple windows got merged into one. How could this be handled?

Remember: UX over code!

(See #8 for previous discussion.)