Git Product home page Git Product logo

go-musthave-shortener's People

Contributors

zaz600 avatar

Watchers

 avatar

go-musthave-shortener's Issues

Переделать работу с Batch

Замечание по ревью:

я бы немного разделил бы добавление, flush и последнюю операцию. Это три разных сущности, хотя подход отличный и рабочий в твоем случае, но немного рефакторинга всегда хорошо (возможно в коде ошибки, но смысл думаю будет понятен)

batch := repo.NewBatch(100) // создаешь новый объект, который использует два метода Add и Flush
defer batch.Flush() /// (в любом случае ты попробуешь сделать запись)
for _, e := range linkEntitites {
     batch.Add(e)
}

func (b *Batch) Add(ctx context.Context, e LinkEntity) error {
      b.entitites = append(b.entitites,e)
      if cap(b.entitites == len(b.entittes)) {
               b.Flush(ctx)
       }
}

// и еще метод flush, который у тебя уже есть

Originally posted by @Perederey in #14 (comment)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.