zarch / openriver Goto Github PK

We need simple data files for testing, maybe with known outputs.

Consider if could be possible to integrate openriver in GRASS creating a python plugin

Allow to move the points of the sections and update the table. Only as option. It should be encuraged to enter precise data using the table. Anyway could be useful to create fastly test data.

In geometry.py implement a method for reading .geo files (Vario geometry files)

Since this is the first time I take a closer look to the code I followed the example present in docu of class Section and....it does not work...
The documentation is old, I think it should be like this:
"""
It defines attributes and methods for a river cross-section.
It's possible to define sub-segments of the section,
each one with a different roughness.
Example of usage:

coord = np.array([[0,10],[0,0],[10,0],[20,0],[20,10]])
sect = Section(0, coord)
sect.addSegment(sect.coord[0:2], 35)
sect.addSegment(sect.coord[2:], 40)
"""

The np implementation was missing and the sect.yzcoord is an old version? If what I report here is correct I can push it to the repo. I think we should always check the docu of a Class, Method, etc if we change the code, in order that it is updated!.

Moreover, following the example, I tried to add a subsection with addSegment:

sect.addSegment(sect.coord[0:2],35)
sect.segment
[<main.Section instance at 0x29a3cf8>]
? no idea what is going wrong.

we should choose under which license we redistribute openriver.

What do you think about GPLv3?

«This program is free software; you can redistribuite it and/or modify it under the terms of the GNU/General Pubblic License as published the Free software Foundation; either version 3 of the License, or any later version»

In geometry.py, the addSegment method of Section class allows to add multiple subsections in the same segment. This has to be not permitted. Subsections can't be overlapped.

Example:
0---1---2---3---4---5---6

subsection A from 0 to 3, subsection B from 3 to 6
this is OK

subsection A from 0 to 3, subsection B from 2 to 6
this should be forbidden

"Bacini montani" distributes sections data using autocad.
Take a look if could be possible to import directly from dxf file or some other kind of autocad export file (dwg is almost impossible).
Acknowledgment: fra