zachleigh / larafolio Goto Github PK

If project name wraps, could create weird formatting issues. Set height using padding, maybe min-height, instead.

Also, see what happens if project name is really long.

Would be convenient and make links consistent with other elements.

Not necessary and looks odd.

Occasionally, names contain odd symbols which may break things. Simply change the project factory name line to this:

$name = $faker->unique()->word;

Let user do what they want.

You can inline a lot of the event emiters.

Resource directories are copied to the vendor Laravel instance before versioning is finished resulting in numerous resource 404 errors.

Recent additions have made usability/accessibility pretty terrible. Things to do:

• All form fields should have a label. Text block text field could be exception.
• All link items shown on main project page should be labeled.
• Consider labeling items in live preview.

On the edit page, when there are multiple headings in the text box entry fields, the preview text box heights are wrong.

Preview height only adjusts after adding a second link or inserting data into one of the page forms.

Let vue manage the project list in the drop down.

TODO:

• Pull out project list component
• Have a refresh method that hits the server to get the current project list and repopulates

The preview section of the edit form would be much more useful if it was wrapped in the same class as it is in the live app. Allow for this via a config item.

Alt text for image.

On edit page:

• ctrl s to save

Seen on image manager screen, mobile.

Will lead to more consistent styling and easier maintenance.

Do the same for general layout items. Currently, a lot of it is in .project, but that stops making sense if the page is not a project page. Create a .page namespace.

Would make it a lot easier to manage, especially since the icon is already there.

Need to cover the following:

• Menu
• Can click 'Manage' from dashboard
• Can toggle visibility from dashboard
• Can toggle visibility from project screen
• Can remove project
• Can add images
• Can update images
• Can remove images
• Can add project
• Can edit project
• Can change text block order
• Can remove text blocks
• Can change link order
• Can remove links

Need spacing above the 'Manage' button.

Not sure if this is a good thing or not. If you decide to keep it, rename it to something more useful. Otherwise, change the scope on the composer.

Should be able to easily manage images that are not tied to a project or page.

Elements to make:

• Images with src and alt tags
• Links with href, optionally wrapped in link text

All partials/directives will require a project instance, the name of the image/link to render, and any optional variables.

In Project.php. Have separate methods to return the image url and block text.

getProjectImage found in Project.php and ProjectController.php.

getProjectBlock found in Project.php and ProjectController.php.

Put links to the github page, docs, contributors etc.

Links need to be ordered by order property. In orderAndGroupQuery(), add this at top of method:

        $query->with(['links' => function ($query) {
            $query->orderBy('order');
        }]);

Have to clear the browser cache to see changes in css/js after updating. Maybe elixir can't find the rev-manifest file in public/vendor?

After updating, automatically publish resource files so user is sure to get fresh js/css.

Something like this would be nice: $project->getProjectImage('medium');

Pages like About should be able to be kept in database as well. Could essentially be the same as project, just with no links and separate menu dropdown.

• Add methods to get all projects with named elements. For example all projects with links named 'about':

        Link::with('project')
            ->where('name', 'about')
            ->get()
            ->map(function ($link) {
                return $link->project;
            });

Specifically for routes update-project and remove-project. They need to match otherwise client route model binding becomes tricky.

At least do Vue, nothing should break. Check for breakages before upgrading others.

To be used as text for link when displayed.

Since the name needs to be unique, soft deleted project names can not be re-used. Possible solutions;:

• Don't make project names unique (don't like this...)
• Hard delete projects (scary..)
• Have page where soft deleted projects can be managed
• Have commands to deal with soft deleted projects

The page seems like the best option to me, and really shouldn't be too much work. Maybe in a Settings page or series of pages. You could also make soft deleting an option.

A few problems:

• New edit section spacing not fully accounted for: increase display area top and form-section margin-bottom by same amount.
• Bottom border of text block edit form needs to stick to the bottom, maybe make it a border-top instead.
• Extract css/js constants to variables if not already done.

When I put an img tag in a text block, everything died. Nothing renders.

On create/edit page, if the user clicks 'Finished' or navigates away from the page, a confirmation modal should ask user if they want to leave without saving new content.

Something like 'You have not added any projects yet' with a button linking to the add project page.

Need to have a good look at them and maybe re-write them. They fail about half the time.

https://github.com/zachleigh/larafolio/blob/master/src/Http/Controllers/ProjectController.php#L46

Check for project before calling imagesWithProps(), throw 404 if project doesn't exist. Something like this:

        $project = Project::withBlocks($slug)->first();

        if (!$project) {
            abort(404, "No project with slug {$slug} found.");
        }

The 'No Current Images' message is in the same row as the dropzone box. Should be in different row.

If two flash messages hit the system at the same time, they are the same instance. The timer to hide the flash message is set with the first message so the second message is shown for a shorter amount of time. Should either:

• Make it so each flash message is a separate instance (ideal)
• Reset the timer when a new flash message is created

Doing so will clean up you form component and make all the logic associated with images and text blocks more reusable.

Maybe just a command to move the Larafolio database seeders and factories to the local app?

Issues:

• Need to get rid of namespaces when moving seeders over
• Eliminate use statements for DB and Storage
• Change image paths. Should be __DIR__.'/../../vendor/zachleigh/larafolio/tests/_data/images'

Links should always be eager loaded.

Check preview z-index and set mobile menu above that.

Would make creating any new forms in the project substantially easier.

For each text block have a link telling users that markdown is available and make it link to a reference page.

Its right aligned. Seen on google chrome, android.

Use https://github.com/spatie/http-status-check to check status of links. Have a status indicator on the project manager page with colored dots: green for 200, orange for 300, red for 400/500. Output error message for all but 200 range. Run in background and update via ajax. Have either grey indicator or spinner in place of status indicator if process hasn't completed yet.