yzw124 / odinmobile Goto Github PK

NSString * ODIN1();

is not the right function signature. (ODIN.h:19) 

Remember that .h files paired with .m files get parsed as pure C, which means 
that you have to declare them as:

NSString * ODIN1(void);

This is because an empty () in a forward declaration of a function means that 
the function can take an arbitrary amount of parameters.)

What steps will reproduce the problem?
1. Try to get ODIN value in WP8 application
2. Throws Exception.
3.

What is the expected output? What do you see instead?
I want to get the ODIN Value. Instead, it throws an exception because the 
Windows Phone api call is deprecated.

What version of the product are you using? On what operating system?
Windows Phone 8 emulator in Windows 8.

Please provide any additional information below.
OpenUDID uses the same mechanism - I opened up a identical issue here:
https://github.com/jasonlamkk/OpenUDID.Net/issues/1

In all of the cases, there is no standard written to follow for hashing (that 
is clear to me anyways)

Example for mac address:
I can hash the actual bytes, hex codes in ascii Upper, or ascii lower, hex 
codes in ascii with "-" or ":" separators; it all depends on how I receive the 
mac address.

If there were a prescribed standard, it would prevent different implementations 
from generating different hashes for the same ID.

"Mac address must be the raw bytes" or "Mac address must be the lower case 
ascii hex codes without a separator".  That keeps people like me from messing 
it up.

The same goes for the other identifiers, although there is a standard API call, 
it would be nice to have a standard format to ensure we are making a standard 
ODIN hash.

    if ((buf = malloc(len)) == NULL) {
        //NSLog(@"ODIN-1.1: malloc error");
        return nil;
    }

    if (sysctl(mib, 6, buf, &len, NULL, 0) < 0) {
        //NSLog(@"ODIN-1.1: sysctl 2 error");
        return nil;
    }


if sysctl returns an error code, buf will not be released