Git Product home page Git Product logo

popup-simple's Introduction

Hi there ๐Ÿ‘‹, I' m Yura, and I' m a Frontend Developer

  • ๐Ÿ  Location: Kiev, Ukraine
  • ๐Ÿ’ป 4+ Years Experience in Front-end Development
  • ๐Ÿ“• Always learning new things

๐Ÿ’ป Tech Stack:

html5ย  nunjucksย  css3ย  sassย  javascriptย  node.jsย  mongodbย  reactย  vueย  nuxtย  strapiย 

๐Ÿ›  Tools:

gitย  yarnย  npmย  herokuย  netlifyย  photoshopย  figmaย  vs codeย 


๐Ÿ“˜ My open source projects

generator-front-starter-kit popup-simple gulp-gtm-plugin select-custom fullpage-pagination js-anim swipelistener-js


โš™๏ธ GitHub Analytics

Github stats Github Languages
Github Activity Graph

popup-simple's People

Contributors

dependabot[bot] avatar yurayarosh avatar

Stargazers

 avatar

Watchers

 avatar  avatar

popup-simple's Issues

`toggleBtnClassName` constant error.

When open page with popup by url (https://url-path#popup-name) an error is occuring:

index.es.js?8dfc:218 Uncaught TypeError: Cannot read property 'dataset' of null
    at openHandler (index.es.js?8dfc:218)
    at Popup.openPopup (index.es.js?8dfc:244)
    at Popup._onLoad (index.es.js?8dfc:384)
    at Popup.init (index.es.js?8dfc:390)
    at __webpack_exports__.default (setPopups.js?e1d4:5)
    at App.initMethods (app.js?9a78:46)
    at App.init (app.js?9a78:73)
    at HTMLDocument.init (app.js?9a78:82)

It appears if import index or index.es file.
If import from source this error is not showing:
import Popup from 'popup-simple/src/main'

`onClose` method

onClose works if created in extended component, but does'nt work other way
for example this works

class MyPopup extends Popup {
  onClose() {
    // do something
  }
}

and this does not

const popup = new Popup()
popup.onClose = () => {
  // do something
}

onClose method

When trigger onClose callback, there are popup: null, closeTrigger : null values in instanse object, but they should exist.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.