yumemi-inc / danger-swift-eda Goto Github PK

DangerSwiftEda/DangerDSL+.swift:15: Fatal error: Unexpectedly found nil while implicitly unwrapping an Optional value

danger-swift local 実行時に danger.github がnilになりFatal errorが発生します

Bug Description

When passing ticketAddressResolver to GitFlow.Configuration, it seems that the resolver is not being utilized as expected.

Steps to Reproduce

1. Configure GitFlow.Configuration with ticketAddressResolver.
2. Execute Danger

Expected Behavior

The ticketAddressResolver should be used according to the configuration when executing Danger.

Actual Behavior

It appears that the ticketAddressResolver is not being utilized, and Danger do not take it into account.

Support for GitHub Flow, and custom flow configuration

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update all non-major dependencies (danger/swift, el-hoshino/DangerSwiftHammer, yumemi-inc/danger-swift-shoki)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Hello, I have found what I believe to be a typo and would like to report it.

• ckeck -> check

  • danger-swift-eda/Sources/DangerSwiftEda/Eda.swift

    Line 401 in 33e6445

    public func ckeckPR(workflow: PRWorkflow) {

  • danger-swift-eda/README.md

    Line 55 in 33e6445

    danger.eda.ckeckPR(workflow: .gitFlow(configuration)) // Assume you have initialized `danger` by code like `let danger = Danger()`

However, I think you will need to update your version as it would be a destructive change