yuki-koyama / enhancer Goto Github PK

The current code seems to be wrong in using a VAO.

Lift/Gamma/Gain is so expressive that some parameters are probably less useful in the case of Lift/Gamma/Gain is enabled. For example, Temperature/Tint can be disabled. Brightness/Contrast can also be disabled maybe.

GLM should be a natural choice for this kind of projects preparing with both C++ and GLSL APIs. Eigen is overkill.

In this code, vertex_shader and fragment_shader are newed but never deleted, which may cause memory leaks.

To fix this, simply using addShaderFromSourceFile seems fine:
https://doc.qt.io/qt-5/qopenglshaderprogram.html#addShaderFromSourceFile

Something like this:

class EnhancerWidget: public QOpenGLWidget
{
public:
    SetImage(const QImage& image);
    SetParameters(const Eigen::VectorXd& parameters);
[...]

Currently, EnhancerWidget inserts black margins when the aspect ratio of the image is different from that of the widget, but this is not always suitable. It is better to support a "filling" mode as well.