ytakzk / fusuma Goto Github PK

Hi,

I would to like to run fusumaDismissedWithoutImage delegate to do some coding inside.

Thanks.

Regards,
Ferrick Chan

Is there a setting to change the aspect ratio of the camera / picker?

In FSAlbumView, once CollectionView didSelectItemAtIndexPath is calling and the main layout will change after collectionView will scrollToItemAtIndexPath. It make user see like a bit lagging. (sudden Down and Up) Hope can improve transition in future.

I'm recording videos but they do not have sounds:

let vc = FusumaViewController()
vc.hasVideo = true
vc.delegate = self
presentViewController(vc, animated: true, completion: nil)

Is there a missing resource? It doesn't seem that there is

How can I make the front facing camera the default camera to use? Right now its showing the camera on the back of the phone first. Thank you. I am liking this! :)

Can write a oc versions？

This is due to a missing "@obj" prefix on the focus function, causing the tap gesture to fail in finding the correct selector.

Hi, I used Fusuma in my project written in objective-c, all works correct, but i have not access to local variables like fusumaTintColor or fusumaBackgroundColor. Can i customize Fusuma interface without changing source code in Fusuma lib?
Thanks:)

Any plan for Swift 2.2 support?

Is it possible to change UX to use iPad in Landscape mode?

I have a lot of photos in camera roll, when I scroll down rapidly. The app always crashes.

Can you add record croped video and select video from gallery?

How can I do this? Something like

if let pickedImage = info[UIImagePickerControllerOriginalImage] as? UIImage {
      UIImageWriteToSavedPhotosAlbum(pickedImage, nil, nil, nil)
}

Hello

I am deeply looking for a tool that could display all my likes on a map (and not my own posts only as does ig right now)

Since your project seems to be the most active, I am putting this request here as an improvement. Maybe you could collaborate with this project to use Google Maps : https://github.com/haydenbleasel/photomap

Thank you for the attention you will give to my request ;)

Cheers

App crash when activating video capture mode

Device: iPad Air 2

FusumaExample[5376:2477109] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[AVCaptureVideoDevice setFlashMode:] - the passed flashMode 0 is not supported by the device. Use -isFlashModeSupported: to discover valid flash modes.'

clone the repository, add fusuma.hasVideo = true to ViewController.swift run the app

problem is FSVideoCameraView.swift, adding guard device.hasFlash else { return } before device.flashMode = AVCaptureFlashMode.Off fixes the crash but the flashButton is still in the UI and users can press it, that will make the app crash with the same error, in Picture mode flashButton is not displayed

Hi

Thanks for the great work.

It would be great if your control was localized or localizable.

titleLabel.text = "CAMERA ROLL"
titleLabel.text = NSLocalizedString("CAMERA ROLL", comment: "CAMERA ROLL")

titleLabel.text = "PHOTO"
titleLabel.text = NSLocalizedString("PHOTO", comment: "PHOTO")

Kind Regards
Graham

I'm try to select the image has 4:3 or 16:9
but imgae get from your source alway square size. this visible in 0.5.1 version.
Please update it soon, thank

Hi, firstly, your control is so great, it save my time. Have it support obj-c project?

It's in the deinit, and from a google search it looks like it's because you create a PHCachingImageManager even if the user hasn't granted access

see here: http://stackoverflow.com/questions/33266346/photos-framework-crash-this-application-is-not-allowed-to-access-photo-data

It's hardcoded in the controller's viewDidLoad() to start with library mode, even if modeOrder's value is .CameraFirst.

I don't want the image to be able to be smaller than the containerView. I can't seem to find this, help pls?

Hi, I've just tried to install Fusuma and I get the following error:

A shell task (/usr/bin/xcrun xcodebuild -workspace /Carthage/Checkouts/Fusuma/Fusuma.xcworkspace -scheme Fusuma -configuration Release CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES -showBuildSettings) failed with exit code 66:
xcodebuild: error: Scheme Fusuma is not currently configured for the build action.

Researching on Carthage issues (Carthage/Carthage#896), I've found that it's an issue with the library.
I also tried to install version 0.4.0 and it works, so it's probably an issue with the latest version (0.5.1).

What should I do?

When i pick image from library its size like 400x400, and when i make photo its size like 3000x3000. Can you pls fix library image size to full?

Is there any way i can record the video in square? fusumaCropImage just works for the image and not video

Do you plan to create a swift3 branch soon?

What is the default cropping size? How can I check/change it?

When I clicked the flash button

Another problem is I think you always set the off image to flash button at the beginning no matter the flash mode is on or off.

When click close button or done button, going another view and return to Fusuma controller, its not opening again.

Could implement the highlight when select the FSAlbumViewCell?

Is it possible to not crop images picked from Fusuma? I love this controller but I need original images.

Hi

Thanks for the great work.

It would be great if your control would support a light color scheme in addition to the existing dark scheme.

Kind Regards
Graham

Hi, love the camera, almost exactly what I was looking for!

I want to force my users to take a picture instead of being able to choose one from their photo library, is there a way to disable it and allow only camera mode?

It would be nice to get the PHAsset URL so that image info like location can be extracted.

device.hasFlash property has not been checked in FSCameraView before configuring and using flash.

Hey there, how can I use this awesome libraries with objective-c?

Seems like it's a bit of duplication of code, as really only one of those delegate methods NEEDS to be implemented

Can add switch albums to select the photo? It will help end-user easier to search their photo.

When device is rotated to landscape the view is not layed out properly. The following images demonstrate the problem on iPhone 5 (4" screen size).

I could only reproduce the issue in Xcode 7.3.

Root of the problem that I found:

In FSCameraView when creating tapRecognizer for previewViewContainer the action for the gesture recognizer ie. "focus:" has not been given @objc attribute.

What is the willFilter used for.

The images in the collectionView of the FSAlbumView are not being rendered in iPad Air and iPad Air 2. The frames are there. Also if I give the background color to the imageView the the background colors are visible. Even when I select the cell, the corresponding image is shown in the imageCropView. But the images are not being rendered in the collection view.

How i get the image name after selecting the image. please help. Thanks in advance.

Hi and thanks for sharing this beautiful picker.
In my iPhone i have this: Settings->Photos & Camera->Optimise iPhone Storage
Lot of my photos are in low res loaded in iCloud, and with the standard picker they are downloaded from iCloud when selected.
With Fusuma picker if I pick up a photo from my gallery (and if the photo is a low res photo loaded in iCloud) the photo is not displayed.

In this new version with video included, there is issue with touches on close button and bottom buttons. tried different solutions, nothing worked. any idea how to make the button press smooth as like in the old version.?

Steps to reproduce:

1. Show picture library
2. Choose one of the pictures (or keep the first one)
3. Go to background mode
4. Open picture library on your iPhone and remove the photo, that you selected in step 2
5. Open app

Expected behavior: deleted photo should disappear from main image view
Actual behavior: app crashes when enter active mode

I have no idea what happened.

If i take photo from camera it rotates 90 degree after upload. Is there any solution?

Hi, I just found an issue with the torch mode of the camera when recording video. Currently in your code you're toggling flashMode of the device, which should be replaced with torchMode for the feature to work properly.

Anw, thanks for the library!