yrwq / yafetch Goto Github PK

i tried to follow your "installation" but i had this issue.

WMctrl doesn't seem like a dependency, I don't have it and it seems fine, not sure why that would be a dependency, can you enlighten me on why you'd need that?

df needs to be run as super user, which is pretty annoying for a fetch, obviously running as super user fixes it, but it shouldn't be like that, also, the path it's not always correct.
df: /run/user/1000/doc: Operation not permitted
df: /run/user/1000/doc: Operation not permitted

https://github.com/yrwq/yafetch/blob/main/src/func.c#L35

You never free() new, I found this while
inspecting my fork of yafetch, might want to
take a look at this commit as a whole:

TruncatedDinoSour/yafetch@9522654

And maybe even adopting this script to
prevent future memory issues:

https://github.com/TruncatedDinosour/yafetch/blob/main/scripts/tests.sh

Just modify it to not include the ./configure script testing :)

The image is gone from README, you can use something like this:

![yafetch.jpg](https://github.com/TruncatedDinosour/yafetch/raw/main/media/yafetch.jpg)