Build on YOURLS/YOURLS#2633 to

• have timezone management compatible "core" (the functions in function files), but not ship a new core plugin. This way, if the plugin has bugs, or if we overlook a trivial feature, we can quickly update it without needing to push a new YOURLS release that would impact everybody including people not using the core plugin
• have a timezone management plugin here, with its own release cycle. Eventually, depending on adoption and feedback, it could become a core plugin like "random keywords" became.

TODO

• clean up PR 2633 and move plugin code here (@JeremyKeusters ?)
• mark this repo public as soon as initial import is made so anyone can have their say
• eventually I think the plugin needs to be fully i18n ready. I guess people interested in timezones may be using localized versions.

Code of Conduct

• I agree to follow this project's Code of Conduct.

Submission validity

• This is not a personal support request, that should be posted on discussions community.
• I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

• I've read the documentation and made sure to follow it.
• I've read the troubleshooting first steps guide.

Version

1.8.1

Description

Choosing UTC -8 in the pull down menu caused an error:

Fatal error: Uncaught Exception: DateTimeZone::__construct(): Unknown or bad timezone (UTC-8) in /home/xxxx/yourls/plugins/timezones/plugin.php:81 
Stack trace: 
#0 /home/xxxx/yourls/user/plugins/timezones/plugin.php(81): DateTimeZone->__construct('UTC-8') 
#1 /home/xxxx/yourls/user/plugins/timezones/plugin.php(95): yourls_tzp_timezoned_offset('UTC-8') 
#2 /home/xxxx/yourls/user/plugins/timezones/admin.php(46): yourls_tzp_timezoned_timestamp(1642550402, 'UTC-8') 
#3 /home/xxxx/yourls/includes/functions-plugins.php(775): yourls_tzp_admin_page() 
#4 /home/xxxx/yourls/admin/plugins.php(8): yourls_plugin_admin_page('time_zone_confi...') 
#5 {main} thrown in /home/xxxx/yourls/user/plugins/timezones/plugin.php on line 81

Expectation

No response

Reproduction steps

I simply chose UTC -8 in the pull down menu instead of a city name.

Context

No response

G'day,

In this array, you are missing Australia:

It is in the PHP class:
https://www.php.net/manual/en/class.datetimezone.php#datetimezone.constants.australia

I will get a pull request ready to fix.

Regards,
Christopher

Code of Conduct

• I agree to follow this project's Code of Conduct.

Submission validity

• This is not a personal support request, that should be posted on discussions community.
• I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

• I've read the documentation and made sure to follow it.
• I've read the troubleshooting first steps and frequent issues guides.

Version

1.19.1

Description

When attempting to change the timezone the following error is shown
Note that I'm using PHP 8.0.14
Fatal error: Uncaught PDOException: SQLSTATE[HY000]: General error: 1364 Field 'option_id' doesn't have a default value in \includes\vendor\aura\sql\src\AbstractExtendedPdo.php:565 Stack trace: #0 \includes\vendor\aura\sql\src\AbstractExtendedPdo.php(565): PDOStatement->execute() #1 \includes\vendor\aura\sql\src\AbstractExtendedPdo.php(237): Aura\Sql\AbstractExtendedPdo->perform('INSERT INTO you...', Array) #2 \includes\Database\Options.php(211): Aura\Sql\AbstractExtendedPdo->fetchAffected('INSERT INTO you...', Array) #3 \includes\Database\Options.php(159): YOURLS\Database\Options->add('timezone', Array) #4 \includes\functions-options.php(71): YOURLS\Database\Options->update('timezone', Array) #5 \user\plugins\timezones\admin.php(270): yourls_update_option('timezone', Array) #6 \user\plugins\timezones\admin.php(15): yourls_tzp_config_update_settings() #7 \includes\functions-plugins.php(815): yourls_tzp_admin_page() #8 \admin\plugins.php(8): yourls_plugin_admin_page('time_zone_confi...') #9 {main} thrown in \includes\vendor\aura\sql\src\AbstractExtendedPdo.php on line 565

Expectation

No response

Reproduction steps

1. Install plugin
2. Activate plugin
3. try and change timezone

Context

No response

Describe the bug
When creating a new link, the datetime shown in the admin is off by double the amount of hours from UTC. I set up my timezone as America/Los_Angeles, which is 8 hours less than UTC. However when I create a link, the time shown is 8 hours earlier than the local time, so it's 16 hours earlier than UTC.

To Reproduce
Create a new shortened link in the admin.

Expected behavior
The current date and time should be shown.

Actual behavior
The time shown is 8 hours earlier than what it actually is.

Versions
Yourls 1.8
CentOS 7.9