youngershen / django-easy-validator Goto Github PK

Hey guys, in validator file has an overlapping extra_rules. Look this case:

New rule:
`class UniqueCityCacheScheduler(BaseRule):
name = 'unique_city_cache_scheduler'
message = 'this city already scheduled, to change data delete or update then'
description = 'check if already exist city in cache_agendamentos_booking_table'

def check_value(self):
    self.status = True if self.field_value == 'test' else False

def check_null(self):
    pass`

Validator class (I have and adapter):
`class HotelCacheCreateScheduleRequest(RequestValidatorAdapter):

def __init__(self):
    self.request_json: HotelCacheCreateScheduleRequestData = None
    extra_rules = { UniqueCityCacheScheduler.get_name(): UniqueCityCacheScheduler}
    super().__init__(data=None, messages={}, interface=HotelCacheCreateScheduleRequestData,
                     extra_rules=extra_rules)

"""'
consts structure validators rules
"""
city = "required|max_length:255"
city_id = "unique_city_cache_scheduler"
checkin_range = city_id
checkout_range = checkin_range
update_minutes_interval = checkin_range`

In function _get_origin_rule of file validators.py:1183
def _get_origin_rule(self, name): # here code will not get default rules not seted rule = self.extra_rules.get(name, None) if self.extra_rules else default_rules.get(name, None) if not rule: raise RuleNotFoundError(name) else: return rule

Suggestion:
def _get_origin_rule(self, name): # here code will not get default rules not seted rule = self.extra_rules.get(name, None) if self.extra_rules.get(name, None) else default_rules.get(name, None) if not rule: raise RuleNotFoundError(name) else: return rule

For Example:
username = 'required|unique_against:members, name, '+ HttpRequest.POST.get('name')

When using regex syntax with | as separator brakes. For example on such regex ^\d+(,\d+)*(\|\d+(,\d+)*)*$. I'm forced to use "advanced" rule and implement my own regex rule:

class GroupedIds(BaseRule):
    name = 'grouped_ids'
    regex = r'^\d+(,\d+)*(\|\d+(,\d+)*)*$'
    message = _('{FIELD} is not a grouped integers. '
                'Example group: 1,2,3|4,5|99, where 1, 2 and 3 are in the first group')
    description = _('Check if current value is a group of integers separated by comma inside groups. '
                    'Groups are separated with  | ')

    def check_null(self):
        pass

    def check_value(self):
        self.status = True if re.match(self.regex, self.field_value) else False