Git Product home page Git Product logo

taylor's People

Contributors

lexorus avatar mihai8804858 avatar s2dentik avatar sunnypro avatar thelvis4 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

taylor's Issues

Taylor Crashes

When I try to run some taylor commands it crashes.

For example at the commands taylor -rc ExcessiveMethodLength=20 or taylor following error appears:

fatal error: Loading sourcekitd.framework/Versions/A/sourcekitd failed: file /Users/aculeva/Developer/SourceKitten/Source/SourceKittenFramework/library_wrapper.swift, line 59

Commands like taylor -v work, though.

I use version 0.1.3 and installed it with the .pkg file. Over Homebrew there were also some weird issues.

Integration tests issue

There is a continuously happening issue related to the fact that 'Wrapper.swift' file can't be copied to target directory because it already exists which causes Integration Tests to fail. It works once every two tries.

Cannot specify report with absolute path

If you try to specify json or pmd with an absolute path, it says "Error while writing the <XML|JSON> object to file."

Example:

taylor -r json:`pwd`/report.json 

Note: It works if you specify a relative path.

Incorrect number of parameters

Signing.swift:95 Method 'httpBody(parameters:encoding:)' has 4 parameters. The allowed number of parameters is 3
open static func httpBody(for parameters: [String: String], encoding: String.Encoding = .utf8) -> Data? {
    let combine: (String, String) -> String = { key, value in
        return rfc3986encode(key) + "=" + rfc3986encode(value)
    }

    return parameters.map(combine).joined(separator: "&").data(using: encoding)
}

is it possible to disable warnings for a single line/method?

I know that rules can be disabled via configuration, but I would like to disable warnings for single methods only - is this possible?

I.e. the cyclomatic complexity-warning is annoying when a method only contains a switch-statement, therefore I would like to disable it for that method. Can this be achieved somehow?

Crash when trying to run

Hi, I just installed Taylor via brew.

When I try running it I get:

Illegal instruction: 4

In both Xcode and terminal.

I tried to download and run the release version, but it just crashes.
Any idea of what could it be?

I'm running on a MacBook Pro with macOS HighSierra 10.13.3
With CLI Version: 9.2.0.0.1.1510905681

ExcessiveMethodLength counts "{" and "}" as part of the function length

If I have a method like:

func init
{
  let something = 1
  let another = somethingElse(start: 0,
                                end: 1)
  let anArray = [
    "1",
    "2",
    "3"
  ]
  
  if something == 1
  {
    dosomething()
  }
}

What should be the length for this function? 5 or 14?

My code style is that the { and } are on a line by itself for all keywords that require it, so this is causing false positives in my code. Functions that are really under 20 lines are being flagged due to brace being on a line by itself and some function calls that have their arguments stacked (as in the above).

Also when an array literal is defined, see above, all of the lines are counted as part of the function. While the lines are part of the function, they are not individual lines. The declaration of an array is a single line that is split into multiple lines.

Note: I would love to help out with this project. How can I help?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.