yohannfra / jenrik Goto Github PK

The dockerfile should install jenrik globally and do not do ./jenrik on CMD.
The best solution is to install a pypi package globally in the image, if you do #10 issue

An input command could be useful.

You could use the "manual" pipe as currently done, or pass the string to Popen.communicate, which pipes the string in the standard input of the process

It can already pipe the stdout and stderr to other programs before checking the results, piping to stdin would seem logical.

• Do not use python lastest but specified python version like 3.7 ou 3.8
• Use alpine light images for basic use cases like here

informations about the version and the help would be useful to see if we are up to date

a simple github action to insert on a workflow would be very useful

It would be great if we could set/change or unset environments variables for a test

It would be nice to be able to see if the program runs under a certain amount of time.
Like add an optional check for time and give the maximal value to pass the test.
Maybe also being able to put timeout, just in case!
Thanks

Even though TOML is a standard format, I think it would be useful to show how to add more than one argument in the args field

A github actions CI would be great in order to make sure the project is still compliant with tests policies

It would be awesome to have jenrik available as a python package usable with pip

when running locally after clone or even inside a docker container, the colored module is not found

docker run image_jenrik:latest ./jenrik ./tests/test_309.toml
Traceback (most recent call last):
  File "/app/./jenrik", line 7, in <module>
    import colored
ModuleNotFoundError: No module named 'colored'