ynoproject / ynobadges Goto Github PK

Rainbow Fish and Libra Palace badges do not work as intended; registered as an issue for tracking purposes.

Could be something like 100, 250, 500, 750, 1000 for the values, needs to be discussed

Leftover of a badge that was likely once planned for the online release of the game but that was never used.
Would probably be better to remove it if it is completely scrapped, otherwise it can be kept until it is finally used.

Yeah, I read the past PRs, and I'm sorry to say the Wedding Cake badge might still technically be broken: I obtained the notification for the badge unlocking alongside the (correctly) unlocked Virtual Mapper badge in the map room.

While I had been buying from vending machines prior to entry, at no point in time did I see the Wedding Cake amongst the food and drink spawned, and I don't think the delay between the last vending machine and interacting with the NPC in the map room of the Virtual City was short enough for it to be related, but I could be wrong about that.

In fact, looking at qxy's *V_Earth map event: Its comments claim they use variable 67 for the Y axis of their virtual map there (V[0067] : 移動量 Y). So that's probably the cause, even though scouring through the events I can't see where the variable gets used beyond being reset to 0 at the end... Anyway, if it IS the cause, my proposed solutions would be, from simplest to most painful sounding in my own opinion:

• Tying it to the game flipping the switch manipulating variable 4286 for the Snack Gallery's unlock instead (would punish players who have already unlocked the wedding cake in their save files until they make new ones, I guess); If the Wedding Cake's been consumed by the player, this variable in question should be 32768 or higher (highest should be 524287), with the only valid values being ones that, when divided by 2^16, will not return 0 when run through the modal %= 2 operation in the Snack Gallery's relevant map event
• Figuring out a way for EasyRPG to expose when it's running common events and tie the related badge(s) to Common Event 6 (i.e.- 自販機EV) only, if that's not already a thing
  Unfortunately, the map that the virtual map is in contains a vending machine somewhere (it's one of those 'multiple rooms on a single map' ones), so the idea of just excluding areas without vending machines doesn't work unless a specific exclusion for the region the virtual mapper NPC is in is made, which sounds like a pain personally and would also not prevent the issue from happening any time any other map event comes along and decides to use variable 67. But since that's something that's been done via YNOLocations' repo, it's a possibility. If it helps, exclude the following region inside map 1899: "coords": { "x1": 47, "y1": 41, "x2": 51, "y2": 43 } from being valid for the wedding cake and similar future food based badge unlocks, maybe.

Edit: Just wanted to specify this happened and was written with 0.120d Patch 5 in mind, in case anything's changed since.

Reported by prodzpod and basak back in September, would need to take a look at it once I have time.

There are two issues surrounding this badge:

• In Virtual City, the map room can trigger this badge when using it due to using the same variable than the one tracked (not sure if this one has changed since the latest qxy updates)
• The variable that is at first used to know which snack you should obtain is edited in the common event to give you your snack, making it unreliable since the variable can end up at the same value than the one wanted while buying another snack. As such, if possible, another variable would need to be triggered, or checking at which point in the common event is the interaction to know if the badge should be triggered or not (doing a map per map case isn't really possible due to the number of vending machines and random machines throughout the game).

A file with this content would need to be readded at badges/unevendream/rainy_garden_powerline.json:

{
  "bp": 10,
  "reqType": "tag",
  "reqString": "rainy_garden_powerline",
  "map": 58,
  "art": "Olive Deer",
  "batch": 26
}

The conditions and lang entries may also have to be edited, though those ones were not removed.