We need to make a decorator for \Psr\Log\LoggerInterface that will pass log into \Symfony\Component\Console\Logger\ConsoleLogger and original logger.

What steps will reproduce the problem?

1. Create console command
2. Inject \Psr\Log\LoggerInterface into command
3. Do $this->logger->info('This text should be visible in console'); in execute() method

What is the expected result?

I have output in console:

This text should be visible in console

What do you get instead?

Nothing happend

Actually, my previous PR with some tests for Console helper was inspired exactly by this discovery: one day I looked Yii2 helpers, and suddenly found some... rare syntax in PHP, let's say it that way.
I agree that sometimes it's not so bad to use goto, but I think it's not such case, and perhaps it's better to replace it with cycles.

https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseConsole.php#L799
https://github.com/yiisoft/yii2/blob/master/framework/helpers/BaseConsole.php#L872

I can make PR, if you share my opinion, after accepting my tests PR.

What steps will reproduce the problem?

Create new project. Add console command.

What is the expected result?

Console command is available.

What do you get instead?

Console command is not available, until configuration rebuild.

Additional info

Design for configuration rebuild is now (as of 2020-11-12):

1. Configuration rebuilds every request and every console command in "dev" environment by default.
2. Configuration DO NOT rebuilds in "prod" environment by default.
3. New project is created in "dev" environment mode.

Current console package implementation treats non-set variable YII_ENV as "prod" environment, therefore you have "prod" environment mode right after you have created new project.

It would be nice if the column headers would be repeated every x data rows, so you don't loose track which column is which. x could be linked to the window height.

I think about something like this:

+---------------+----------+-----------+------------+------------+
| name          | can read | can write | can update | can delete |
+---------------+----------+-----------+------------+------------+
| john.doe      |    1     |     0     |    0       |    0       |
+---------------+----------+-----------+------------+------------+
<about x rows>
+---------------+----------+-----------+------------+------------+
| name          | can read | can write | can update | can delete |
+---------------+----------+-----------+------------+------------+
| jane.doe      |    1     |     1     |    1       |    1       |
+---------------+----------+-----------+------------+------------+

Hello I have an error after last update

PHP Fatal error:  Uncaught Yiisoft\Definitions\Exception\NotFoundException: No definition or class found or resolvable for Psr\EventDispatcher\EventDispatcherInterface while building Yiisoft\Yii\Console\SymfonyEventDispatcher -> Psr\EventDispatcher\EventDispatcherInterface. in .../vendor/yiisoft/di/src/Container.php:406

Here is potential place of error:

<?php

declare(strict_types=1);

use Symfony\Component\Console\CommandLoader\CommandLoaderInterface;
use Symfony\Component\Console\Input\InputOption;
use Yiisoft\Definitions\Reference;
use Yiisoft\Yii\Console\Application;
use Yiisoft\Yii\Console\CommandLoader;
use Yiisoft\Yii\Console\SymfonyEventDispatcher;

/** @var array $params */

return [
    CommandLoaderInterface::class => [
        'class' => CommandLoader::class,
        '__construct()' => [
            'commandMap' => $params['yiisoft/yii-console']['commands'],
        ],
    ],

    Application::class => [
        'class' => Application::class,
        '__construct()' => [
            Reference::to(SymfonyEventDispatcher::class),
            $params['yiisoft/yii-console']['name'],
            $params['yiisoft/yii-console']['version'],
        ],
        'setAutoExit()' => [$params['yiisoft/yii-console']['autoExit']],
        'setCommandLoader()' => [Reference::to(CommandLoaderInterface::class)],
        'addOptions()' => [
            new InputOption(
                'config',
                null,
                InputOption::VALUE_REQUIRED,
                'Set alternative configuration name'
            ),
        ],
    ],
];

With : separator you can run command doctrine:migrations:diff by d:mi:di.
This do not work for / separator. E.g. debug/reset can't be executed by d/r

It could be a good idea to introduce abstraction layer before release to be able to do our own implementation if needed later.

See https://forum.yiiframework.com/t/cons-and-pros-of-using-symfony-console/126425/14

What steps will reproduce the problem?

What is the expected result?

What do you get instead?

Additional info

What steps will reproduce the problem?

http=>https

What is the expected result?

What do you get instead?

Additional info

Current configuration:

<?php

return [
    'app' => function (\Psr\Container\ContainerInterface $container) {
        $app = new \Yiisoft\Yii\Console\Application();
        $loader = new \Symfony\Component\Console\CommandLoader\ContainerCommandLoader($container, [
            'serve' => 'serve',
        ]);
        $app->setCommandLoader($loader);
        return $app;
    },

    // commands
    'serve' => \Yiisoft\Yii\Console\Command\Serve::class,
];

Issues:

1. Have to add serve in two places.
2. app config is not merge-able.

Current version

return [
     'app' => function () {
           ...
     },
]

and in yii

$container->get('app')->run();

After:

return [
     Application::class => function () {
           ...
     },
]

and in yii

$container->get(Application::class)->run();

Currently exceptions are print into stdout and aren't logged. Need logging to be configurable.

• See https://symfony.com/doc/2.6/cookbook/console/logging.html#enabling-automatic-exceptions-logging
• See yiisoft/demo#255

What steps will reproduce the problem?

1. Enable XDebug profiling
2. Set breakpoint
3. Run XDEBUG_TRIGGER=yes php -dxdebug.mode=debug yii serve in console
4. Run code where you set breakpoint

What is the expected result?

IDE catches the running at needed line

What do you get instead?

IDE doesn't catch nothing

Supposed solution

The problem is located on https://github.com/yiisoft/yii-console/blob/master/src/Command/Serve.php#L97
That command should consider arguments what was passed to original process.

What steps will reproduce the problem?

I must set all of rows in one piece

    public function setRows(array $rows)
    {
        $this->_rows = array_map('array_values', $rows);
        return $this;
    }

I wish to add row-by-row in my iterator's...

It should be $autOloadPath

This is (I think) an error also in Yii2 console.

Help controller actions list is wrong because \yii\console\Application has wrong controllerNamespace that returns wrong list here:

This is the test match list:

but if we look at controllers folder list :

The console error message only contains the filename, for example "In GroupManager.php line 131:".

I would like you to add the full path to the file in order to better understand the package of the file.

Currently Symfony console instantiates every command when making a list. That means all the dependencies are instantiated as well. Some of these such as Cycle, are making SQL queries.

Overall, instantiating every command isn't needed since what we need is some meta-data that seems to be OK as static.

TODO:

• Support static $defaultDescription property. #124
• Document it.
• Apply to yii-cycle.
• Apply to debug.
• Apply to migrations.
• Apply to router/list (demo).
• Apply to user/create (demo).

What steps will reproduce the problem?

Command:

final class CreateUser extends Command
{
    protected static $defaultName = 'user/create';
    public function __construct(
        private NonExistsClass $userApi,
    ) {
        parent::__construct();
    }
}

What is the expected result?

Exception with message about not instantiable class CreateUser.

What do you get instead?

The command "user/create" does not exist.

See also

What steps will reproduce the problem?

Install a project template, people complaining about too complicated setup.

What is the expected result?

Example commands

$ yii init
Querying application bases...
[1] yii-base-web
[2] yii-base-api
[3] yii-base-cli
Which one(s) do you want to install?

What do you get instead?

Copy and paste command from docs.

Seems as typo and possible meaning 'yii\console\controllers' ? There are no class '\yii\console\controllers' - its a directory

See https://forum.yiiframework.com/t/what-would-be-your-preferred-console-syntax/126506

• Need to document aliases and hidden commands #124
• Need to document static name and description.

What steps will reproduce the problem?

Create a console command that does echo.
Try to create an automated test for it.

public function actionEcho($str) {
    $this->stdOut($str);
}

What is the expected result?

I should be able to test my code.
I should not be getting output on screen when running my tests.

What do you get instead?

Due to the fact BaseConsole::stdOut uses fwrite(\STDOUT it is hard to properly test the output.

Additional info

What steps will reproduce the problem?

1, Folder structure

- App
  -- Commands
      --- HelloController.php
- config
   -- common.php
   -- console.php
   -- params.php
...
- vendor
- composer.json

2, composer.json

 { 
...
 "extra": {
        "branch-alias": {
            "dev-master": "3.0.x-dev"
        },
        "config-plugin": {
            "params": ["config/params.php"],
            "common": ["config/common.php"],
            "console": [
                "$common",
                "config/console.php"
            ]
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "App",
            "Lib\\": "Lib"
        }
    },
}
...

3. config parts

console.php

return [
    'app' => [
        'controllerNamespace' => 'App\Commands', // (Also trying with App\Commands::class)
    ],
];

common.php

return [
   'app' => [
        'basePath' => dirname(__DIR__) . '/App',
    ],
   ....
]

When i run
/vendor/bin/yii hello/index - all correct, it works

When i run
/vendor/bin/yii help - gotcha error

Error: Invalid path alias: @/App/Commands

Also if i add in my HelloController@actionIndex print app->controllerPath, error also reproduced

public function actionIndex(): int
    {
        $this->stdout('Hello, Yii3'.PHP_EOL, Console::FG_PURPLE); //It`s normal
        // With this line  error reproduced
        $this->stdout($this->app->controllerPath.PHP_EOL, Console::FG_PURPLE);

        return ExitCode::OK;
    }

What is the expected result?

alias should be '@App/Commands'

What do you get instead?

Error: Invalid path alias: @/App/Commands

Additional info

bin/yii file is using our own DI container. I guess we shouldn't require it, but we should not use it directly. Any suggestions?

@bscheshirwork commented on Oct 15, 2018, 8:42 AM UTC:

What steps will reproduce the problem?

I try to improve alias -y #16787 but I can't use this construction

What is the expected result?

Way to create alias within value of option

What do you get instead?

not implemented

Additional info

Fr example we can use syntax of 2-element array

['aliasKey' => ['commandOption', 'optionValue']]

we can replace

->

    public function optionAliases()
    {
        return array_merge(parent::optionAliases(), [
            'C' => 'comment',
            'f' => 'fields',
            'p' => 'migrationPath',
            't' => 'migrationTable',
            'F' => 'templateFile',
            'P' => 'useTablePrefix',
            'c' => 'compact',
            'y' => ['-interactive', 0],
        ]);
    }

                        if (is_array($optionAliases[$name])) {
                            $params[array_shift($optionAliases[$name])] = array_shift($optionAliases[$name]);
                        } else {
                            $params[$optionAliases[$name]] = $value;
                        }

How about this?

This issue was moved by samdark from yiisoft/yii2#16788.

When I develop different projects, there is a need to run them at the same time. I need to configure for each project its own port for ./yii serve command.

Class \Yiisoft\Yii\Console\Command\Serve is finalized and DEFAULT_PORT is private const. I can't extend it and redeclare DEFAULT_PORT.

I can write script serve with simple content ./yii serve --port=8081 etc. and ignore it by git. But this solution looks like a crutch

https://github.com/yii-extension/simple-app/actions/runs/1452155844

1. ErrorCest: See error page.
   Test tests\acceptance\ErrorCest.php:testErrorPage

[GuzzleHttp\Exception\ConnectException] cURL error 7: Failed to connect to localhost port 8080: Connection refused (see
https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http://localhost:8080/about

Scenario Steps:

2. $I->amOnPage("/about") at tests\acceptance\ErrorCest.php:14
3. // I am going to go to the error page

#1 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Handler\CurlFactory.php:210
#2 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Handler\CurlFactory.php:158
#3 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Handler\CurlFactory.php:110
#4 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Handler\CurlHandler.php:47
#5 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\PrepareBodyMiddleware.php:35
#6 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Middleware.php:37
#7 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\RedirectMiddleware.php:55
#8 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Middleware.php:63
#9 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\HandlerStack.php:75
#10 D:\a\simple-app\simple-app\vendor\guzzlehttp\guzzle\src\Client.php:331

With the integrated PHP server curl does not fail.

Feature request

symfony/console is a great component which many frameworks used. So can we support it , or how can I integrate with it seamless?

https://symfony.com/doc/current/components/console.html

Configuration path (config-plugin-output-dir) can be set in composer.json, but is hardcoded in this package.

After #124 aliased commands are properly displayed in the list but still they can not be executed using alias.

See https://symfony.com/blog/new-in-symfony-5-4-console-autocompletion

https://github.com/symfony/symfony/pull/43598/files

Need it for:

• https://github.com/yiisoft/yii-console/blob/master/src/Command/Serve.php
• https://github.com/yiisoft/yii-db-migration/tree/master/src/Command

For example ./yii list debug:

2023-02-10 13:23:45.064400 [error][application] Symfony\Component\Console\Exception\NamespaceNotFoundException: There are no commands defined in the "debug" namespace. in /var/www/app/vendor/symfony/console/Application.php:632 while running console command "list".

Message context:

exception: Symfony\Component\Console\Exception\NamespaceNotFoundException: There are no commands defined in the "debug" namespace. in /var/www/app/vendor/symfony/console/Application.php:632
Stack trace:
#0 /var/www/app/vendor/symfony/console/Descriptor/ApplicationDescription.php(87): Symfony\Component\Console\Application->findNamespace('debug')
#1 /var/www/app/vendor/symfony/console/Descriptor/ApplicationDescription.php(64): Symfony\Component\Console\Descriptor\ApplicationDescription->inspectApplication()
#2 /var/www/app/vendor/symfony/console/Descriptor/TextDescriptor.php(185): Symfony\Component\Console\Descriptor\ApplicationDescription->getCommands()
#3 /var/www/app/vendor/symfony/console/Descriptor/Descriptor.php(43): Symfony\Component\Console\Descriptor\TextDescriptor->describeApplication(Object(Yiisoft\Yii\Console\Application), Array)
#4 /var/www/app/vendor/symfony/console/Helper/DescriptorHelper.php(65): Symfony\Component\Console\Descriptor\Descriptor->describe(Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput), Object(Yiisoft\Yii\Console\Application), Array)
#5 /var/www/app/vendor/symfony/console/Command/ListCommand.php(71): Symfony\Component\Console\Helper\DescriptorHelper->describe(Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput), Object(Yiisoft\Yii\Console\Application), Array)
#6 /var/www/app/vendor/symfony/console/Command/Command.php(312): Symfony\Component\Console\Command\ListCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput))
#7 /var/www/app/vendor/symfony/console/Application.php(1040): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput))
#8 /var/www/app/vendor/symfony/console/Application.php(314): Symfony\Component\Console\Application->doRunCommand(Object(Symfony\Component\Console\Command\ListCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput))
#9 /var/www/app/vendor/symfony/console/Application.php(168): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput))
#10 /var/www/app/vendor/yiisoft/yii-runner-console/src/ConsoleApplicationRunner.php(62): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Yiisoft\Yii\Console\Output\ConsoleBufferedOutput))
#11 /var/www/app/yii(11): Yiisoft\Yii\Runner\Console\ConsoleApplicationRunner->run()
#12 {main}
time: 1676035425.064434
memory: 5885920
category: 'application'

@bscheshirwork commented on Oct 15, 2018, 7:44 AM UTC:

What steps will reproduce the problem?

I must typing --interactive=0 or confirm command each time
This keyword is not so short...

What is the expected result?

I expect the sugar alias options -y for applying migration's command

What do you get instead?

non-autocomplited --interactive=0 only

Additional info

https://github.com/yiisoft/yii2/blob/master/framework/console/Controller.php#L51-L54

This issue was moved by samdark from yiisoft/yii2#16787.

Running console command, if a fatal error happens, I get no error message.

This behavior is annoying and makes it harder to debug problems.

What steps will reproduce the problem?

Run console command with fatal bug, for example missing argument in some constructor call.

What is the expected result?

Eror is displayed in console output

What do you get instead?

No error messages, just silently exit with error code 1

Additional info

This event need to move to application tempates.

ConsoleErrorEvent::class => [
    [ErrorListener::class, 'onError'],
],

See yiisoft/yii2@cffb383#commitcomment-19798475

As it was in Yii 2. See discussion https://forum.yiiframework.com/t/cons-and-pros-of-using-symfony-console/126425/14