ycrypto / p256-cortex-m4 Goto Github PK

unsafe refers to memory safety, not generally "dangerous" APIs. I don't think it should be use for this kind of use cases. For example, neither the secrecy or untrusted use unsafe this way.

To warn against exporting the secret key, I'd recommend removing unsafe and renaming it to subtle_to_bytes or something similar.

From my understanding EcDSA does not necessarily expect the hash output to be exactly the size of a scalar. If it is larger, it is instead truncated.

Would be good to add e.g. http://point-at-infinity.org/ecc/nisttv analogous to RustCrypto/elliptic-curves#570.

Or really as much of https://github.com/RustCrypto/elliptic-curves/tree/master/p256/src/test_vectors as applicable.