Git Product home page Git Product logo

slack-gitsin's People

Contributors

afagarap avatar chid avatar yasintoy avatar yigitozkavci avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

slack-gitsin's Issues

Turkish character problem

"Merhaba Dünya" :(

slack> slack chat.postMessage "Merhaba DüException in thread Thread-77:
Traceback (most recent call last):
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 810, in __bootstrap_inner
self.run()
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/threading.py", line 763, in run
self.__target(_self.__args, *_self.__kwargs)
File "/Users/gokhan/Documents/env/lib/python2.7/site-packages/prompt_toolkit/interface.py", line 835, in run
completions = list(buffer.completer.get_completions(document, complete_event))
File "/Users/gokhan/Documents/Slack-Gitsin/slackClient/utils.py", line 25, in find_matches
word, collection, fuzzy):
File "/Users/gokhan/Documents/Slack-Gitsin/slackClient/utils.py", line 83, in _find_collection_matches
if name.lower().startswith(word) or not word:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 1: ordinal not in range(128)

saj" general gakgak

Pagination Problem

While writing channel posts, it's really slow.We have to make a pagination(10-15 per message)

Doesnt seem to work

readme shows you start by running python main.py, but all I get is the following

$ python main.py 
Traceback (most recent call last):
  File "main.py", line 29, in <module>
    from utils import TextUtils
  File "/home/nhumrich/open-source/Slack-Gitsin/slackClient/utils.py", line 13, in <module>
    from completions import META_LOOKUP
  File "/home/nhumrich/open-source/Slack-Gitsin/slackClient/completions.py", line 13, in <module>
    user_id = response["user_id"]
KeyError: 'user_id'

ImportError: No module named pygments.style

I'm on OS X El Capitan and getting this error:
ImportError: No module named pygments.style

This is being resolved after adding it to the requirements file. Going to make a pr.

Real time messaging

When I first started to this project, I thought that it'll be just for special times(vagrant+spotify+slack+chrome+pycharm) but now, I changed my mind. People loved SlackGitsin so we'll make it better together. Real time chat will be added soon.

Linux install script is ubuntu only

the linux install script is for ubuntu only, it has apt-get in it. It might be better to just document the requirements and tell people they will need to install them.

Missing license?

I noticed there is no license for this project, one should be picked to ensure legal certainty when using the software. More information on the Choose a License site.

Suggestion: More Organised README

Currently, when user visits the README page, after the Installation part, finds himself in Notifications and TODO part which I think are not relevant & shouldn't be there. I suggest a categorisation like this:

  • Problem
  • Installation
  • Getting Started
  • Advanced Usage(we can mention some extras here)
  • TODO
  • Contributing
  • Licence

What do you think?

No module named slackclient

Once install script is completed and token added to settings.py, upon 'python main.py' command:

Traceback (most recent call last):
File "main.py", line 15, in
import slackclient #for real time parts
ImportError: No module named slackclient

If running with python3:

File "main.py", line 84
print "Connection Failed, invalid token?"
^
SyntaxError: Missing parentheses in call to 'print'

Token is correct and tested on other app.

Suggestion: A better installation process

Currently users have hard time installing the project. Getting started is a great entry barrier.

I'm thinking of creating a binary for Mac OS X and all other Unix distributions. pyinstall is a nice problem solver in this case. It basically creates a dist/ folder with a binary inside it and we can copy it to user's /usr/local/bin at runtime.

Concerns:
We currently require user to provide a Slack API Token inside settings.py. In this case, we have to request api token from the user when program runs, and save it to user's home directory for further uses, with a warning indicating we are saving the api token to home directory.
This is no safer than entering the api key to settings.py, but still not a safe process. What do you think? @yasintoy

What is the right command to run?

On Mac OS X, I need to run python main.py in order to get in to the buffer.
If this is the case, should we tell people to run this command in order to get started? Because I needed to look into the source code to figure it out.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.