Git Product home page Git Product logo

Comments (3)

kasunvp avatar kasunvp commented on May 28, 2024

Just an addition to the above, looks like the problem persists even without being inside of another modal. Can anyone please confirm on this?
Thanks.

from ember-modal-dialog.

chrislopresto avatar chrislopresto commented on May 28, 2024

@kasunvp There may have been a programmatic problem with the close behavior of nested modals because we weren't calling super in the didInsertElement and willDestroyElement hooks. That is fixed in the 0.8.2 release I just published.

That being said, click outside to close appears fine in standard usage. You can see it in action in the demo app here: http://yapplabs.github.io/ember-modal-dialog/

If you're still having problems, could you post some more context? Thanks.

from ember-modal-dialog.

kasunvp avatar kasunvp commented on May 28, 2024

@chrislopresto Thanks for the quick turn around. I tried the 0.8.2 release and it doesn't work for my context either. To make that more clear to you I'm attaching screenshots of a simple app I made with two components, one being the main/outer modal and the others being inner modal.

Also, vimeo link below is a 1 min screencast which shows the problem I encounter.
(To make it clear that our main web app doesn't have a programmatic interference with ember-modal-dialog I created this new Ember cli app and it uses Ember-cli 1.13.8 and Ember 1.13.10)

Screencast: https://vimeo.com/143852248

Application template
application_hbs

x-modal-outer component / main modal
x-modal-outer_js
x-modal-outer_hbs

x-modal-inner component / sub modal
x-modal-inner_js
x-modal-inner_hbs

modal styles
app_css

from ember-modal-dialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.