Comments (3)
Just an addition to the above, looks like the problem persists even without being inside of another modal. Can anyone please confirm on this?
Thanks.
from ember-modal-dialog.
@kasunvp There may have been a programmatic problem with the close behavior of nested modals because we weren't calling super in the didInsertElement
and willDestroyElement
hooks. That is fixed in the 0.8.2 release I just published.
That being said, click outside to close appears fine in standard usage. You can see it in action in the demo app here: http://yapplabs.github.io/ember-modal-dialog/
If you're still having problems, could you post some more context? Thanks.
from ember-modal-dialog.
@chrislopresto Thanks for the quick turn around. I tried the 0.8.2 release and it doesn't work for my context either. To make that more clear to you I'm attaching screenshots of a simple app I made with two components, one being the main/outer modal and the others being inner modal.
Also, vimeo link below is a 1 min screencast which shows the problem I encounter.
(To make it clear that our main web app doesn't have a programmatic interference with ember-modal-dialog I created this new Ember cli app and it uses Ember-cli 1.13.8 and Ember 1.13.10)
Screencast: https://vimeo.com/143852248
x-modal-outer component / main modal
x-modal-inner component / sub modal
from ember-modal-dialog.
Related Issues (20)
- Cannot call `nextSibling` of null HOT 1
- Config Generator not adding ember-modal-dialog attrs in Ember 3.12 HOT 1
- focus content HOT 1
- Octane!
- error get onClose HOT 2
- `.emd-wrapper-target-attachment-center .ember-modal-dialog` is missing `position: absolute`
- ember-animated integration examples? HOT 2
- Does this work with Embroider? HOT 15
- Breaks in Ember 3.22 HOT 2
- Deprecation warnings with Ember 3.26+ HOT 5
- Issue with ember 3.27 HOT 6
- Update ember-wormhole to v0.6.0
- Ember v3.27: Exception on Ember.computed.reads (liquid-wormhole) HOT 4
- Use of old addon https://github.com/ef4/ember-ignore-children-helper
- Release of 4.0.0? HOT 3
- does not work with engines (release 4.0.0-alpha.1) HOT 6
- Convert to v2 addon
- Ember 3.26+: TypeError: this.overlayClassNames?.join is not a function
- tarball data corrupted? HOT 1
- Ember 3.28: TypeError: this.containerClassNames.join is not a function HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-modal-dialog.