Comments (15)
Yes with staticHelpers: true
it seems you must install the ember-tether
package even if you don't use tethering.
from ember-modal-dialog.
As of 4.0.0, it should be compatible with Ember 4 + Embroider
from ember-modal-dialog.
@lukemelia can you achieve this with ember-try and @embroider/macros? Curious because I'm thinking of doing something similar
I don't see any reason that wouldn't work.
from ember-modal-dialog.
when staticComponents is set to true, I get a more specific error:
Build Error (PackagerRunner) in node_modules\ember-modal-dialog\templates\components\modal-dialog.hbs
Module Error (from C:/Users/chris/Documents/GitHub/roast-ember/node_modules/@embroider/webpack/src/webpack-hbs-loader.js):
Unsafe dynamic component modalDialogComponentName in $TMPDIR\embroider\792ec2\node_modules\ember-modal-dialog\templates\components\modal-dialog.hbs
from ember-modal-dialog.
With staticHelpers: true
also
Module Error (from /app/node_modules/@embroider/hbs-loader/src/index.js):
Missing component or helper: ember-tether in node_modules/ember-modal-dialog/templates/components/tether-dialog.hbs
from ember-modal-dialog.
I'm seeing Unsafe dynamic component: this.modalDialogComponentName in $TMPDIR/embroider/4a2375/node_modules/ember-modal-dialog/templates/components/modal-dialog.hbs/modal-dialog.hbs
from ember-modal-dialog.
@lukemelia are there any plans to make this addon embroider and/or Ember 4 compatible?
from ember-modal-dialog.
@rwwagner90 I definitely intend for it to be compatible with Embroider and Ember 4. I haven't gotten there on my apps yet, so haven't been able to prioritize that work, but I am happy to support anyone who wants to take it on.
from ember-modal-dialog.
This should be fixed in 4.0.0-beta.0, thanks to @rwwagner90
from ember-modal-dialog.
The issue with ember-tether may persist. I think we'll have to add it as a peer dep. Will open a PR for that now.
from ember-modal-dialog.
from ember-modal-dialog.
@lukemelia I think we still need #371 or people will all have to install ember-tether themselves
from ember-modal-dialog.
@rwwagner90 I started looking at #371, and in order to have test coverage working well with optional peer dependencies, I think we'll need to move to the v2 addon monorepo pattern, with a test app that has optional deps installed and one that doesn't. I created #373 to track.
from ember-modal-dialog.
@lukemelia perhaps I am misunderstanding how it works, but can't we just ship it as a normal peerDependency
? The users will get a warning that they need to install it, but they shouldn't actually have to, I think.
from ember-modal-dialog.
test app that has optional deps installed and one that doesn't
@lukemelia can you achieve this with ember-try
and @embroider/macros
? Curious because I'm thinking of doing something similar
from ember-modal-dialog.
Related Issues (20)
- error get onClose HOT 2
- `.emd-wrapper-target-attachment-center .ember-modal-dialog` is missing `position: absolute`
- ember-animated integration examples? HOT 2
- Breaks in Ember 3.22 HOT 2
- Deprecation warnings with Ember 3.26+ HOT 5
- Issue with ember 3.27 HOT 6
- Update ember-wormhole to v0.6.0
- Ember v3.27: Exception on Ember.computed.reads (liquid-wormhole) HOT 4
- Use of old addon https://github.com/ef4/ember-ignore-children-helper
- Release of 4.0.0? HOT 3
- does not work with engines (release 4.0.0-alpha.1) HOT 6
- Convert to v2 addon
- Ember 3.26+: TypeError: this.overlayClassNames?.join is not a function
- tarball data corrupted? HOT 1
- Ember 3.28: TypeError: this.containerClassNames.join is not a function HOT 1
- Update to ember-tether 3.0.0 HOT 6
- 4.1.3 - need to wait until modal overlay is opened (in test) HOT 1
- not able to stub router service in tests HOT 1
- Access to `navigator` in module scope crashes Fastboot HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-modal-dialog.