Template Deprecations (due to `bind-attr` and `classNameBindings`) with 1.13+. about ember-modal-dialog HOT 5 CLOSED

@rwjblue what is the best pattern for addons supporting multiple versions of Ember with respect to this kind of thing? Should we have separate versions of the templates and conditionally use the correct one?

from ember-modal-dialog.

I can see two potential solutions (likely there are more):

1. Maintain two template files, and implement an treeFor that returns the right one.
2. Maintain two branches.

Clearly 2 is not great...

from ember-modal-dialog.

@rwjblue looking into your suggested solution "1" now, and realized that (unless I missed something) I don't know the Ember version an app is using from within the addon.

from ember-modal-dialog.

@rwjblue Also found that ember-cli was missing the treeForAddonTemplates hook, which is where we would need to customize. Added it here: ember-cli/ember-cli#4159

from ember-modal-dialog.

Working on a fix here: #41

from ember-modal-dialog.