Git Product home page Git Product logo

Comments (5)

lukemelia avatar lukemelia commented on May 27, 2024

This would be a useful feature.

The modal-overlays div should not be functional IMO, besides being the attachment point for the modal. There is nothing in this library to prevent rendering multiple modals into modal-overlays, so having it fire close would be strange since it wouldn't be clear what component it should be routed to. We could consider making the modal a child of the ember-modal-overlay element.

from ember-modal-dialog.

varblob avatar varblob commented on May 27, 2024

@samselikoff I've been using this styling

.ember-modal-overlay {
  height: 100vh;
  left: 0;
  opacity: 0;
  position: fixed;
  right: 0;
  top: 0;
  z-index: 50;
}
.ember-modal-dialog {
  z-index: 50;
  position: absolute;
  left:50%;
}

.ember-modal-dialog > div{
  position: relative;
  right: 50%;
}

.ember-modal-overlay.translucent {
  opacity: 0.77;
  filter: alpha(opacity=15);
  background-color: #808080;
}

along with alignment top to handle large models. I haven't put it through the any sort of rigorous testing yet so use with caution.

from ember-modal-dialog.

laksmaria avatar laksmaria commented on May 27, 2024

yes @lukemelia you're right. Also the modal should retain the center position even after the content height & width changed in the run time.

from ember-modal-dialog.

samselikoff avatar samselikoff commented on May 27, 2024

agree. i think we should make the modal a child of ember-modal-overlay. havent had time to come back to this yet.

from ember-modal-dialog.

lukemelia avatar lukemelia commented on May 27, 2024

Addressed by #79

from ember-modal-dialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.