yannjor / krabby Goto Github PK

Hey @yannjor I finally got around to testing your codebase and added a column to the comparison table.

Let me know if you have any qualms or suggestions.

One thing to note, is that the bash script pokeget (cached) is actually faster than krabby (cached). I was wondering if you have any thoughts and if u can also reproduce those results.

Comparing with the old version of the bash script, I get that krabby is 1.3x slower instead of 7x faster.

name subcommand already has a --shiny flag, which makes it possible to display a shiny version of a specified Pokemon.

random subcommand could also have that flag so that we could get a random shiny Pokemon.

I know it's possible to achieve this by setting the shiny probability to 1 in the configuration file, but a flag would be nice too. I can imagine some use cases with that.

Is there an option to get this output to neofetch? (using image_source command output)

It would be great to be able to specify a number of spaced for padding (e.g., on the left). This would allow having an output like (sorry, the ANSI characters don't render well here on GitHub):

$ krabby random --padding-left 8
        Clefairy
          ▄▀▄ ▄▄▄         
          ▀▀▀▀▀▀▀▀▄▄▄▄▄▄  
          ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄ 
         ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
        ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄
        ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
         ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀ 
         ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀  
             ▀▀▀▀▀▀▀▀▀▀   
                ▀▀ 

instead of

$ krabby random
Clefairy
  ▄▀▄ ▄▄▄         
  ▀▀▀▀▀▀▀▀▄▄▄▄▄▄  
  ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄ 
 ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▄
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
 ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀ 
 ▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀  
     ▀▀▀▀▀▀▀▀▀▀   
        ▀▀ 

It would simply mean prefixing every output line with X amount of spaces.

I was charmed by your project, so I wrote a PKGBUILD that tracks the main branch

pkgbase='krabby-git'
pkgname='krabby-git'
pkgver=0.1.6.r0.g2669909
pkgrel=1
pkgdesc='Print pokemon sprites in your terminal (development version)'
arch=('x86_64')

url='https://github.com/yannjor/krabby'
license=('GPL-3.0')

makedepends=('rust')
conflicts=('krabby')

source=("${pkgname}::git+https://github.com/yannjor/krabby#branch=main")
md5sums=('SKIP')

pkgver() {
    git -C "${pkgname}" describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

build() {
    cd "${pkgname}"

    cargo build --release
}

package() {
    install -Dm755 "${pkgname}/target/release/krabby" -t "${pkgdir}/usr/bin"
    install -Dm644 "${pkgname}/LICENSE" "${pkgdir}/usr/share/licenses/${pkgname}/LICENSE"
}

I noticed that the krabby-git AUR package is orphaned, perhaps you can adopt it & update it using this script (I would do it myself, but I figured you might prefer to do it yourself considering it's your project). A krabby package might be nice as well; I could write a PKGBUILD for that as well if you want.

Add shell completions for the name command. This should be possible with clap. See: https://dev.to/kbknapp/cli-shell-completions-in-rust-37g1