xxxazxxx / substruct Goto Github PK

What steps will reproduce the problem?
1. Go to the admin section.
2. Create one tag, try to create another with the same name.

What is the expected output? What do you see instead?
It should popup a warning. An error rendered as a partial.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

NoMethodError in Admin/tagsController#create

undefined method `render_text' for #<Admin::TagsController:0xb6a5c880>

RAILS_ROOT: /home/edmundo/workspace_aptana/substruct_rel_1-0-a2
Application Trace | Framework Trace | Full Trace

vendor/plugins/substruct/app/controllers/admin/tags_controller.rb:48:in
`create'
...

In tags_controller:

...
def create
  @tag = Tag.new(params[:tag])
  if params[:id]
    @tag.parent_id = params[:id]
  end
  if @tag.save
    render(:partial => 'tag_list_row', :locals => {:tag_list_row => @tag})
  else
    render_text ""
  end
end
...

When not saved, it tries to render nothing, and render_text is a deprecated
method, use render :text => "" instead.

Regards.

If you run rake substruct:db:bootstrap, it doesn't insert the proper 
plugin_schema_version for 
substruct, causing problems when trying to run a migration later on.

This has been fixed.

What steps will reproduce the problem?
1. Go to the application directory.
2. Type rake test:plugins PLUGIN=substruct

What is the expected output? What do you see instead?
It should execute the tests, but it just abort.

What version of the product are you using? On what operating system?
substruct_rel_0-97 on Ubuntu Feisty Fawn (7.04)

Please provide any additional information below.

Output on console:
./vendor/plugins/substruct/test/unit/../test_helper.rb:4: undefined method
`config' for Engines:Module (NoMethodError)
...
rake aborted!
Command failed with status (1): [/usr/bin/ruby1.8 -Ilib:test "/usr/lib/ruby...]

I don't have sure when the tests stopped to be maintained or how it was
different in the past, but the documentation of engines plugin shows that
its only needed two lines of code to make it work. It's pretty the same
thing but using a temporary path defined by a method inside
Engines::Testing. So we get rid of config options but continue to use
fixtures inside the plugin directory (why do they copy the fixtures to /tmp?)

The tests doesn't run, it references things that doesn't exists anymore,
the fixtures appears to have been erased. So appears the it should be
redone completelly.

I think this is a very important thing, as now theres no references to see
if a patch breaks something or not, just trying to make the unit tests for
three classes I already found some issues, and the fixes are beeing tested
by hand. 

What steps will reproduce the problem?
1. Upload some images to products.
2. Go to the screen that creates a new content node.

What is the expected output? What do you see instead?
The right panel called "Latest File Uploads" should show latest files that
was uploaded. Instead its messed up.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
The controller has a problem loading the user_uploads records, it loads
even the thumbnails, so at least tree same files?
Theres a problem with the code in the view too @file.type (an attribute)
clashes with the deprecated type method that returns the class of the
object, and a comparison using Image (a class) instead of "Image" a string. 

What steps will reproduce the problem?
1.  Start a fresh copy in development mode 
2.  create product
3.  upload image to product

What is the expected output? What do you see instead?
should work.  Instead says
ActiveRecord::AssociationTypeMismatch in Admin/productsController#save

Image expected, got Image

This has gotta be a bug in Rails.

What version of the product are you using? On what operating system?
1.0a2

What steps will reproduce the problem?
1.  Install patch. 
2.  Go to preferences, change your authorization type to 'authorize.net SIM' 
and 'store is in test 
mode'
3. go to authorize.net (login) and add 
http://hostname/authorize_net_sim/payment_received_notification_sub_step
as an authorized "relay url" (account->settings->relay response)
3.  Do a checkout with the off-site goodness.

It also adds a preference to make a difference between "normal user/pass with a 
test flag" and 
"test account" for authorize.net users explicit.

It requires a new gem ruby-hmac, to be installed, and a preference 
'store_use_test_cc_submission_urls' to be added.

It allows for authorize.net SIM to work, and has been reasonably, though not 
exhaustively tested 
(and works as expected).

It also makes it more clear to the customer that they will be directed off site.
It adds a helper function to the Preference model, as well.  Note that the code 
could be 
refactored to "look" more like the paypal IPN implementation, but I preferred 
to keep it all in its 
own controller rather than add it to the order model (keep it separate).


What version of the product are you using?
1.0a2

It might be possible to use the new preference to decide if users should use 
the paypal sandbox 
or not, but I haven't looked into it.

The module is not currently included (at least not in the tarball release).
 The search action will bomb without it.

Only one payment method is currently allowed as set by the admin, cc oro
paypal.  Maybe add separate login/pwd fields to preferences table and mock
the admin interface to allow both payment methods, but only one can be
chosen by customer?

What steps will reproduce the problem?
1. If you create an item and upload one picture to it.
2. Or you create an item and upload two pictures to it.
3.

What is the expected output? What do you see instead?
With one picture, it shows you a single small picture, that you can't click on.

I would expect you to be able to click on the single small picture. 

If there is more than one then I would expect the others to appear below it, 
clickable (just the 
others, not the original).
I would expect the main image to be larger.

What version of the product are you using? On what operating system?
TRUNK

Please provide any additional information below.

 Some or all of these may be helpful to someone.  Patch attached.

What steps will reproduce the problem?
1. Log in the administration view.
2. Access products and try to using the field at right to search something.

What is the expected output? What do you see instead?
Is expected a list with the results, but an exception is caught.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

NameError in Admin/productsController#search

uninitialized constant Admin::ProductsController::Paginator

RAILS_ROOT: /.../substruct_rel_1-0-a2_trunk
Application Trace | Framework Trace | Full Trace

vendor/rails/activesupport/lib/active_support/dependencies.rb:478:in
`const_missing'
vendor/plugins/substruct/app/controllers/admin/products_controller.rb:152:in
`search'
vendor/rails/actionpack/lib/action_controller/base.rb:1158:in `send'
...


FIX:

"include Pagination" is missing from Admin::ProductsController.

What steps will reproduce the problem?
1. Create an admin user an try to delete it.

What is the expected output? What do you see instead?
Nothing happens, you are just redirected to the list action. It should
delete the user, and it should not appear in the list. 

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
In the shell:
Processing UsersController#destroy (for 127.0.0.1 at 2008-03-12 12:57:45) [GET]
  Session ID: 364deb6d0c97f428c4644ac669a607b0
  Parameters: {"action"=>"destroy", "id"=>"541702177",
"controller"=>"admin/users"}
...
Redirected to http://localhost:3000/admin/users/list
Filter chain halted as
[#<ActionController::Filters::ClassMethods::ProcFilter:0xb68e58bc
@filter=#<Proc:0xb70163c0@/home/edmundo/workspace_aptana/substruct_trunk/vendor/
rails/actionpack/lib/action_controller/verification.rb:75>>]
rendered_or_redirected.
Completed in 0.06155 (16 reqs/sec) | DB: 0.01133 (18%) | 302 Found
[http://localhost/admin/users/destroy/541702177]
...

As shown above, its using GET in the destroy action and the filter chain
halts. The option in the link_to that defines that it should use POST is wrong.

Fixed a deprecated render partial command too.

Its the same problems as issues 21 and 22 but now in the sections controller.

Follows a patch. Again I'm not fixing the javascript behavior.

What is the expected output? What do you see instead?

Click Track an Order.  Login as a customer.  In the Your Orders table, the
order number changes from plain text to a link.  When clicked, it shows the
details of that order. 

I substituted all methods that does the highlight by just one, as nothing
is broken this is not a fix. I think this way its much more simpler to
understand, the functionality should be the same. It was changed directly
inside /vendor/plugins/substruct.

Follows a diff, my working copy is so messed with changes not committed
that its hard to separate issues that I filled to make a diff just with one :P

It needs that app/controllers/application.rb be this:

class ApplicationController < ActionController::Base
  include SubstructApplicationController  
  before_filter :set_navigation_tabs
  before_filter :find_customer
end

This change is out of the scope of the subversion repository.

What steps will reproduce the problem?
1. Set up for PayPal test mode
2. Place and pay for an order 
3. Click the link to return to merchant

What is the expected output? What do you see instead?
It tries to go to localhost:port/blah... instead of mydomain.com/blah

What version of the product are you using? On what operating system?
Substruct 1.0.a2, Ubuntu Feisty

Please provide any additional information below.
I set up Apache to proxy balance requests to mongrel instances running on
multiple ports on the same server.  I guess when Substruct makes the call
to PayPal, PayPal uses some HTTP header to determine the URL to go back to
merchant, and this happens to be set to localhost:port.

How can I override that to be mydomain.com ?

What steps will reproduce the problem?
1. Create a new product or associate a tag called "On Sale" with one.

What is the expected output? What do you see instead?
It should have an icon at the upper right corner showing that. But it don't
have.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

Follows a patch. The view isn't passing these informations to the helper,
and if was the product helper method that builds this chunk of code is
using a wrong path to the icon. 

Admin:FilesController attempes to sort by path (a nonexistent field) 
should be changed to filename

multiple controllers use render_text "" a deprecated method 
should be changed to render :text=>"" or something of the sort

What steps will reproduce the problem?
1. Create a functional test file for Admin::ProductsController.
2. Try to assert that it have a specified html tag. i.e:  assert_select
"div#errorExplanation" (Assert that it gave an error explanation)

What is the expected output? What do you see instead?
Is expected nothing but it prints:

ignoring attempt to close p with i
  opened at byte 12111, line 400
  closed at byte 12164, line 401
  attributes at open: {"class"=>"info"}
  text around open: " this product.\n</p>\n<p class=\"info\">\n\t(B"
  text around close: "bottom of this page)</i>\n</p>\n\n<!-- \n\tRE"

What version of the product are you using? On what operating system?
Checked out trunk. Ubuntu 7.04 

Please provide any additional information below.
Its just an initial <i> tag missed in
/vendor/plugins/substruct/app/views/admin/products/_crud_right.rhtml
...
(Button at the bottom of this page)</i>
...

What steps will reproduce the problem?
1. Access the admin interface.
2. Create a tag.
3. Edit it try to save it with an empty or duplicated name.

What is the expected output? What do you see instead?
Some kind of of error message. What happens is a popup message saying that
occurred a communication error with the server and the method crashes (only
in the console) lefting the edit box with its spining gif giving an idea
that it is doing something (of course it isnt, its just a animated picture) 

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

The console shows:

ActionController::DoubleRenderError (Can only render or redirect once per
action):
    /vendor/rails/actionpack/lib/action_controller/base.rb:833:in
`render_with_no_layout'
    /vendor/rails/actionpack/lib/action_controller/layout.rb:270:in
`render_without_benchmark'
    /vendor/rails/actionpack/lib/action_controller/benchmarking.rb:51:in
`render'
....

The method executed really have a double render problem:

def update
  ...
  if [email protected]
    render(:update) do |page| 
      ...
    end
  end
  render(:update) do |page| 
    ...
  end
end

If the tag is not saved render, then at the end render again. It should be:

def update
  ...
  if [email protected]
    render(:update) do |page| 
      ...
    end
  else
    render(:update) do |page| 
      ...
    end
  end
end

This fixes the error but not the behavior of the field that cannot be
clicked to be saved again.

What steps will reproduce the problem?
1. login as admin
2. click promotions
3. click new promotions

What is the expected output? What do you see instead?
Should be a page letting u add a new promotion??

What version of the product are you using? On what operating system?
1.0.a2 mac os x 10.5.2

Please provide any additional information below.

Version used: substruct_rel_0-97

The self referential has_and_belongs_to_many relationship of the product
class was given a name that don't permits it to take full advantage of the
automatically added methods to manipulate the collection of associated
objects. You can add but you cannot delete related products (now I see why
the SQL was created)

Changing
has_and_belongs_to_many :related_products
...
to
has_and_belongs_to_many :related
...

let you ged rid of that ugly SQL command:

def remove_return_relation(relative)
  sql  = "DELETE FROM related_products "
  sql << "WHERE product_id = #{relative.id} AND related_id = #{self.id}"
  ActiveRecord::Base.connection.execute(sql)
end

doing something like that:

def remove_return_relation(relative)
  relative.related.delete(self)
end

I don't know if you can maintain the same association name.

The app requires openssl to run properly.

Bootstrap task should check for this, and alert if it's not installed - just 
like the newly added gem 
test support.

What steps will reproduce the problem?
1. Access the administrative interface.
2. Choose a promotion that has being used and click in in the number of
orders associated with it (at right).
3. It shows a list of orders.
4. Click an order name/number.

What is the expected output? What do you see instead?
I should show the order. It points to a show action in the current
promotions controller (that doesn't exist).

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
Follows a patch, was forgotten to specify the correct controller in the view.

What steps will reproduce the problem?
1. Access site_http_address/questions/faq

What is the expected output? What do you see instead?
Its expected a nice output. A screen scrambled with the footer.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
Follows a patch is just a missing "clear" tag.

[deleted issue]

I have configured my Aptana environment to use SVN, now is easier to make
patches.

Here goes a patch to issues 14, 19, 20, 21, 22 and 23.

It fixes the error of issue 22 but not the behavior of the screen (its
using a lot of javascript and I will not fix the way it is).

It has something to do with issue 18 too, (deprecated methods), but I only
fixed what I already tested.

Regards.

What steps will reproduce the problem?
1. Try to save a store name with a ' in it

Could allow for sql injection

What steps will reproduce the problem?
1. Remove a shipping type.

What is the expected output? What do you see instead?
Nothing. An error is shown in the shell.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
Just a deprecated render command. I added a blank lines between each method
too.

What steps will reproduce the problem?
1. Create a test in a situation where the response will include a flash
notice and try to assert that it have a specified html tag.

What is the expected output? What do you see instead?
Is expected nothing. But a warning is printed.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
In main and admin layouts the flash message is defined as:

<% if flash[:notice] -%>
  <div id="flash">
    ...
    <p>
      <a href="#" class="button" style="width:80px;" onmousedown="new
Effect.BlindUp($('flash'))" />Close</a>
    </p>
  </div>
  ...
<% end -%>

The <a> tag is closed two times: <a ... /></a> it should be <a ... ></a>

Regards.

Apply this patch to integrate PayPal IPN support.

What steps will reproduce the problem?
1. Access the administration interface.
2. Erase a tag.

What is the expected output? What do you see instead?
A tag should be erased with no errors. A tag is erased and an error is
shown at the console.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

Console output:

NoMethodError (undefined method `render_text' for
#<Admin::TagsController:0xb6a45fb8>):

/vendor/plugins/substruct/app/controllers/admin/tags_controller.rb:77:in
`destroy'
    /vendor/rails/actionpack/lib/action_controller/base.rb:1158:in `send'
...


At tag_controller.rb:

def destroy
  @tag = Tag.find(params[:id])
  tag_id = @tag.id
  @tag.destroy
  # Render nothing to denote success
  render_text ""
end


Again another use of a deprecated method, should be render :text => "" instead.

What steps will reproduce the problem?
1. Pick one user and make several orders and let the billing and shipping
addresses the same.

What is the expected output? What do you see instead?
The result in administration view is the sum of
(number_of_orders_of_an_user_to_a_country *
number_of_total_orders_of_this_user). It should be only the sum of orders
sent to a country by any user.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.

The way it is it only works when you test with just one order per user.
Create one more and it will give wrong results.

The SQL is wrong, you dont need to join orders with users and then to
addresses, the order already have a foreign key to a shipping address where
you can discover the country.

Follows a patch.

What steps will reproduce the problem?
1. Click new promotion in the admin section

 Showing admin/promotions/new.rhtml where line #6 raised:

undefined method `start_form_tag' for #<ActionView::Base:0x36614f0>

Extracted source (around line #6):

3:  <ul class="navigation secondary">
4:     <li><a href="/admin/promotions/list/">Back to Promotion List</a></li>
5:   </ul>
6:  <%= start_form_tag :action => 'create' %>
7:      <%= render(:partial => 'form') %>
8: 
9:      <div class="line">&nbsp;</div>


Tired... I'll take a look at it tomorrow.

What steps will reproduce the problem?
1. Create a a tag and associate it with a parent tag (the parent tag must
have a lower id than the first)

What is the expected output? What do you see instead?
It should highlight the bar correctly. It shows a navigation bar with no
sub navigation bar and doesn't highlight it.

What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04

Please provide any additional information below.
Reading the TODO notes appears that the navigation bar is meant to be
refactored to be simpler. Anyway, I could NOT make this problem happen just
using the admin interface as it doesn't allow to specify ids, I'm having
problems with it with foxy fixtures only, but I'm filling this issue not
because of MY problem but because rails documentation states that when you
do this: Class.find([id1, id2, id3]) you CANNOT expect that these objects
will be returned in the order specified, its about how databases store rows.

Follows a patch ordering it by parent id, as you can have only two levels
and the first will always have a parent id of 0.

What steps will reproduce the problem?
1. enable and configure paypal IPN
2. run an order live mode/production environment or in test
mode/development environment
3. watch the email not be sent. 

What is the expected output? What do you see instead?

expected to get an email, got none, log messages included FAILED TO SEND
CONFIRMATION EMAIL

What version of the product are you using? On what operating system?

Substruct 1.0.a2 on CentOS5 with mongrel_cluster, lighttpd proxy balancing
and mysql.


Please provide any additional information below.

the first issue is with Order.cleanup_successful attempting to have
OrderAccount obscure a non-existent cc_number
the second is in the confirmation email template
app/views/orders_mailer/_order.rhtml where order_account.cc_number.length
is being called with a nil cc_number.

I'll be submitting a patch for this tomorrow.

What steps will reproduce the problem?
1. For products with a single uploaded image, no click to enlarge
2. Products with multiple images allow click to enlarge of the thumbnail
3.

What is the expected output? What do you see instead?
Would expect the click of sized image to give a enlarged image

What version of the product are you using? On what operating system?
Latest, linux 64bit

Please provide any additional information below.
Will provide a file with a fix later if needed

This is modification of how images a placed inside the submodal or their
own rounded box in the list to stay centered. It was made inside /app and
/public and the admin interface was not touched.

The size of small pictures was changed, to fit the rounded boxes of list
view, and if smaller they are centered (so, they don't appear cropped any
more). The submodal layout that shows the images was changed too to center
them.

The CSS is based on http://brunildo.org/test/img_center.html

Tested on Firefox 2.0.0.11 (Linux), IE 6.0 (Inside Wine) and Opera 9.25 (Linux)

Regards

What steps will reproduce the problem?
1. Go to http://localhost:3000/admin
2. Check development.log

This patch is mostly for usability, with some small code changes (mostly of 
setting the AM billing 
style after each preferences save, just in case).  It makes the preferences 
page more verbose 
(hopefully in a good way), and adds a method that would have helped me when I 
came across 
"Nil.is_true? is undefined" errors.
Thanks!
-Roger
This diff was taken from the substruct directory from what I believe is the 
latest TRUNK but it's hard 
to tell since it was a recent SVN export.

What steps will reproduce the problem?
1. Open the administration interface and having some products try to edit one.
2. Go to the "Related Products" fields at the right and try to start
filling with a name or code of another product.

What is the expected output? What do you see instead?
Should drop-down a list to choose a product, but nothing happens.

What version of the product are you using? On what operating system?
substruct_rel_0-97

The bootstrap task uses fixtures that lives on
/vendor/plugins/substruct/db/bootstrap

The file content_nodes_sections.yml is wrong, it contains content_nodes and
sections that doesn't exists and gives a weird behavior when starting to
use sections.

Suggestion: Take it out.

Here comes a test about refactoring code using the unit provided in th
earlier issue. It was made using substruct_rel_1-0-a2.

product.rb refactored.
* after_create callback was erased (not needed even for not yet saved
products).
* before_save was needed then, but was put in item.rb.
* Deprecated tags= in flavor of tag_ids= (a placeholder tag_id= was left in
  place for now to not create an infinite looping).
* Deprecated related_product_ids= if flavor of
related_product_suggestion_names= that is a more descriptive name its not
the same code it doesn't verify if the object is new or not, it appears to
not be needed.

item.rb refactored.
* before_save was put here, product and variation inherit from item and
needs it.
* suggestion_name is an instance method not a class method, added a new
comment box, (not very usefull).

variation.rb refactored.
* before_save was erased from here, its already in item.rb.
* erased commented method name=, it wasnt beeing used of course.


As you can see, controllers and views was not touched, and I could not make
it give any errors, so it should make what it meant for and don't break
anything.

It will issue warnings about the deprecated methods and it will be usefull
to change the views and controllers and see if something was forgotten.

Take a look at the code (I didn't made a patch, I am uploading the full models)

regards.

What steps will reproduce the problem?
1. Create a functional test file for Admin::ContentNodesController.
2. Try to assert that it have a specified html tag. i.e:  assert_select
"div#errorExplanation" (Assert that it gave an error explanation)

What is the expected output? What do you see instead?
Is expected nothing but it prints:

..ignoring attempt to close p with i
  opened at byte 10774, line 341
  closed at byte 10827, line 342
  attributes at open: {"class"=>"info"}
  text around open: "s time.</span>\n</p>\n<p class=\"info\">\n\t(B"
  text around close: "bottom of this page)</i>\n</p>\n\n<!--\n\tLAT"


What version of the product are you using? On what operating system?
trunk. Ubuntu 7.04 

Please provide any additional information below.
Its just an initial <i> tag missed in
/vendor/plugins/substruct/app/views/admin/content_nodes/_crud_sidebar.rhtml
...
(Button at the bottom of this page)</i>
...

What steps will reproduce the problem?
1. SETUP PAYPAL
2. uncheck 'test mode' in preferences
3. attempt to make an order


What is the expected output? What do you see instead?
 expected to be sent to the live paypal url, instead I was still sent to
the paypal sandbox site.

What version of the product are you using? On what operating system?
Substruct 1.0.a2 on CentOS5 with mongrel_cluster, lighttpd proxy balancing
and mysql.


Please provide any additional information below.

Restarting the cluster picked up the correct paypal url

What steps will reproduce the problem?
1. rake substruct:maintain


What is the expected output? What do you see instead?
expected to run to completion, actual output: 

Updating country order counts...
Updating product costs...
Removing crusty sessions...
rake aborted!
uninitialized constant SESSION_TIMEOUT


What version of the product are you using? On what operating system?
Substruct 1.0.a2 on CentOS5 with mongrel_cluster, lighttpd proxy balancing
and mysql.

Please provide any additional information below.

I'll attach a patch in the next couple days if this isn't fixed or claimed
before then.

Credit cards should be encrypted in the DB, and decrypted for display in the 
admin UI if necessary.

Use ezCrypto.

What steps will reproduce the problem?
1. Run rake substruct:db:bootstrap
2.
3.

What is the expected output? What do you see instead?
root@boba:/home/adam/substruct/substruct_app# rake substruct:db:bootstrap
--trace
(in /home/adam/substruct/substruct_app)
** Invoke substruct:db:bootstrap (first_time)
** Execute substruct:db:bootstrap
Initializing database...
rake aborted!
wrong number of arguments (1 for 0)
/home/adam/substruct/substruct_app/vendor/plugins/substruct/tasks/substruct.rake
:92:in
`execute'
/home/adam/substruct/substruct_app/vendor/plugins/substruct/tasks/substruct.rake
:92
/home/adam/substruct/substruct_app/vendor/plugins/substruct/tasks/substruct.rake
:87:in
`each'
/home/adam/substruct/substruct_app/vendor/plugins/substruct/tasks/substruct.rake
:87
/usr/lib/ruby/1.8/rake.rb:387:in `call'
/usr/lib/ruby/1.8/rake.rb:387:in `execute'
/usr/lib/ruby/1.8/rake.rb:387:in `each'
/usr/lib/ruby/1.8/rake.rb:387:in `execute'
/usr/lib/ruby/1.8/rake.rb:357:in `invoke'
/usr/lib/ruby/1.8/rake.rb:350:in `synchronize'
/usr/lib/ruby/1.8/rake.rb:350:in `invoke'
/usr/lib/ruby/1.8/rake.rb:1924:in `run'
/usr/lib/ruby/1.8/rake.rb:1924:in `each'
/usr/lib/ruby/1.8/rake.rb:1924:in `run'
/usr/bin/rake:4


What version of the product are you using? On what operating system?

Ubuntu 7.10 
substruct_rel_0-97

Please provide any additional information below.

Here goes some methods to help to deprecate things. (I borrowed from typo:
http://typosphere.org/)

Its very simple and will let make things like that:

#Defined to save tags from product edit view
def tags=(list)
  substruct_deprecated "Use tag_ids= instead."
  tags.clear
  for id in list
    tags << Tag.find(id) if !id.empty?
  end
end

# Defined to save tags from product edit view
def tag_ids=(list)
  tags.clear
  for id in list
    tags << Tag.find(id) if !id.empty?
  end
end


Or even better:

substruct_deprecate :tags= => :tag_ids=

# Defined to save tags from product edit view
def tag_ids=(list)
  tags.clear
  for id in list
    tags << Tag.find(id) if !id.empty?
  end
end

And the old method will be auto-generated with a warning at the beginning
and pointing to the new one.

Very clever.

It can be put at /lib in plugins and should be required wherever you think
is better.

Regards.

What steps will reproduce the problem?
1. Try to add or edit a promotion
2.
3.

What is the expected output? What do you see instead?
Error screen showing undefined method

What version of the product are you using? On what operating system?
Lalest, linux 64bit

Please provide any additional information below.
Delete 'start_' in the in the new and edit views and all is well, there was
no <% end_form_tag%> as you'd expect only </form> html, but it seems to be OK.

The FAQ portion of the site isn't referenced anywhere, I just included it
at the footer at the side of "Contact Us".