xtaran / cgi-github-webhook Goto Github PK

See http://matrix.cpantesters.org/?dist=CGI-Github-Webhook%200.04 for an overview of reports.

One problem seems to be that somewhere in the test suite it's assumed that the first perl in PATH is the same perl used for the test, which is not always the case. Typically this can be fixed by using $^X.

There seems to be another problem on freebsd systems --- tests fail even if the perl in PATH and the perl used for the test is the same.

0.05 now passes on my linux smokers, but still fails on the freebsd ones. Looking at the truss log while running t/cgi-test-auth-fail.t it seems that there's a race condition:

64932: 0.115133907 0.000014527 open("/dev/stdout",O_WRONLY|O_APPEND|O_CREAT,0666) = 3 (0x3)
...
64932: 0.115357399 0.000010057 open("/dev/stdout",O_WRONLY|O_APPEND|O_CREAT,0666) = 4 (0x4)
...
64932: 0.130372156 0.000086324 write(4,"Date: Fri Jul  1 23:09:19 2016\nRemote IP: localhost (127.0.0.1)\n$VAR1 = {\n          'payload' => 'none'\n        };\n$VAR2 = '<no-x-hub-signature>';\n$VAR3 = 'sha1=78f444a9b7282e9e1ae0f520044e8d9b52243ec9';\n",204) = 204 (0xcc)
...
64932: 0.130554861 0.000015365 write(3,"Authentication failed\n",22) = 22 (0x16)
...
64932: 0.134588335 0.000006146 write(1,"Content-Type: text/plain; charset=utf-8\r\n\r\nAuthentication failed\n",65) = 0 (0x0)

So the header gets written after the body. In fact, if log in t/cgi/cgitest.pl is set to /dev/stderr instead of /dev/stdout, then the test passes (although now the debugging output is visible in the test suite).