xslim / php-snmp Goto Github PK

What steps will reproduce the problem?
1. php SNMP.php
2. use PHP/4.3.11
3.

What is the expected output? What do you see instead?
back to prompt ( I think ) when it works properly.  I am currently
recieving this error:

PHP Parse error:  parse error, unexpected T_STRING, expecting
T_OLD_FUNCTION or T_FUNCTION or T_VAR or '}' in
/var/www/html/snmp_monitor/SNMP4.php on line 30

Line 30:
public static function trap($ip, $varBinds=null, $community='public')

Can this code not be used on this old of a version of PHP?

What version of the product are you using? On what operating system?
Centos 4

Please provide any additional information below.

What steps will reproduce the problem?
1. Calling SNMP::trap() is not working

What version of the product are you using? On what operating system?
Debian, Lenny

Please provide any additional information below.
Bugs in SNMP.php

Line: 80
$trap is not exists, should be $pSnmp

Line: 91
$trapPacket is not exists, should be $snmpPacket

Proposals:
All functions shoul be part od class.
SNMPTrap is better name for class.

Impreved hexlen:
    public static function hexlen( $s ) 
    {
        $len     = strlen( $s );
        $hexlen  = self::dec2hex( $len );
        $keyByte = ""; 

        if( $len > 127 ){
          $lenBytes = strlen( $hexlen ) / 2;
          $keyByte = self::dec2hex( 0x80 + $lenBytes );
        }

        return $keyByte . $hexlen;
    }