Git Product home page Git Product logo

bagsync's People

Contributors

actown avatar bluenightsky avatar dlargex avatar dpatti avatar enumaelis avatar h0tw1r3 avatar katypurry avatar mbattersby avatar mcavanagh avatar misatotremor avatar nanjuekaien1 avatar nevcairiel avatar silvertwist avatar wetu avatar xruptor avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

bagsync's Issues

cross-realm double count guildbank items

hi, ok, i try to explain it better here now..

you see on the picture attached, that the guild "Aletheia" is shown tiwce.. ..this is from the original server "Nethersturm" and it also shows the count of "Echteisenerz" ( witch means "True Iron Ore") from the cross-realm "Alexstrasza".. ..that means, it doubles the Summary ("Gesamt" in german)...

again: i have 1950 true iron ore in my guildbank from the guild "Aletheia".. ..i have several chars spread over the two realms nethersturm and alexstrasza.. ..and this happens, if i want so see the summary in the tooltip..

i hope you understand my issue now.. ..sorry, i am not a nativ speaker!

maby the problem is that you can have two guilds named the same on two cross-realms?

thank you very much.. ..bagsync always was and is my absolut favourit addon managing stuff.

regards,

zapp

bagsync screenshot

French translation

I just saw your message in frFR.lua about the translation.
I propose to complete it, if you need. I really like your addon and I'm using it everyday. Will maybe need some of your help to find the context, though.

Leaked Globals

The local variables on line 334 in BagSync.lua are being leaked into the global namespace and may potentially cause taint problems.

The "fix" is pretty simple; all you need to do is add local itemID, textureName, locked, recentDeposit, isFiltered anywhere before the for loop.

Bank not synced when exiting game

First off all, i love this addon!

Now for my issue, when i exit game and enter again, items which i have in my bag do not show how many i have inside the bank for some reason. But when i visit a bank to 'update' then it does show for the duration i am logged in, upon logout i lose that data for some reason. Guildbank and reagentbank do work fine and always show up even upon logging out. So the issue is only on the Bank.

Hope there is a way to fix this in the future! Keep up the good work.

FrameXML warnings.

I had a look through Logs/FrameXML.log file out of curiosity earlier and noticed this:

1/22 17:34:34.895  Loading add-on BagSync
1/22 17:34:34.895  Binding header BAGSYNC is defined more than once in Interface\AddOns\BagSync\Bindings.xml
1/22 17:34:34.895  Binding header BAGSYNC is defined more than once in Interface\AddOns\BagSync\Bindings.xml
1/22 17:34:34.895  Binding header BAGSYNC is defined more than once in Interface\AddOns\BagSync\Bindings.xml
1/22 17:34:34.895  Binding header BAGSYNC is defined more than once in Interface\AddOns\BagSync\Bindings.xml

The header="" attribute only needs to be set for the first binding in the file and WoW will automatically group the rest of the bindings under this header (unless a different header is used further down, in which case any further bindings will be grouped under this second header).

This is a very minor problem though. I can't see any other problems occurring because of this.

I'm just being picky I guess.

Scaling

I just installed this because of Bagnon not being updated and I'm having a little bit of trouble trying to scale the window if the option is there. I use Hexweave Bag's and the window takes up a good chunk of my screen space

Lua error when hovering over currency

Hey,

i get this error when hovering over a currency entry on the characters currency screen after updating to 10.2

2x BagSync\BagSync-v10.2.lua:903: attempt to index field '?' (a nil value)
BagSync\BagSync-v10.2.lua:903: in function `AddCurrencyTooltip'
BagSync\BagSync-v10.2.lua:1256: in function <BagSync\BagSync.lua:1252>
[C]: in function `SetCurrencyToken'
[string "*:OnEnter"]:2: in function <[string "*:OnEnter"]:1>

Missing Libraries

Your .zip files published on CurseForge/Curse doesn't include the external libs.

Error when Caging Battle Pets

Greetings!

Mists of Pandaria lunched last night (yay!) and I've been clearing out duplicate battle pets from my journal.

When caging a pet, I get the following error:

10x BagSync\BagSync-v6.7.4.lua:257: attempt to perform arithmetic on local "first" (a nil value)
BagSync\BagSync-v6.7.4.lua:257: in function <BagSync\BagSync.lua:250>
BagSync\BagSync-v6.7.4.lua:288: in function <BagSync\BagSync.lua:277>
BagSync\BagSync-v6.7.4.lua:372: in function <BagSync\BagSync.lua:340>
BagSync\BagSync-v6.7.4.lua:1303: in function "?"
BagSync\BagSync-v6.7.4.lua:88: in function <BagSync\BagSync.lua:86>

Locals:
bagname = "bag"
bagid = 0
slot = 4
index = "bag:0:4"
texture = "INTERFACE\ICONS\INV_GIZMO_06.BLP"
count = 1
GetTag = <func> @..\BagSync.lua:242
lastItem = nil
lastDisplayed = <table> {}
ToShortLink = <func> @..\BagSync.lua:250
}

The caged pet does go into my bags as it should but BagSync can't find it. The same error pops up on login with a caged battle pet in your bags.

Help!

Caged Battle Pet issues

The first issue is that caged battle pets ("Pet Cages") are only being recorded in guild banks and not personal banks or equipped bags.

The second issue is that caged battle pets are searchable as "Pet Cage" and not what pet is in them. So you can can see how many caged pets there are but not search on the particular caged pet you are looking for.

Profession Links

Blizzard deliberately changed profession links in Patch 5.4 to prevent players and addons from using them on different characters.

Unfortunately, this has broken BagSync's profession link feature. The links do nothing when they are clicked on in the chatframe and my advice is to remove or disable the feature for the time being.

lua error: BagSync\BagSync-v8.7.lua:1128: bad argument #1 to 'pairs' (table expected, got no value)

A lua error occurs when I login and enter game world, with latest BagSync 8.7

lua error detail:

3x BagSync\BagSync-v8.7.lua:1128: bad argument #1 to 'pairs' (table expected, got no value)
[C]: in function pairs' BagSync\BagSync-v8.7.lua:1128: in function?'
BagSync\BagSync-v8.7.lua:94: in function <BagSync\BagSync.lua:92>

Locals:
(*temporary) = "table expected, got no value"
= defined =[C]:-1

Other info:
server region: Chinese
game ver: 7.0.3
character: a lv.100 paladin

Feature Request - Add item level to "equal" comparison

I would like the item level of an item to be considered before determining that two items are "equal" when comparing. If I have the 725 version of a trinket and a 731 version drops, I would like to know that I don't have the 731 trinket.

Can't pick up character data

As of 8.3 the addon can't pick up data from any of my characters. It is still working and I can still search items/gold/etc but it doesn't show any of my characters' data.

Not Syncing across Bnet Account

Hey there, love the addon and its exactly what I'm looking for but one feature doesn't seem to work.

I have two wow accounts under same battle.net. I have Bagsync on both and enabled "Display Battle.net Account Characters" on both as such:
wow_2018-12-27_19-48-59

However, it does not show item count from other account, only its own.

Is there something I'm missing?

Feature Request: Track Merged Realms

I have a set of alts crossed across 2 realms that got merged so essential the same realm.
However I can only view info if i log onto a alt on that half of the realm

Is it possible to have it so can recognise the realm is merged by have -Emerald Dream or -Terenas at the end of the chars name for example

Maybe make it optional so people can turn off that function if they only play on one realm even if its merged

uniqeid stripped from litem link when using ToShortLink

was the removal of the uniqueid from the itemstring intentional or accidental; in the comparison you omitted "g ==h" which would have included the uniqueid. as a side note the itemstrings now apparently also include a reforged field...

cheers

Feature Request: Indicator for characters not in same faction

It would be nice to have optional indicator for all characters which are not in the same faction as current character.

Perhaps just word 'Alliance'/'Horde' shown after character name, before possible XR/BNet indicator.

Other idea would be to color character name according to faction (but this only works if class colors are not used).

Lua Error search module

7x ...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:521: attempt to call global 'GetNumEquipmentSets' (a nil value)
...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:521: in function <...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0.lua:520>
...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:565: in function findItem' ...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:196: in function UseTypedSearch'
...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:183: in function <...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0.lua:149>
(tail call): ?
...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:102: in function FindIntersectSearch' ...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0-2.lua:91: in function <...libs\LibItemSearchGrid-1.0\LibItemSearchGrid-1.0.lua:88> (tail call): ? BagSync\modules\search-Поиск.lua:189: in function DoSearch'
BagSync\modules\search-Поиск.lua:30: in function <BagSync\modules\search.lua:28>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[3]"]:9: in function <[string "safecall Dispatcher[3]"]:5>
(tail call): ?
BagSync\libs\AceGUI-3.0\AceGUI-3.0-36.lua:314: in function `Fire'
...ync\libs\AceGUI-3.0-36\widgets\AceGUIWidget-EditBox.lua:74: in function <...ync\libs\AceGUI-3.0\widgets\AceGUIWidget-EditBox.lua:71>
...ync\libs\AceGUI-3.0-36\widgets\AceGUIWidget-EditBox.lua:118: in function <...ync\libs\AceGUI-3.0\widgets\AceGUIWidget-EditBox.lua:115>

Locals:
nil

BagSync\modules\search-Search.lua:7: Cannot find a library instance of "CustomSearch-1.0"

just got this message when logged my char 1st time after upgrade from previous version

1x BagSync\modules\search-Search.lua:7: Cannot find a library instance of "CustomSearch-1.0".
[C]: in function error' GatherMate2\Libs\LibStub\LibStub.lua:23: in functionLibStub'
BagSync\modules\search-Search.lua:7: in main chunk

Locals:
(*temporary) = "Cannot find a library instance of "CustomSearch-1.0"."

Lua errors in 8.3

Since 8.3 an error is thrown on login/reload because the event AUCTION_OWNED_LIST_UPDATE doesn't exist any more.

And if you open the auction house another error is thrown because the method GetNumAuctionItems doesn't exist any more. I assume there are some more auction house related new errors since everything changed there.

BagSync attempted to call a protected function (<unnamed>:Hide()) during combat lockdown.

Date: 2016-08-11 13:04:09
ID: 2
Error occured in: AddOn: BagSync
Count: 2
Message: Note: AddOn BagSync attempted to call a protected function (:Hide()) during combat lockdown.
Debug:

..\FrameXML\WorldMapActionButton.lua:58: Clear()
..\FrameXML\WorldMapActionButton.lua:67: Refresh()
..\FrameXML\WorldMapActionButton.lua:19: SetMapAreaID()
..\FrameXML\WorldMapFrame.lua:390:
..\FrameXML\WorldMapFrame.lua:353

..\FrameXML\UIParent.lua:2320: SetUIPanel()
..\FrameXML\UIParent.lua:2347: MoveUIPanel()
..\FrameXML\UIParent.lua:2378: HideUIPanel()
..\FrameXML\UIParent.lua:2052:
..\FrameXML\UIParent.lua:2044

..\FrameXML\UIParent.lua:2846: HideUIPanel()
..\FrameXML\UIParent.lua:2812: ToggleFrame()
..\FrameXML\WorldMapFrame.lua:219: ToggleWorldMap()

  [string "TOGGLEWORLDMAP"]:1

Locals:
None
AddOns:
Swatter, v5.21f.5579 (SanctimoniousSwamprat)
WowheadLooter, v60014
Accountant, v6.02.60200
ACP, v3.4.28
AFKfullscreen, v2.0-Release
AutoVendor, v31
BadBoy, v13.025
BadBoyCCleaner, v
BadBoyGuilded, v
BagSync, v9.1
Bazooka, vv2.7.1
BazookaOptions, vv2.7.1
BetterTooltips, vv2.3.1
Blitz, v6.0
BlitzOptions, v
BrokerEverything, v2.16-Release8
ClassIcons, v7.2
DBMArchaeology, v
DBMCore, v
DBMDefaultSkin, v
DBMLDB, v
DBMSpellTimers, v
DBMStatusBarTimers, v
DBMVoA, v
DebugLib, v5.1.DEV.337(/embedded)
ExplorerCoords, v1.5.2
FactionAddict, v1.34
HandyNotes, vv1.4.8
HandyNotesDirections, v1
HandyNotesEverShiftingMirror, v1.0.1
HandyNotesHigherLearning, v6.2.0.4
HandyNotesLostAndFound, v1
HandyNotesTreasureHunter, v1
HandyNotesWellRead, v6.1.0.4
HandyNotesWorldMapButton, v2.4
ImprovedOptionsFrames, v1.5.5
InspectorGadgetzan, v7.0.3.7
InstanceProfits, v
LagBar, v3.5
LeatrixPlus, v7.0.48
LibExtraTip, v5.12.DEV.390(/embedded)
LibSharedMedia30, v3.0-93
MasterPlanA, vA
MikScrollingBattleText, v5.7.146
MinimapButtonFrame, v3.1.10e
MinimapButtonFrameSkinPack, v3.0.1b
mOnArsWardrobeHelper, v1.13.9
Overachiever, v0.84
OverachieverTabs, v0.84
PassLoot, v4.3
Pawn, v2.0.7
Postal, vv3.5.8
Prat30, v3.6.14
Prat30Libraries, v
RaresTip, vr10
SavedInstances, v7.0.1
SignOn, vv2.4.2
SilverDragon, vv3.2.5
SimpleGold, v5.5.0
SlashHelp, v4.2
Stubby, v5.21f.5579 (SanctimoniousSwamprat)
TipTac, v16.07.23
TomTom, vv70000-1.0.0
TradeSkillInfo, vv2.3.11
TradeSkillInfoUI, vv2.3.11
TradeSkillMaster, vv3.4.29
TradeSkillMasterAccounting, vv3.0.16
TradeSkillMasterAppHelper, vv3.0.1
TradeSkillMasterAuctionDB, vv3.1.12
TradeSkillMasterAuctioning, vv3.0.12
TradeSkillMasterMailing, vv3.0.11
WoWTokenWatch, v1.0.3
XToLevel, v7.0.3_46
BlizRuntimeLib_enUS v7.0.3.70000
(ck=773)

Feature Request: Show guild bank gold

It would be nice to show guild bank gold for private guilds where gold is all mine.

It would be nice to also have option to select which guild banks are included and which excluded.

CrossRealm not always showing

As requested here is a copy of my BagSync.lua.

Characters on Bronze Dragonflight see counts from Nordrassil.

Nordrassil characters do not see counts from Bronze Dragonflight
BagSync.zip

Lua Error

Getting this error after update 10.6, addon no longer works for me.

Message: Interface\AddOns\BagSync\BagSync.lua:1079: bad argument #1 to 'sort' (table expected, got nil) Time: 10/26/16 16:33:40 Count: 6 Stack: [C]: in functionsort'
Interface\AddOns\BagSync\BagSync.lua:1079: in function `AddItemToTooltip'
Interface\AddOns\BagSync\BagSync.lua:1180: in function <Interface\AddOns\BagSync\BagSync.lua:1174>

C: in function SetBagItem' Interface\FrameXML\ContainerFrame.lua:1149: in functionContainerFrameItemButton_OnEnter'
[string ":OnEnter"]:1: in function <[string ":OnEnter"]:1>

Locals: (_temporary) = nil
(_temporary) = defined @interface\AddOns\BagSync\BagSync.lua:1079
(*temporary) = "table expected, got nil"
`

Lua Error

This addon seems abandonned but since the release of 8.0.1 i Have a lua Error :

Message: Binding header BAGSYNC is defined more than once in Interface\AddOns\BagSync\Bindings.xml Time: Wed Jul 18 13:15:07 2018 Count: 10

thank you

Class colors not working in currency tab

Instead, they use "Primary BagSync tooltip color", eventhough "Display class colors for characters" is enabled. Tested with BagSync 10.1, no other AddOns enabled.

Please come back!

I love this minimalistic add-on.
Everything else with the feature is overblown with crap I don't need...
Now with Classic out, the situation got even worse.

Please @Xruptor return!

Connect Realms support

It would be good to be able to see what you have on all realms that are part of a connected realm instead of just the realm you are currently on.

When updating BagSync to add Connected Realm support remember that someone may have characters on more than one set of connected realms.

Bfa update?

Was this addon updated for bfa?I can only tellt hat gold module is working ,but profession and currency module arent.I am doing something wrong or this was updated?

Right click for menu not working

Hello, as of patch 7.3, right-clicking the minimap icon no longer brings up the menu. Thanks for making a great add-on, bagsync is my fave!!

When trying to use Might of Dalaran I get this error message about 132 times

Date: 2017-02-16 06:22:12
ID: 5
Error occured in: AddOn: BagSync
Count: 3
Message: Note: AddOn BagSync attempted to call a protected function (:Hide()) during combat lockdown.
Debug:
[C]: Hide()
..\FrameXML\WorldMapActionButton.lua:58: Clear()
..\FrameXML\WorldMapActionButton.lua:67: Refresh()
..\FrameXML\WorldMapActionButton.lua:19: SetMapAreaID()
..\FrameXML\WorldMapFrame.lua:1230: WorldMapFrame_Update()
..\FrameXML\WorldMapFrame.lua:2809: WorldMapFrame_UpdateMap()
..\FrameXML\WorldMapFrame.lua:436:
..\FrameXML\WorldMapFrame.lua:422
[C]: ?
[C]: SetMapToCurrentZone()
..\FrameXML\WorldMapFrame.lua:370:
..\FrameXML\WorldMapFrame.lua:349
[C]: Show()
..\FrameXML\UIParent.lua:2327: SetUIPanel()
..\FrameXML\UIParent.lua:2166: ShowUIPanel()
..\FrameXML\UIParent.lua:2086:
..\FrameXML\UIParent.lua:2082
[C]: SetAttribute()
..\FrameXML\UIParent.lua:2868: ShowUIPanel()
..\FrameXML\UIParent.lua:2852: ToggleFrame()
..\FrameXML\WorldMapFrame.lua:261:
..\FrameXML\WorldMapFrame.lua:233
[C]: ToggleWorldMap()
[string "TOGGLEWORLDMAP"]:1:
[string "TOGGLEWORLDMAP"]:1
Locals:
None
AddOns:
Swatter, v7.3a.5701 (TasmanianThylacine)
AucAdvanced, v7.3a.5701 (TasmanianThylacine)
AucFilterBasic, v7.3a.5701 (TasmanianThylacine)
AucFilterOutlier, v7.3a.5701.5459(7.3a/embedded)
AucMatchUndercut, v7.3a.5701.5585(7.3a/embedded)
AucScanData, v7.3a.5701 (TasmanianThylacine)
AucStatHistogram, v7.3a.5701 (TasmanianThylacine)
AucStatiLevel, v7.3a.5701 (TasmanianThylacine)
AucStatPurchased, v7.3a.5701 (TasmanianThylacine)
AucStatSales, v7.3a.5701.5598(7.3a/embedded)
AucStatSimple, v7.3a.5701 (TasmanianThylacine)
AucStatStdDev, v7.3a.5701 (TasmanianThylacine)
AucStatWOWEcon, v7.3a.5701.5613(7.3a/embedded)
AucUtilAHWindowControl, v7.3a.5701.5575(7.3a/embedded)
AucUtilAppraiser, v7.3a.5701.5666(7.3a/embedded)
AucUtilAskPrice, v7.3a.5701.5599(7.3a/embedded)
AucUtilAutoMagic, v7.3a.5701.5686(7.3a/embedded)
AucUtilCompactUI, v7.3a.5701.5694(7.3a/embedded)
AucUtilEasyBuyout, v7.3a.5701.5576(7.3a/embedded)
AucUtilFixAH, v7.3a.5701 (TasmanianThylacine)
AucUtilItemSuggest, v7.3a.5701.5651(7.3a/embedded)
AucUtilPriceLevel, v7.3a.5701.5633(7.3a/embedded)
AucUtilScanButton, v7.3a.5701.5631(7.3a/embedded)
AucUtilScanFinish, v7.3a.5701.5588(7.3a/embedded)
AucUtilScanProgress, v7.3a.5701.4979(7.3a/embedded)
AucUtilScanStart, v7.3a.5701.5347(7.3a/embedded)
AucUtilSearchUI, v7.3a.5701.5672(7.3a/embedded)
AucUtilSimpleAuction, v7.3a.5701.5654(7.3a/embedded)
AucUtilVendMarkup, v7.3a.5701.4828(7.3a/embedded)
Babylonian, v5.1.DEV.332(/embedded)
BagSync, v10.9
BattlePetBreedID, vr134
BeanCounter, v7.3a.5701 (TasmanianThylacine)
BloodTrader, v2.1.1
Configator, v5.1.DEV.406(/embedded)
DBMCore, v7.1.13
DBMDefaultSkin, v
DBMStatusBarTimers, v
DebugLib, v5.1.DEV.337(/embedded)
Enchantrix, v7.3a.5701 (TasmanianThylacine)
EnchantrixBarker, v7.3a.5701 (TasmanianThylacine)
HandyNotes, vv1.4.11
HandyNotesDraenorTreasures, v1.20a
HandyNotesLegionTreasures, v1
HandyNotesSuramarLeylines, v1
HandyNotesSuramarTelemancy, v1
HealBot, v7.1.0.1
HealBotTips, v7.1.0.1
Informant, v7.3a.5701 (TasmanianThylacine)
LibExtraTip, v5.12.DEV.423(/embedded)
LiteBag, v7.1.5
Skada, v1.6.5
SlideBar, v7.3a.5701 (TasmanianThylacine)
Stubby, v7.3a.5701 (TasmanianThylacine)
TipHelper, v5.12.DEV.405(/embedded)
TomTom, vv70100-1.0.0
WorldQuestTracker, v
BlizRuntimeLib_enUS v7.1.5.70100
(ck=951)

Please add better Mail tracking.

When you send items through in game mail to a character that BagSync already knows about, it should keep track of the items and list it as in Mail in tooltips and such.

Add Ability to Blacklist a Guild

It would be nice if we had the ability to blacklist certain guilds. I only want to include my storage guild bank and not my actual guild's bank.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.