un-trapped `getWindowAttributes` fail crashes xmonad, possibly after failed window drag about xmonad HOT 7 CLOSED

My suspicion is that the drag was never completed and crashes when the window goes away. Do we check for this?

from xmonad.

(The ones that are caught don't include an executable name; they just print the exception as is.)

I don't think that this is true. I can reproduce the spam of

user error (Error in function getWindowAttributes)

once the window goes away, but can't reproduce the crash at all. Indeed, making the following change

diff --git a/src/XMonad/Core.hs b/src/XMonad/Core.hs
index 631f847..0c6b5a5 100644
--- a/src/XMonad/Core.hs
+++ b/src/XMonad/Core.hs
@@ -196,7 +196,7 @@ catchX job errcase = do
     c <- ask
     (a, s') <- io $ runX c st job `E.catch` \e -> case fromException e of
                         Just (_ :: ExitCode) -> throw e
-                        _ -> do hPrint stderr e; runX c st errcase
+                        _ -> do hPrint stderr ("CAUGHT: " <> show e); runX c st errcase
     put s'
     return a

and going over the recipe again correctly prints

"CAUGHT: user error (Error in function getWindowAttributes)"

to stderr. These exceptions seem to be correctly caught inside of some userCode call.

from xmonad.

Isn't that what I said about the usual ones? The point is that somewhere there's an uncaught one. I'll probably need to do a profiling build and a reproducer to spot the one that leaked.

from xmonad.

Oh sorry, my brain must have s/executable name/function name/'d

from xmonad.

Can you consistently reproduce this with the above setup? If yes, and you think it's really the dragging, perhaps try adding an explicit userCodeDef to the dragging code

diff --git a/src/XMonad/Operations.hs b/src/XMonad/Operations.hs
index 9101cc0..7ff44df 100644
--- a/src/XMonad/Operations.hs
+++ b/src/XMonad/Operations.hs
@@ -783,9 +783,7 @@ mouseDragCursor cursorGlyph f done = do
         withDisplay $ io . flip ungrabPointer currentTime
         modify $ \s -> s { dragging = Nothing }
         done
-    motion x y = do z <- f x y
-                    clearEvents pointerMotionMask
-                    return z
+    motion x y = userCodeDef () (f x y) >>= \z -> z <$ clearEvents pointerMotionMask
 
 -- | Drag the window under the cursor with the mouse while it is dragged.
 mouseMoveWindow :: Window -> X ()

from xmonad.

I can't reproduce it now for some reason: I get the mis-sized window, but it drags for both move and resize fine. I wonder what went wrong the first time.

from xmonad.

Curiously, I arranged for a dialog to disappear on xmonad during a drag and can't reproduce even that way. (The original circumstances I am assuming are due to some weirdness in my setup that I can't reliably reproduce and seems to be tied to something completely unrelated, so I haven't bothered to report it.)

Closing for now.

from xmonad.