Sub Document Canonicalization about libxml-ruby HOT 6 CLOSED

Hi CITguy,

Are you asking to add a nodes parameter to the canonicalize method? I'm ok with that, but then it should just be rewritten to support all the parameters. From Libxml docs (http://xmlsoft.org/html/libxml-c14n.html#xmlC14NDocDumpMemory):

nodes: the nodes set to be included in the canonized image or NULL if all document nodes should be included
mode: the c14n mode (see @xmlC14NMode)
inclusive_ns_prefixes: the list of inclusive namespace prefixes ended with a NULL or NULL if there is no inclusive namespaces (only for exclusive canonicalization, ignored otherwise)
with_comments: include comments in the result (!=0) or not (==0)

With so many parameters, I'm thinking the method takes an optional hash:

doc.canonicalize(:nodes => nil,
:mode => XML_C14N_1_1,
:ns_prefixes => nil,
:with_comments => false)

What do you think? Could you put together a patch and some test cases?

Charlie

from libxml-ruby.

I can put something together. I'm using this as an excuse to learn C, so I cannot guarantee anything soon. I like the idea of passing an optional hash (of course having the values defaulted to current values). I'll let you know more as I progress.

from libxml-ruby.

I've got the C code done (I think). I'll be writing up tests in the next day or two.

from libxml-ruby.

See #37

from libxml-ruby.

Thanks for the patch - will look at this weekend.

Charlie

from libxml-ruby.

Looks great..applied and closing.

from libxml-ruby.