xlanor / cryptokitties Goto Github PK

Since you are inserting raw text in raw statements, a user can exploit your bot with an SQL injection.

Sanitize your SQL statements - use prepared statements and the ? placeholder to insert user input - and additionally validate the input before inserting it.

Instead of getting the output as print it's recommended to use the Python logging

The lines highlighted could be turned into:

except Exception:
   log.exception("Error creating database")

Moving the code from the root directory and into a subdir, and then adding a setup.py file that describes this.

http://python-packaging.readthedocs.io/en/latest/minimal.html

• move code (one commit, make sure that the commit doesn't alter code at the same time)
• Add setup.py and an endpoint
• update your service file to call the endpoint

For GitHub, Travis CI is the recommended

Set up a basic CI pipeline that:

• installs the application with pip install .

This is the "Hello World" verion of a CI system, but requires you to read up a bit on getting the basics running.
A minimal Travis setup looks like:

  language: python
  python:
    - 3.6
    - nightly
  script:
    - pip install -r requirements.txt
    - pip install .

A few of these nested loops are pretty nastily deep, and the inner layers would benefit from being split out into separate functions.

There's no need to have a multiline code block in the middle of a statement, move it to the beginning of the file and give it a name, calling that instead.

The python requirements should be in a requirements.txt that pip can read and install.

d4046c6 fixed the badly commited files, but not the root cause.

Add a .gitignore and make sure pycache files won't end up commited again.