Git Product home page Git Product logo

react-universal-saga's Introduction

react-universal-saga's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

react-universal-saga's Issues

In this configuration sagas cannot take router events

For example saga will not get '@@router/LOCATION_CHANGE' event on initial loading, because 'store.runSaga(rootSaga);' happens after history is configured.

It must be smth like that:

const store   = configureStore(initialState, browserHistory)
store.runSaga(rootSaga, store.dispatch)

const history = syncHistoryWithStore(browserHistory, store)
const routes  = createRoutes(store)

Postcss adds class suffix to imported css files

Hello,

I've imported a css file from a node module (react-activity) and Postcss or style-loader, or some other processor adds ___[chars] to classes and they do not match the classes added by the module.

Any idea on how to prevent that? I've added another loader that should fix the issue(according to an issue on Postcss) but it does not
loaders: [ { test: /(node_modules)(\/.*css$)/, loader: 'style!css?sourceMap!postcss' },

As of importing it, i'm importing in App.scss file like this @import '../../../node_modules/react-activity/dist/react-activity.css';

Thank you,
Mihai

Large bundle size

First of, Thanks for sharing this repo with the community.

I noticed that the client bundle size is rather large, about 780kb after minification. any idea on how to bring it down a bit?

I managed to cut it down to around 500 by removing "react-bootstrap" (which i won't probably be using) ,and changing Lodash imports from
import _ from 'lodash';
to
import zip from 'lodash/zip'

The bundle still seems a bit large, do you have any recommendation on how to trim it down to a more reasonable size?

Immutable

How to apply Immutable for reducers?

Currently having this error message

"The previous state received by the reducer has unexpected type of "Object". Expected argument to be an object"

Replace webpack-isomorphic-tools with isomorphic-webpack

Hello @xkawi 👋 ,

I am the author of isomorphic-webpack. isomorphic-webpack is an abstraction used to re-use JavaScript code between server and client. Its been quietly maturing in garage for a few months now and we are using it in production on 2 sites.

However, the Rule of Three states that this project is not mature to be "advertised" as ready for production before at least 3 different projects implement it.

I'd like to work with you to re-implement react-universal-saga using isomorphic-webpack. Hopefully, it will reduce the amount of boilerplate code and make the example itself easier to understand. Along the way I'd like to hear your ideas for improvement and suggestions for documentation.

Have you got time to catch up on Skype/ Slack/ IRC/ ... ?

Question: Remove Bootstrap

Hey xkawi,

thanks for taking the time to update the react-redux-universal-hot-example. It looks very good so far but I wanna get rid of bootstrap completely and only use sass. Could you help me with that and point me to all the locations in the code?

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.