Git Product home page Git Product logo

2023-10-aloe's Introduction

Aloe contest details

Q&A

Q: On what chains are the smart contracts going to be deployed?

mainnet, Arbitrum, Optimism, Base


Q: Which ERC20 tokens do you expect will interact with the smart contracts?

Any standard token, including USDT


Q: Which ERC721 tokens do you expect will interact with the smart contracts?

None


Q: Which ERC777 tokens do you expect will interact with the smart contracts?

None


Q: Are there any FEE-ON-TRANSFER tokens interacting with the smart contracts?

No, fee-on-transfer tokens are not supported.


Q: Are there any REBASING tokens interacting with the smart contracts?

No, rebasing tokens are not supported.


Q: Are the admins of the protocols your contracts integrate with (if any) TRUSTED or RESTRICTED?

Restricted. The protocol should be able to handle any changes enacted by Uniswap Governance (i.e., new fee tiers or changes to the protocol fee).


Q: Is the admin/owner of the protocol/contracts TRUSTED or RESTRICTED?

Restricted. The governor address should not be able to steal funds or prevent users from withdrawing. It does have access to the govern methods in Factory, and it could trigger liquidations by increasing nSigma. We consider this an acceptable risk, and the governor itself will have a timelock.


Q: Are there any additional protocol roles? If yes, please explain in detail:

There is a RESERVE address, to which a portion of all interest accrues. It should be able to take any action and behave normally.

We also have a built-in referral program. If you enroll as a "courier" and attach the courier ID to your users' deposits, you will receive a portion of their interest. Couriers can take any action in the protocol except claiming rewards.

Also, if a courier credits another courier for their deposit, 100% of the first couriers earnings will be passed through to the other one. This edge case should not break anything or impact any other users.


Q: Is the code/contract expected to comply with any EIPs? Are there specific assumptions around adhering to those EIPs that Watsons should be aware of?

The Lender complies with ERC4626 and EIP2612. Notes on our 4626 implementation are available here: https://coda.io/d/_dJtHvRlIBOx/Standard-Compliance_su6Wx


Q: Please list any known issues/acceptable risks that should not result in a valid finding.

After a Borrower has been warned, but before it's liquidated, there's an opportunity to make it healthy and avoid liquidation. If this is done via a call to Borrower.modify, the warning will be cleared, and further interactions are normal. However, if it's done by a 3rd-party via Lender.repay (with the borrower set as the beneficiary), the warning will not be cleared.


Q: Please provide links to previous audits (if any).

https://drive.google.com/file/d/1aWEkCTTcuEnupf6nbIsqWy38igsj9-Hx/view?usp=sharing


Q: Are there any off-chain mechanisms or off-chain procedures for the protocol (keeper bots, input validation expectations, etc)?

We expect interested parties to watch Borrowers and call warn/liquidate when possible. Same goes for the emergency pause method in Factory, and the update function in the VolatilityOracle.


Q: In case of external protocol integrations, are the risks of external contracts pausing or executing an emergency withdrawal acceptable? If not, Watsons will submit issues related to these situations that can harm your protocol's functionality.

Uniswap cannot be paused.


Q: Do you expect to use any of the following tokens with non-standard behaviour with the smart contracts?

We use solmate's SafeTransferLib, so the protocol should work with tokens that are missing return values.


Q: Add links to relevant protocol resources

https://docs.aloe.capital/aloe-ii/overview https://docs.aloe.capital/aloe-ii/auditor-quick-start https://aloelabs.github.io/aloe-ii/index.html


Audit scope

aloe-ii @ c71e7b0cfdec830b1f054486dfe9d58ce407c7a4

2023-10-aloe's People

Contributors

sherlock-admin avatar rcstanciu avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.