xianlubird / rog-go Goto Github PK

What steps will reproduce the problem?

1. Create a struct type containing a pointer to another type
2. Define the other type somewhere
3. Attempt to use godef to find the definition for the type referenced to by 
the pointer

What is the expected output? What do you see instead?

I expect for `godef` to find the type, but it just finds the pointer.


What version of the product are you using? On what operating system?

Using the latest version of godef on OSX Mavericks.

The issue was confirmed here on GitHub: 
https://github.com/fatih/vim-go/issues/110#issuecomment-48149847

The 'acme' package on which this depends has moved from code.google.com to 
9fans.net

It does not know that internal _test.go files can export their
own identifiers to be used by other external tests.

godef optimistically assumes that it can deduce the package
identifier from the import path. This is often, but not
always the case. It should actually import the package
in question, although this will slow things down a little bit.

old location no longer works

Patch for source packages change in Go 1.4.1.
Check for new and old location.

What steps will reproduce the problem?
1. Enable bash completion for go ( misc/bash/go)
2. Type go get [TAB]

What is the expected output? What do you see instead?
No errors

What version of the product are you using? On what operating system?
go: 1.1.1, rog-go: tip

Please provide any additional information below.
Got an error output:
can't load package: package code.google.com/p/rog-go/exp/abc/audio: 
rog-go/exp/abc/audio/output.go:1:1: expected 'package', found 'import'
rog-go/exp/abc/audio/output.go:2:2: invalid package name _

Per http://codereview.appspot.com/1686048, freetype-go has renamed Fixed and 
Fixed64 to Fix32 and Fix64 (respectively).

Replacing all occurrences of raster.Fixed to raster.Fix32 resolves the issue.

What steps will reproduce the problem?
1.  install go 1.4 with homebrew or compile it from source code
2.  set the $GOROOT and locate it with the new install go soruce,
3.  write a go file with code which call with std function, such as 
`json.Marshal()`
4.  trigger godef at the cursor on json.Marshal()

It should jump to the source code in GOROOT, 
but actually it does nothing.

Vsersion Info:  go version go1.4 darwin/amd64

I believe the cause is the go source code change its directory architecture, 
there are no more  $GOROOT/src/pkg.
Change the code at 
https://code.google.com/p/rog-go/source/browse/exp/cmd/godef/godef.go#49
from

            gopath = append(gopath, r+"/src/pkg")

to

    gopath = append(gopath, r+"/src")

could easy solve the problem.

What steps will reproduce the problem?
1. cd %GOPATH%\src\code.google.com\p\rog-go\exp\filemarshal
2. go test

What is the expected output? What do you see instead?
tests passes

Sometimes the test passes and sometimes it fails with a few different errors.

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
PASS
ok      code.google.com/p/rog-go/exp/filemarshal        0.125s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.01 seconds)
        filemarshal_test.go:177: json: mismatchedReceiver: decode failed:json: cannot unmarshal number into Go value of type filemarshal.X2
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.125s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
PASS
ok      code.google.com/p/rog-go/exp/filemarshal        0.146s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.01 seconds)
        filemarshal_test.go:177: json: noFiles: decode failed:json: cannot unmarshal object into Go value of type int
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.209s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
PASS
ok      code.google.com/p/rog-go/exp/filemarshal        0.126s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.01 seconds)
        filemarshal_test.go:177: gob: noFiles: decode failed:gob: decoding into local type *int, received remote type One = struct { S string; F File = struct {
 Name string; }; }
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.192s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
PASS
ok      code.google.com/p/rog-go/exp/filemarshal        0.169s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
PASS
ok      code.google.com/p/rog-go/exp/filemarshal        0.126s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.00 seconds)
        filemarshal_test.go:177: gob: oneFile: decode failed:gob: type mismatch: no fields matched compiling decoder for One
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.124s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.01 seconds)
        filemarshal_test.go:177: gob: noFiles: decode failed:gob: decoding into local type *int, received remote type One = struct { S string; F File = struct {
 Name string; }; }
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.112s

d:\Dev\go\gopath\src\code.google.com\p\rog-go\exp\filemarshal>go test
--- FAIL: TestEncodeDecode (0.00 seconds)
        filemarshal_test.go:177: gob: largeFile: decode failed:gob: type mismatch in decoder: want struct type filemarshal.File; got non-struct
FAIL
exit status 1
FAIL    code.google.com/p/rog-go/exp/filemarshal        0.118s


What version of the product are you using? On what operating system?
changeset:   154:b2e2eb7b9a8f
go version go1.3.1 windows/amd64
Windows 7 64-bit

Please provide any additional information below.

From our IRC conversation.

Attached is the requested .Xauthority file

Would it be possible to ignore hidden files when parsing packages? Emacs 
creates hidden symbolic links with names like `.#foo.go` for modified files. 
This seems to trip up godef, meaning it won't be able to find any declarations 
for expressions.

My guess is that it parses both foo.go and .#foo.go and then fails because of 
duplicate function names, among others.

What steps will reproduce the problem?
1. go get code.google.com/p/rog-go/exp/cmd/godef

What is the expected output? What do you see instead?

package code.google.com/p/goplan9/plan9/acme
    imports code.google.com/p/goplan9/plan9/acme
    imports code.google.com/p/goplan9/plan9/acme: cannot find package "code.google.com/p/goplan9/plan9/acme" in any of:
    /Users/neilc/local/go/src/code.google.com/p/goplan9/plan9/acme (from $GOROOT)
    /Users/neilc/sweng/oms/src/code.google.com/p/goplan9/plan9/acme (from $GOPATH)

Please provide any additional information below.

goplan9 has moved to https://github.com/9fans/go

in Go 1.4, there is a change blow:
In the main Go source repository, the source code for the packages was kept in 
the directory src/pkg, which made sense but differed from other repositories, 
including the Go subrepositories. In Go 1.4, the pkg level of the source tree 
is now gone, so for example the fmt package's source, once kept in directory 
src/pkg/fmt, now lives one level higher in src/fmt.

so, godef can not find right place in 1.4.

~/O/tools ❯❯❯ uname -a
Darwin mbp.local 14.1.1 Darwin Kernel Version 14.1.1: Thu Feb 26 22:41:49 PST 
2015; root:xnu-2782.15.5~1/RELEASE_X86_64 x86_64
~/O/tools ❯❯❯ go get code.google.com/p/rog-go/exp/cmd/godef
package 9fans.net/go/acme: unrecognized import path "9fans.net/go/acme"