Git Product home page Git Product logo

Comments (18)

Reemtsman avatar Reemtsman commented on July 20, 2024

i can confirmt the problem described above. I had hundreds of "Kung Fu Hustles" entries in my library after the last update.
I just started a own issue report as i did not realize the same problem is already reported here. Sorry for the duplication!

from audiodecoder.sacd.

dabl2 avatar dabl2 commented on July 20, 2024

For what it's worth the good news is I found that simply running a kodi library clean operation gets rid of the bogus movie entries created by the plugin being active when running a scan against a target containing .iso files.

from audiodecoder.sacd.

Reemtsman avatar Reemtsman commented on July 20, 2024

@dabl2 dabl2! From my experience the workaround suggested by you only works when the SACD Iso Support Add-on is De-Installed or at least Deactivated an the time of the Cleanup.
Therefore more a Workaround, not a solution. But still thank you for posting!!

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

Suggestion: Maybe re-name all the sacd ISOs to be filename.iso.sacd and then have this plugin look for .sacd files?

from audiodecoder.sacd.

Reemtsman avatar Reemtsman commented on July 20, 2024

Thank you @BenMcLean !
Unfortunately this Plugin has no setting to define what type of extension to look for.

from audiodecoder.sacd.

dabl2 avatar dabl2 commented on July 20, 2024

Thank you @BenMcLean !
Unfortunately this Plugin has no setting to define what type of extension to look for.

But I think Ben is suggesting that maybe it could

If of course some developer saw fit to consider this idea.

If I understand Ben correctly, that idea does come with a cost though.

Asking the user to rename all their files which otherwise might then become useless to other apps is perhaps after further thought, maybe not ideal.

I still like the idea of allowing the user to 'aim' the app at one or more folders to pay attention to/act upon.

IE I think most people have their SACD .ISOs in a folder seperate from their Movie .ISOs so this should work fine for most people.

I'd be happy at this point just to see this issue even acknowledged.

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

Yes that was a feature suggestion for the developer, not a workaround.

Personally, I haven't managed to get this plugin to work at all. :(

I install it but it seems to have no effect

from audiodecoder.sacd.

Reemtsman avatar Reemtsman commented on July 20, 2024

...sorry for my misunderstanding!
But i agree with Don that the file extension is not the smartest approach to trigger the correction. I would suggest to trigger this through the source path. I would bet that 99% of all users have their SACD Isos not in the same path like the video Isos anyhow.
Just let the user enter his SACD Source Path into the Add-on and make the addon only work for the Isos found under this predefined SACD path.

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

No way. My collection is organized by artist, not by format. Don't do that path crap.

from audiodecoder.sacd.

Reemtsman avatar Reemtsman commented on July 20, 2024

...your SACD Iso´s lay under Artists...
So what?? This means they are located in your music library wich is by design a different source (with a different path) than your movies and TV Shows (with Video Isos). So triggering the behaviou of this Add-on through the source patz is definitely smarter than renaming all SACD.Iso´s

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

No, all formats are together in the same artist folder. Like the Jeff Wayne folder has all the Jeff Wayne SACDs and all the Jeff Wayne DVD ISOs.

from audiodecoder.sacd.

dabl2 avatar dabl2 commented on July 20, 2024

In theory a developer could implement support for either/both options.

from audiodecoder.sacd.

Reemtsman avatar Reemtsman commented on July 20, 2024

The challenhe here will be to make sure this Add-on exclusively effects SACD Iso´s without effecting Video-Iso´s. As lond as this is acchieved - without renaming all my SACD Iso´s - i will be happy.

from audiodecoder.sacd.

AlwinEsch avatar AlwinEsch commented on July 20, 2024

About the problem becomes here a half fix added #35

Add the option and related code changes so that ISO's can also have ".sacd" as an extension.

However, I want to leave ".iso" in there because more is correct and available than such. In addition, the error is in Kodi and must be looked at to fix it.

But you can now edit the addon.xml by hand and remove the text with ".iso".
https://github.com/AlwinEsch/audiodecoder.sacd/blob/Matrix-change/audiodecoder.sacd/addon.xml.in#L11

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

Thank you.

the error is in Kodi and must be looked at to fix it.

Is there a Github issue made for that which I can subscribe to?

from audiodecoder.sacd.

AlwinEsch avatar AlwinEsch commented on July 20, 2024

Unfortunately none at the moment, as far as I know.

from audiodecoder.sacd.

BenMcLean avatar BenMcLean commented on July 20, 2024

Unfortunately none at the moment, as far as I know.

OK ... can somebody who knows more about the innards of Kodi than I do write it?

I could write it but I'd probably say the wrong thing

from audiodecoder.sacd.

AlwinEsch avatar AlwinEsch commented on July 20, 2024

Have created here a fix request xbmc/xbmc#20205.

Hope it can be become in on Nexus and also on Matrix version.

from audiodecoder.sacd.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.