xadhoom / detectino-core Goto Github PK

Provide events lists to check what happened when the user is away

• add a db-backed event list
• provide the need of ack for alarm events
• add information on who started the action, if applicable (ex: who armed the system?)
• display not ack'ed (alarm) events on the gui
• auto delete older (and ack'ed) events ?

What to do when some scenario is run but some partition cannot be armed? just abort the entire transaction? Run what works and ignore the rest?

may be related to #16

Right now if arming is done on a tripped detector, the arm operation is refused.
[error] Not all sensors are idle, cannot arm! is seen in the logs.

Find a better way to handle it or at least better report to the user.

....to allow connection from different IPs/hostnames

see :check_origin @https://hexdocs.pm/phoenix/Phoenix.Endpoint.html

Maybe we should add a couple of options to a sensor to allow:

• exclude the sensor if is tripped during arming

• exclude the sensor if is tripped during arming but automatically include it when goes idle

Add missing fields like balance type, thresholds, internal and so on.
See :sensor table and respective model for reference.

• exit timer must not be reset after expiration time, except after disarm
• exit timer must be cancelled and reset if disarmed while timer running
• entry timer must be cancelled if disarmed while timer running
• entry timer should be reset on a new alarm event: every new alarm event should respect the entry timer
• if an entry/exit timer is running, any other alarm event should be queued untile timer expiry

Check when a fix is released upstream

See: https://forum.primefaces.org/viewtopic.php?f=45&t=52045

this may happen when a partially armed partition has an internal sensor associated.
events from it may be ignored safely, since we don't care.

When arming is refused (because of tripped sensors), an 403 http error is returned.
gui should display a better error message.

When the server responds with http errors, the gui reports the javascript backtrace that's no useful at all.
leave only the http error, like "Error: 403 - Forbidden" and nothing more.

AUTO type sensor (discovered ones) when receive events will trigger a decode error.
this is just a warning, maybe we can mute it in order to not pollute logs

Error: (FunctionClauseError) no function clause matching in DtCore.Monitor.Partition.arm/3

Request: POST /api/scenarios/1/run
** (exit) exited in: GenServer.call(#PID<0.2184.0>, {:disarm, "matteo"}, 5000)
** (EXIT) an exception was raised:
** (FunctionClauseError) no function clause matching in DtCore.Monitor.DetectorFsm.handle_event/4
(detectino) lib/dt_core/monitor/detector_fsm.ex:53: DtCore.Monitor.DetectorFsm.handle_event({:call, {#PID<0.2168.0>, #Reference<0.1264155481.2744123395.229176>}}, :disarm, :realtime, %{config: %DtCtx.Monitoring.Sensor{meta: #Ecto.Schema.Metadata<:loaded, "sensors">, address: "1", balance: "DEOL", enabled: true, entry_delay: true, exit_delay: true, full24h: false, id: 9, inserted_at: ~N[2017-09-03 18:20:00.372432], internal: true, name: "Sala Primo Piano", partitions: #Ecto.Association.NotLoaded, port: 1, tamp24h: false, th1: 400, th2: 490, th3: 550, th4: nil, updated_at: ~N[2017-09-06 20:14:31.441939]}, entry_timeout: 0, last_event: %DtCore.DetectorEv{address: "1", id: "5pcs3hsfacrakucl5ji9tfk66lm5j3qe", port: 1, type: :realtime}, receiver: #PID<0.2168.0>})
(stdlib) gen_statem.erl:1242: :gen_statem.call_state_function/5
(stdlib) gen_statem.erl:1012: :gen_statem.loop_event/6
(stdlib) proc_lib.erl:247: :proc_lib.init_p_do_apply/3
2017-10-18 07:39:39.903 pid=<0.23557.2> [error] GenServer :sensors_controller terminating

when arming partitions with delayed sensors we need to:

• provide an exit timer event
• push the exit timer event to the gui via channels
• show different icon status to mimic arming progress
• add a bell on the web gui to notify that arming is undergoing, maybe using web audio apis

Caveats: right now if we are different partitions with same sensors they may have different exit delays, we must find a way to deal with it.