wurfl / magento-imageengine-extension Goto Github PK

In addition to the current client hints, I'd like these to be added:

		'sec-ch-ect',
		'sec-ch-ua-full-version',
		'sec-ch-ua-full-version-list',
		'sec-ch-ua-platform-version',
		'sec-ch-ua-arch',
		'sec-ch-ua-wow64',
		'sec-ch-ua-bitness',
		'sec-ch-ua-model'

Acceptance criteria:

The hints must be reflected in both the accept-ch header and permissions-policy header.

See

The name of the headers is updated in the spec.

Values in the accept-ch header should be:

• sec-ch-dpr
• sec-ch-width
• sec-ch-viewport-width

(ect should be removed)

Values in Permissions-Policy header should correspond to the values in the accept-ch header:

• ch-dpr
• ch-width
• ch-viewport-width

(remove ch-ect and ch-downlink)

Acceptance criteria:
Request headers sec-ch-dpr sec-ch-width sec-ch-viewport-width are present in requests sent to the imageengine address provided in the permissions policy header

Any plans to support PHP 8.2?

use composer require scientiamobile/module-magento2-image-cdn-imageengine
instead
composer install scientiamobile/module-magento2-image-cdn-imageengine

Versions in composer.json

SUMMARY:
As a customer I am updating my Magento sites to 2.4.7 and PHP 8.3, but ImageEngine extension for Magento 2 does not support PHP 8.3.

The latest release of ImageEngine extension for Magento 2, version 1.0.26, does not list PHP 8.3 as supported:
scientiamobile/module-magento2-image-cdn-imageengine - Packagist

Magento added PHP 8.3 support starting with release 2.4.7:
System requirements | Adobe Commerce
Magento Open Source 2.4.7 release notes | Adobe Commerce

Verify that the module works on newer PHP versions.

The composer instruction is correct, but the Magento name of the module is not the same. This is the line that is failing for me:

magento module:enable scientiamobile/module-magento2-image-cdn-imageengine

That gives the error Unknown module(s): 'scientiamobile/module-magento2-image-cdn-imageengine'

It looks like the composer packagist string got used instead of the module vendor/name. Looking in registration.php, I can see that the Magento module name is ScientiaMobile_IO. Also, as the previous command was designed to be run from the top-level, it's common to run magento from there too, making the correct line:

./bin/magento module:enable ScientiaMobile_IO

Though this line is commonly skipped as just running ./bin/magento setup:upgrade will enable the module and also install it. Without any data or schema instructions, this is not required, but in case you later have this it's good to include in the instructions.