wreis / dbix-class-encodedcolumn Goto Github PK

t/author/timestamp_order.t fails if DBIx::Class::TimeStamp is not installed:

...
{UNKNOWN}: Can't locate DBIx/Class/TimeStamp.pm in @INC (you may need to install the DBIx::Class::TimeStamp module) (@INC contains: ...
 .) at /home/cpansand/.cpan/build/2019091705/Class-C3-Componentised-1.001002-0/blib/lib/Class/C3/Componentised.pm line 146.
 at /usr/local/lib/perl5/5.30/base.pm line 137.
Compilation failed in require at /usr/local/lib/perl5/5.30/base.pm line 137.
	...propagated at /usr/local/lib/perl5/5.30/base.pm line 159.
BEGIN failed--compilation aborted at /home/cpansand/.cpan/build/2019091705/DBIx-Class-EncodedColumn-0.00018-0/t/author/../lib/DigestTest/Schema/WithTimeStampChild.pm line 6.
Compilation failed in require at /home/cpansand/.cpan/build/2019091705/Class-C3-Componentised-1.001002-0/blib/lib/Class/C3/Componentised.pm line 146. at /home/cpansand/.cpan/build/2019091705/Class-C3-Componentised-1.001002-0/blib/lib/Class/C3/Componentised.pm line 151
t/author/timestamp_order.t .. 
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run 
...

Observed in version 0.00019 and earlier.
Author tests should not run during normal user installs.

t/author-pod-syntax.t skips if AUTHOR_TESTING is not set but t/author/*.t do not.

hi.
I usually using result_base_class for prevent loading components multiple times.

package App::Schema::Parent;
use Moose;
use MooseX::NonMoose;
use namespace::autoclean;

extends 'DBIx::Class::Core';

__PACKAGE__->load_components(qw/
    InflateColumn::DateTime
    TimeStamp
    EncodedColumn
/);

__PACKAGE__->meta->make_immutable;

1;

above, EncodedColumn is display after TimeStamp.

if derived class extends this class, EncodedColumn is not working.
here is my test file. https://dl.dropboxusercontent.com/u/16719710/tmp/oops.tar.gz
execute for just type perl test.pl

if switching EncodedColumn and TimeStamp position,
it works.

I don't know this issue associate with this modules.
maybe this is more associate with DBIx::Class core.

thanks.

Algorithms that are considered safe to use now may not be considered safe in the future. Or one often has legacy code using an algorithm that is no longer considered safe to use.

It would be nice if this could be configured to handle multiple encoding types, to allow upgrading or changing an algorithm.

The hashed password would have an optional prefix, e.g. "blowfish:fa846084d81c4cf52a5421ad351d63efe495". The encoding configuration could be a hash where the keys are the names of the coding types (with a default assumed when hashing a new password).

The configuration could be something like

__PACKAGE__->add_columns(
  'password' => {
    data_type => 'CHAR',
    size      => 22,
    encode => {
      "md5" => {
         encode_column => 1,
         encode_class  => 'Digest',
         encode_args   => {algorithm => 'MD5', format => 'base64'},
         encode_check_method => 'check_password',
         no_key => 1, # assume this if there is no prefix
      },
     "blowfish" => {
         encode_column => 1,
         encode_class  => 'Crypt::Eksblowfish::Bcrypt',
         encode_args   => { key_nul => 0, cost => 8 },
         encode_check_method => 'check_password',
         default => 1, # use this as the default algorithm
    }
}

On my Strawberry Perl 5.12.3, Crypt::Random is installed but Math::Pari is not, and /t/open_pgp.t fails until Math::Pari is installed.

Crypt::OpenPGP uses Crypt::Random; Crypt::Random does not require Math::Pari, except when you ask Crypt::Random to do things it needs Math::Pari to do.

EncodedColumn performs the operation when the value is set, or on new

For set you have example, but there is no for new.

.cpan/build/DBIx-Class-EncodedColumn-0 513 > perl Makefile.PL 
Can't call method "load_all_extensions" on an undefined value at inc/Module/Install.pm line 206.
BEGIN failed--compilation aborted at Makefile.PL line 5.
 my @exts = @{$self->{extensions}};
 unless ( @exts ) {
  @exts = $self->{admin}->load_all_extensions; # <---- HERE
 }

The comment on IRC was it's a busted release, including a bunch of stuff it shouldn't
I tested it because it (indirectly) depends on Text::CSV_XS. I'll from now on exclude it from my test list until it is fixed.

t/crypt.t is using Test::Exception, but it's not listed in Makefile.PL or META.yml

t/crypt.t ................. Can't locate Test/Exception.pm in @INC