wp-media / heartbeat-control Goto Github PK

A quick search after seeing the error below shows that you are running an outdated version of CMB2. In this case version 2.6.0 from January 2019. CMB2 2.8 fixes the error being thrown in this plugin when running PHP >= 8.x: #1396.

PHP Deprecated:  Required parameter $field_id follows optional parameter $type in 
/usr/.../plugins/heartbeat-control/vendor/cmb2/cmb2/includes/rest-api/CMB2_REST.php on line 693

You are calling the get_plugins() function immediately on your plugin load, it is recommended to call this on the 'after_setup_theme' hook or later.

The issue is that the function caches the result of the function call on its first call, hence any plugin or theme using its filters will be unsuccessful as the data is already cached by your early call, rendering the filters useless.

Please fix this issue.

Since 2.0, this PHP warning can be triggered during the migration process:

Warning: Invalid argument supplied for foreach() in ../heartbeat-control.php on line 129

Before submitting an issue please check that you’ve completed the following steps:

• Made sure you’re on the latest version
• Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
We are experiencing the following PHP errors on this specific version:

• [14-Aug-2023 09:04:14 UTC] PHP Warning: Undefined variable $old_location in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/heartbeat-control.php on line 77
• [14-Aug-2023 09:04:14 UTC] PHP Warning: Undefined array key "heartbeat_control_location" in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/heartbeat-control.php on line 129
• [14-Aug-2023 09:04:14 UTC] PHP Warning: foreach() argument must be of type array|object, null given in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/heartbeat-control.php on line 129
• [14-Aug-2023 09:04:15 UTC] PHP Deprecated: Optional parameter $type declared before required parameter $field_id is implicitly treated as a required parameter in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/vendor/cmb2/cmb2/includes/rest-api/CMB2_REST.php on line 693
• [14-Aug-2023 09:05:16 UTC] PHP Deprecated: Optional parameter $args declared before required parameter $i is implicitly treated as a required parameter in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/vendor/cmb2/cmb2/includes/types/CMB2_Type_Multi_Base.php on line 34
• [14-Aug-2023 09:05:48 UTC] PHP Warning: Undefined array key "2x" in /var/www/rocketlabsqa.ovh/htdocs/wp-content/plugins/heartbeat-control/Plugin_Card_Helper.php on line 244

To Reproduce
Steps to reproduce the behavior:

1. Use PHP8.2 and WordPress 6.3
2. Install and activate Heartbeat Control plugin
3. Go to the Heartbeat Control settings
4. Change each of the settings to: Allow Heartbeat, Disable Heartbeat, Modify Heartbeat. Save settings after each change
5. Check the PHP log

Expected behavior
No PHP warnings in the logs, plugin working correctly on the previous PHP/WordPress versions:

1. Disable HeartBeat will disable this feature on specific parts of the website
2. Allow HeartBeat will not limit this feature on specific parts of the website
3. Modify HeartBeat will limit this feature to chosen frequency on specific parts of the website
4. To validate the HeartBeat behaviour, open network tab on specific part of the website and observe the frequency of the following request
   

Describe the solution you'd like
We've moved our security reporting to Patchstack, thus we need to update our readme + security reporting :

In the Readme :

== Frequently Asked Questions ==  

= Where do I report security bugs found in this plugin? =  
  
You can report any security bugs found in the source code of the site-reviews plugin through the [Patchstack Vulnerability Disclosure Program](https://patchstack.com/database/vdp/heartbeat-control). The Patchstack team will assist you with verification, CVE assignment and take care of notifying the developers of this plugin.
---  

In the Security.md (file need to be created in Github)

# Security Policy  
  
## Reporting Security Bugs  
  
Please report security bugs found in the site-reviews plugin's source code through the [Patchstack Vulnerability Disclosure Program](https://patchstack.com/database/vdp/heartbeat-control). The Patchstack team will assist you with verification, CVE assignment and take care of notifying the developers of this plugin.
---