Given the following command:

wp rewrite structure /%year%/%monthnum%/%postname%/

the output is:

Success: Rewrite rules flushed.
Success: Rewrite structure set.

One would expect that the new rewrite structure gets set before the rewrite rules are flushed (which does happen), but the confirmation message suggests the opposite.

Is there a way that this confirmation message can be improved?

After wp-cli/wp-cli#3986 lands, we should revert ccc591c

The following changes need to be made to move the command over to the v2 structure:

• Make sure the correct framework is required:

  composer require wp-cli/wp-cli:^2
  

• Require the testing framework as a dev dependency:

  composer require --dev wp-cli/wp-cli-tests:^0
  

• Use the .travis.yml file from wp-cli/wp-cli:

  wget https://raw.githubusercontent.com/wp-cli/wp-cli/master/.travis.yml
  

• Add the default script configuration to Composer file:

    "scripts": {
        "lint": "run-linter-tests",
        "phpcs": "run-phpcs-tests",
        "phpunit": "run-php-unit-tests",
        "behat": "run-behat-tests",
        "prepare-tests": "install-package-tests",
        "test": [
            "@lint",
            "@phpcs",
            "@phpunit",
            "@behat"
        ]
    },
  

• Remove scaffolded binary files:

  git rm bin/install-package-tests.sh
  git rm bin/test.sh
  

• Remove scaffolded Behat setup:

  git rm features/bootstrap/*
  git rm features/extra/*
  git rm features/steps/*
  

• Remove scaffolded Behat tags util script:

  git rm utils/behat-tags.php
  

• Add command packages that are needed for Behat tests as --dev dependencies.
  The following commands are already available, anything else needs to be explicitly required:
  • cli *
  • config *
  • core *
  • eval
  • eval-file
  • help
• Update all dependencies:

  composer update
  

• Optional - Add PHPCS rule set to enable CS & compatibility sniffing:

  wget https://raw.githubusercontent.com/wp-cli/wp-cli/master/phpcs.xml.dist
  

• Run and adapt tests to make sure they all pass:

  composer test
  

Currently it is not possible to flush the rewrite rules or to be able to use the --hard flag in multisites. Include a flag to be able to use --network.

Example
wp rewrite flush --network

Right now flush --hard returns success, but it actually fails if there is no .htaccess file.

flush --hard should create .htaccess if it does not exist

Could it be that wp rewrite list --match=<url> does not accept absolute URLs?

I am not that great in English. Could we rephrase <url> to show that it accepts only URL path + query string?

Bug Report

Describe the current, buggy behavior
Running wp rewrite flush from the wordpress:cli docker image in CircleCI gives me the following error:

PHP Parse error:  syntax error, unexpected ',' in phar:///usr/local/bin/wp/vendor/wp-cli/wp-cli/php/WP_CLI/Runner.php(1198) : eval()'d code on line 88
Exited with code 255

Other wp cli commands work fine.

Describe how other contributors can replicate this bug

Not suure. Run wordpress base docker image and wp:cli image in a circle ci job.

Describe what you would expect as the correct outcome

Expected command returns Success: Rewrite rules flushed.

Let us know what environment you are running this on
CircleCi running the following docker image with wp cli:

FROM wordpress:cli

USER root

ENV PHP_INI_MEMORY_LIMIT 1024M
RUN echo 'memory_limit = ${PHP_INI_MEMORY_LIMIT}' > "$PHP_INI_DIR/php.ini"

RUN apk update && apk upgrade && \
    apk add --no-cache bash git openssh

USER www-data

(Paste the output of "wp cli info" into this box)

^@^@OS:	Linux 4.10.0-35-generic #39~16.04.1-Ubuntu SMP Wed Sep 13 09:02:42 UTC 2017 x86_64
Shell:	
PHP binary:	/usr/local/bin/php
PHP version:	7.3.9
php.ini used:	/usr/local/etc/php/php.ini
WP-CLI root dir:	phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:	phar://wp-cli.phar/vendor
WP_CLI phar path:	/var/www/html
WP-CLI packages dir:	
WP-CLI global config:	
WP-CLI project config:	
WP-CLI version:	2.3.0

Hi 👋 ,

I was wondering why the additional config wp-cli.yml or config.yml is necessary? Can't this be passed as an argument? It feels cumbersome to add this config file to all our repos.

apache_modules:
  - mod_rewrite

Would you welcome a PR? Thanks in advance 🙏 .

Improve command description in:
https://github.com/wp-cli/rewrite-command/blob/master/src/Rewrite_Command.php
Command: wp rewrite
Current description: Manage rewrite rules.

Proposed description:
Lists or flushes the site's rewrite rules, updates the permalink structure.

See the WordPress Rewrite API and WP Rewrite class reference.

Currently, it is not possible to be able to add missing rules related to multisite when running the command since it only supports single sites.

An example command would be.
wp rewrite flush --hard --network

Feature Request

• Yes, I reviewed the contribution guidelines.

Describe your use case and the problem you are facing

I have been reviewing the code of the wp rewrite structure command and have run into unused $new_assoc_args variable , which looks like a residuum after past code updates:

The variable was introduced in 3be1d98 where \WP_CLI::launch_wpcli was used for launching the flush command.

But it was later changed to WP_CLI::runcommand ( in bf6c7c0 ) which does not accept the assoc args param, and the --hard flag is being appended to the $cmd.

Keeping the $new_assoc_args variable in place makes the code less readable.

Describe the solution you'd like

Removing the $new_assoc_args variable definition and the only other usage in the code, as the variable is never really used:

I'm happy to open a pull request, if we agree that this issue is valid.

Is there a a way to add a rewrite rule with wp-cli?

The following changes need to be made:

1. In the .travis.yml file, the - composer behat line in the script: section needs to be changed into the following:

- composer behat || composer behat-rerun

2. In the composer-json file, the requirement on wp-cli/wp-cli-tests needs to be adapted to require at least v2.0.7:

"wp-cli/wp-cli-tests": "^2.0.7"

3. In the composer-json file, the "scripts" section needs to be extended. Immediately after the line "behat": "run-behat-tests",, the following line needs to be inserted:

"behat-rerun": "rerun-behat-tests",

Here's an example of how this should look like:

We have a new PHPCS standard for WP-CLI called WPCliCS (props @jrfnl). It is part of the wp-cli/wp-cli-tests package starting with version v2.1.0.

To adopt & enforce this new standard, the following actions need to be taken for this repository:

• Create a PR that adds a custom ruleset phpcs.xml.dist to the repository

  • Add phpcs.xml.dist file
  • Adapt .distignore to ignore phpcs.xml.dist & phpunit.xml.dist
  • Adapt .gitignore to ignore phpunit.xml, phpcs.xml & .phpcs.xml
  • Require version ^2.1 of the wp-cli/wp-cli-tests as a dev dependency

• Make any required changes to the code that fail the checks from the above ruleset in separate PRs

• Merge thre ruleset once all required changes have been processed and merged

A sample PR for a simple repository can be seen here: https://github.com/wp-cli/maintenance-mode-command/pull/3/files

Related wp-cli/wp-cli#5179