wosc / schlund-ddns Goto Github PK

FIXME: Please don't take password from cmd line arg (ps/ proc/ history vulnerability).
better: ~/.schlund-ddns with config && parse args for rest / adjustments.

Also: small typo in readme. Should probably be "schlund-ddns --help" instead of "ddns-update --help" under Usage section.

Sorry for not providing a pull request, i've looked at a quick fix for passing PASS via config file but this uses gocept.logging.ArgumentParser() that I'm not familiar with.

Thanks for the handy schlund-ddns updater!

hi,
thanks for your great work!

Since i have 2fa activated i am not able to use schlund-ddns anymore.
Please add support for 2fa.

Some python library's already available, eg:
https://github.com/pyauth/pyotp

thanks in advanced,
timm

Problem:

host and domain are split at first occurence of splt_char in update.py resulting in a wrong zone domain for sub-levelled subdomains (e.g. a.b.example.tld is split in "a","b.example.tld", therefore an error is raised because of zone not found).

proposed quick fix:

$ diff /usr/local/lib/python3.7/site-packages/ws/ddns/update.py ./update.py 
60c60,62
<         host, domain = hostname.split('.', 1)
---
>         tmp = hostname.split('.')
>         domain = '.'.join(tmp[2:])
>         host = hostname.replace('.'+domain,'')

there will be a cleaner fix for this I guess, which is why i don't submit a pull request.

Again, thank you for creating the great package!