Comments (1)
Parent not found -> FAILED_PRECONDITION
More clearly, the internal services shouldn't make a distinction about what's a "parent". This is something the public services do because they have a defined resource hierarchy where a resource's name may include a parent.
The distinction that internal services need to make is based upon whether the problem is that the entity being acted upon couldn't be found, vs. whether some other entity couldn't be found.
There's arguments both ways re: whether to use FAILED_PRECONDITION
or NOT_FOUND
from internal services when a "parent" entity isn't found. The main point is that internal services need to provide their callers with enough information to accurately return their own correct Status.
some resource other than parent or self not found -> INVALID_ARGUMENT
I think this should be FAILED_PRECONDITION. As per Status codes and their use in gRPC, INVALID_ARGUMENT is for when the arguments are incorrect regardless of the state of the system (e.g. some field is malformed or missing). In this case, the arguments could be correct if the entity with the given ID already existed. The fact that the system happens to always assign random IDs is irrelevant.
from cross-media-measurement.
Related Issues (20)
- CorrectnessTest fails on GitHub Actions HOT 7
- Reach value is not multiple of the reciprocal of `vidSamplingRate`
- Linter caching causes build cache to be evicted HOT 1
- The certificate which we used while creating an eventGroup is not showing the same in listEventGroups results. HOT 2
- Frequency Histogram report results return more results than expected HOT 4
- Handle non-scalar operative fields in EventFilterValidator
- Reporting server does not validate EDP public key signature before encrypting RequisitionSpec
- Postgres tests are flaky HOT 1
- Correctness test broken by Spanner Emulator 1.5.0
- Kingdom should not return `UNKNOWN` error code for request with wrong api key
- Kingdom internal server eventually deadlines on every RPC, runs out of memory HOT 7
- Error when calling CMMS public API using Duchy credentials HOT 3
- Duchies can enter a state where they add an unbounded number of log entries HOT 2
- Single-EDP R/F Measurements can result in invalid Duchy computation states
- Stop requiring AKID for self-signed CA certificates
- SIGBUS from JRE when building //src/main/kotlin/org/wfanet/measurement/kingdom/deploy/tools:CreateResource HOT 4
- tech-debt : Replace service account authentication with workload identity. HOT 2
- Update Duchy ComputationsService deleteComputation method to throw NOT_FOUND when ID does not exit
- BatchGetEventGroupMetadataDescriptors fails with UNKNOWN when parent ID is wildcard
- Kingdom deployment guide missing duchy_id_config.textproto in secret HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cross-media-measurement.