wooorm / bcp-47 Goto Github PK

This package does not treat the tag en-a-bbb-a-ccc as invalid even though the singleton subtag a appears twice.

According to the BCP 47 specifications: Each singleton subtag MUST appear at most one time in each tag (other than as a private use subtag). That is, singleton subtags MUST NOT be repeated. For example, the tag "en-a-bbb-a-ccc" is invalid because the subtag 'a' appears twice. Note that the tag "en-a-bbb-x-a-ccc" is valid because the second appearance of the singleton 'a' is in a private use sequence.

Is this an issue that needs to be fixed?

I don't know if this is in the scope of this project, but when I got here I expected to get the actual name of the language of a parsed language tag. I realize this library currently just implements the specification itself and doesn't keep a list of all subtags, but maybe we can change that? Sure, the subtag registry is huge but also the only resource to get the actual language names and scopes from. I think with some tricks we can compress that list, especially regarding the redundant and grandfathered entries. Also, not all entries are languages, but just regions or scripts, since this is a list of all possible subtags. Some metadata:

• 48149 lines
• 711 KB
• 9122 entries
• 8178 entries with Type: language
• a lot of entries have multiple Description values, it seems like just caring about the first one of each entry is enough
• Some values are irrelevant here and can be omitted
• converted to json it's "only" 655 KB big

Here is a short gist from me which converts the registry to a json that could be readable by this library:
https://gist.github.com/nnmrts/7f06da21729a7d495cdee147271847b5

Is there any interest in a PR to include TypeScript definitions in this project? If so, I'd be glad to make a PR for them.

Probably not scope of your package but I am longing for a function to return me a BCP 47 language tag based by a top level domain (TLD).

Have initially reported the need in petert82/country-query#3 but since it seems inactive, and yours comes - after some research - the most close, I wonder why not ask you about that?

Using the package as: const schema = parse('x-whatevertag', {warning: true}), results in error:

     if (options.warning) options.warning(reason, code, offset)
                                 ^
TypeError: options.warning is not a function
     at fail (file:///C:/Users/.../node_modules/bcp-47/lib/parse.js:288:34)
     at parse (file:///C:/Users/.../node_modules/bcp-47/lib/parse.js:258:18)
    at file:///C:/Users/.../src/test.js:3:16```

In these referenced line, the import doesn't include the .json extension, which is creating problems for Webpack. Could this be fixed? I've already tested that just adding the extension fixes the problem. If a PR is welcome, I'd be glad to make it.