witnet / aragon-govern-discord-integration Goto Github PK

Document how to create DAOs using the aragon-govern project.

EDIT: they recently changed buidler for hardhat 😅

This happened when trying to setup the bot on a new server.

I get an exception and the process dies.

Is this a subgraph misconfiguration or something?

Received setup request for Discord guild 492453503390842880 trying to integrate with DAO named "GIORGI-DAO31"
/data/source/packages/bot/dist/services/subgraph/index.js:29
            throw new errors_1.ErrorUnexpectedResult(errorMessage);
                  ^

ErrorUnexpectedResult: Unexpected result when queryin DAO by name GIORGI-DAO31.
    at SubgraphClient.fetchResult (/data/source/packages/bot/dist/services/subgraph/index.js:29:19)
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
    at async SubgraphClient.queryDaoByName (/data/source/packages/bot/dist/services/subgraph/index.js:38:24)
    at async MessageHandler.setup (/data/source/packages/bot/dist/services/messageHandler.js:281:21)

Test all the possible flows of the integration.

Some ideas:

• Start all integration components and double-check documentation
• Setup DAO
• Make proposals
• Vote proposals
• Schedule and execute actions automatically

How to reproduce the problem:

!proposal 2021/04/28 10:60:00 "lorem ipsum" to:0x199eA5114D1612e40E3457Eaf9DF2779340EAD12 value:0.1

And the bot replies with:

New proposal "lorem
The request for creating the proposal "lorem has been received. A positive result will schedule the action, thus eventually sending 0.1 ETH to the address 0x199eA5114D1612e40E3457Eaf9DF2779340EAD12. React to this proposal to vote!

The same happens if double quotes are not used.

At the moment, the proposal accepts wrong formats as:

This issues is time boxed for a maximum of 1 day!

The idea is to avoid relying on an external subgraph server by deploying our own by using the package govern-subgraph in the aragon-govern repository.

After a demo of the full flow we have gather the following feedback:

• Show additional message after run the !setup command mentioning all the members with the role previously specified and explainning how to create a proposal.
• Show the full amount to send instead of round it

Last touches for the Aragon<>Witnet Bot:

• Insert transaction link to Witnet explorer (when positive and when it fails)
• The disputed proposal has not a majority of positive votes -> The disputed proposal did not receive a majority of positive votes
• Add gasPrice in web3 calls
  • Call API to estimate gas price (e.g. etherscan, eth gas station)
  • Add calculated gasPrice to web3 call (in web3Client) as .send({ from: GETH_ADDRESS, gas: GAS_LIMIT, gasPrice })

Set the minimum proposal duration to 4 hours

In some cases, transactions were reverted because some parameter was not properly configured or even the network congestion affected to some gas limits. This is a problem in case of a finished proposal in which the schedule or execute transaction fails. Currently, this situation cannot be fixed and the proposal needs to be re-launched.

For this reason, it would be desirable to have a way of resending schedule and execute transactions in case they fail. Additionally, only admin users should be able to perform this action. Optionally, they should include parameters such as the gas (gas limit) or gasPrice.

Create a method that receives identifier for a voting, and uses Discord API to retrieve positive and negative reactions (e.g. returns the result as an Array of integers)

Currently, participants can remove their reactions. We should avoid this behavior when the deadline is reached.

Things to add:

• React differently regarding the voting result
  • Decode tally result, and only call schedule and execute if OK and positive
  • Send message to discord of negative result
• Consider executionDelay for the timeout value for calling execute (add a small delay for guaranteeing that execute is called after schedule)
• Change the to unit in !proposal message (e.g. use eth insted of wei)

Things to discuss:

• Send a "reaction" message for each vote may be too verbose?

https://discord.com/developers/docs/interactions/slash-commands

I think this was implemented, but today we tried to setup a DAO that was mispelled and the bot did not complain. :)

Improve the existing documentation with additional information that may be required.

Some examples:

• environment variables
• execution (e.g. using Docker)

• Add action to !proposal message
• Add action argument to web3 client
• Check that GovernQueue is executing an action

Discuss how to proceed with the integration in terms of:

• Showcase with funds
• Communication strategy (e.g. medium posts)

Find out why the call of execute in the GovernQueue contract is failing because of an out of gas problem.
The failed transaction in Rinkeby.

It looks like that the passed argument for setting the gas in web3 is ignored: .send({ from: GETH_ADDRESS, gas: GAS_LIMIT }).

Update the aragon bot in order to work with the new changes in the aragon govern contracts which led to other changes in the subgraph schema.

3 monitors in portainer, make sure invite links do work, test on witnet mainnet but ethereum testnet