withtally / dao.new Goto Github PK

Hi Guys,

Also getting a VS Code linting error from every file that uses @create-nft-dao/shared:

Cannot find module '@create-nft-dao/shared' or its corresponding type declaration

Most likely this is related with the prebuild error we noted in issue 24. Yes?

Going down the rabbit hole, here are some questions and findings:

1. Looking at your package.json file it appears that ts-node is a dependency. Although a very bad practice, do you recommend we install it globally?

2. Here are excerpts of package.json after completing step 4

  "scripts": {
    "wizard": "yarn workspace @create-nft-dao/wizard dev -p 3000",
    "wizard:build": "yarn workspace @create-nft-dao/wizard build",
    "wizard:start": "yarn workspace @create-nft-dao/wizard start",
...
  "devDependencies": {
    "prettier": "^2.4.1",
    "prettier-plugin-solidity": "^1.0.0-beta.18",
    "//": "added ts-node here to overcome the bug with HH and yarn where hardhat throws HH13 when ts-node is only installed in the hardhat package.",
    "ts-node": "^10.4.0"
  },

3. yarn add ts-node typescript gives this warning:

 $ 
yarn add v1.22.17
error Running this command will add the dependency to the workspace root rather than the workspace itself, which might not be what you want - if you really meant it, make it explicit by running this command again with the -W flag (or --ignore-workspace-root-check).
info Visit https://yarnpkg.com/en/docs/cli/add for documentation about this command.

For solos composer, we'd love to integrate more closely with dao.new, and I think allowing the form to be filled by query params would be an easy way to do this.

We generate all the IPFS links as well as store wallet addresses, resell % etc in our app, so if we could link into dao.new with simple query params it would make integration super easy and less error-prone.

You guys did an incredible job with this! It's a much needed tool!

The below are more of feature requests than issues.

I do realize that the contracts are available on etherscan, etc. But might want to offer the option to download the contracts as a zip file in addition to full deployment.

The download option would be great for devs wanting to incorporate and test within their own setups and workflows or for custom, cross-chain deployments

Also, in order to mint. Looks like the end-user needs to get the front-end to work within their workflow. Perhaps you can host the admin and mint pages for ease-of-use. Then again, most likely it's already hosted, and I just missed it on your website.

This might not be on the horizon, but it would be great to offer a version of this project without the dependency on Chakra for the UI. Making this less opinionated would make it an easier choice for lots of folks.

Just an idea :)

I'll be making my own fork to do this for upcoming projects as I really dislike UI frameworks like Chakra ha.

I've deployed with this twice already, but it looks like a fresh fork is failing to build with a TS error.

Any idea about how to fix?

1:38:38 PM: [!] (plugin rpt2) Error: /opt/build/repo/packages/shared-frontend/src/lib/connectors.ts(13,3): semantic error TS2345: Argument of type '{ rpc: { [chainId: number]: string; }; qrcode: true; pollingInterval: number; }' is not assignable to parameter of type 'WalletConnectConnectorArguments'.
1:38:38 PM:   Object literal may only specify known properties, and 'pollingInterval' does not exist in type 'WalletConnectConnectorArguments'.
1:38:38 PM: src/lib/connectors.ts
1:38:38 PM: Error: /opt/build/repo/packages/shared-frontend/src/lib/connectors.ts(13,3): semantic error TS2345: Argument of type '{ rpc: { [chainId: number]: string; }; qrcode: true; pollingInterval: number; }' is not assignable to parameter of type 'WalletConnectConnectorArguments'.
1:38:38 PM:   Object literal may only specify known properties, and 'pollingInterval' does not exist in type 'WalletConnectConnectorArguments'.

@davidbrai @eladmallel @crazyrabbitLTC ?

Questions

Any advice on how we can fix this?

Or any advice on how we directly (and easily) access the contract endpoints/functions by building our own custom and bespoke React App as a front end?

Here's an idea! Perhaps if we were to add the auto-generated NFT (Token), Minter, Governor, Timelock contracts to Remix we could easily identify which contract functions we need to target using a custom, bespoke React front end?

But it would be easier if you can advise (or expose in the docs) which contract functions we need to target to create the functionality of your frontends for minting, admin, etc.

Summary

Operating System: Windows 10

Terminal: git bash for Windows (MINGW64)

Error Occurs At: step 5: From the repo root folder run: yarn prebuild

Partial Error Output:

$ yarn prebuild
yarn run v1.22.17
$ yarn shared:build && yarn hardhat:build
$ yarn workspace @create-nft-dao/shared build
$ rollup -c

src/index.tsx → dist/index.js...
created dist/index.js in 54.2s
$ yarn workspace @create-nft-dao/hardhat build
$ yarn typechain && yarn build:ts
$ TS_NODE_TRANSPILE_ONLY=true yarn hardhat --config ./hardhat.base.config.ts typechain
'TS_NODE_TRANSPILE_ONLY' is not recognized as an internal or external command,
operable program or batch file.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.

Show ens name and avatar if the user owns it already.