wisvch / feedback Goto Github PK

The package "com.ch" implies we own the domain "ch.com", which is clearly not the case. We should be using "ch.wisv" instead.

Image ghcr.io/wisvch/feedback:20230312-61318c7 is broken on the onprem k8s cluster:

2023-03-12 15:11:38.609 ERROR 1 --- [           main] o.s.b.c.p.m.PropertiesMigrationListener  : 
The use of configuration keys that are no longer supported was found in the environment:

Property source 'systemEnvironment':
        Key: server.use-forward-headers
                Reason: Replaced to support additional strategies.


Please refer to the release notes or reference guide for potential alternatives.

2023-03-12 15:11:38.621  INFO 1 --- [           main] ConditionEvaluationReportLoggingListener : 

Error starting ApplicationContext. To display the conditions report re-run your application with 'debug' enabled.
2023-03-12 15:11:38.644 ERROR 1 --- [           main] o.s.b.d.LoggingFailureAnalysisReporter   : 

***************************
APPLICATION FAILED TO START
***************************

Description:

Parameter 0 of constructor in ch.wisv.service.NotificationService required a bean of type 'org.springframework.mail.javamail.JavaMailSender' that could not be found.


Action:

Consider defining a bean of type 'org.springframework.mail.javamail.JavaMailSender' in your configuration.

I got a complaint from someone who (said that he) divided his feedback in paragraphs, but this division got lost in the email and in the inbox.

The previous course codes (TI****) need to be replaced with the new codes (CSE****) in the API parser.

The TU Delft API is deprecated and should be decoupled from this project.

Now, it's unclear whether or not your name is submitted with your feedback while logged in. The name and e-mail fields (labelled 'optional') are empty, but I assume your name gets logged anyway.

So I'd like to propose to use the CH Connect claim to autofill the name and e-mail fields.

1. Handy
2. Gives you the option to not send your name with your feedback while logged in.

I often find myself asking if I can forward the complaint (rephrased, or entirely) to the involved teacher, or director of studies. It would be nice to cut-out this exchange, or, in case it's anonymous to know that it can still be forwarded.

Spring Boot 1.x will be EOL 1 Aug 2019.

I notice that I always read feedback in my inbox, and not in the feedback tool itself. It would be very helpful if I could reply to (ask for clarification etc.) an email by clicking on reply from my inbox.

Unfortunately, people found out how to spam the feedback tool.

Proposed solution:

• Adding a simple reCAPTCHA will do the trick.
• Adding a cooldown per user based on IP might do the trick

The offline_access scope creates refresh tokens which this application does not need, so it should be removed.
https://github.com/WISVCH/feedback-tool/blob/87c59f107e8ed1b60694e0541dc4f50e164a91ae/src/main/java/com/ch/config/CHConnectConfiguration.java#L51

See WISVCH/connect#24

I've noticed that many students submit feedback without leaving their email address. At the moment it's not clearly stated that we cannot reply if there's no email address. It just says 'Fill in your email if you want to receive a copy of your feedback.' This should be changed to also include that not filling in your name/email makes the feedback anonymous and you will not receive a reply.

When viewing the feedback tool on small screens, the sidebar dissappears, but no alternative navigation is offered.