wisvch / choice Goto Github PK

View Code? Open in Web Editor NEW

1.0 1.0 3.0 830 KB

CH exam archive

License: GNU General Public License v3.0

Kotlin 57.34% CSS 3.03% HTML 27.85% JavaScript 11.62% Dockerfile 0.16%

kotlin spring-boot

choice's People

Contributors

Stargazers

Watchers

Forkers

tim-w praseodym fastjur

choice's Issues

Upgrade to Spring Boot 2.x

Spring Boot 1.x will be EOL 1 Aug 2019.

Put files on the filesystem instead of in the database

Currently CHoice saves the exams in its PostgreSQL database. That database is currently ~700MB in size, which causes a lot of churn backups because files cannot be effectively deduplicated. It also just isn't a great idea to store large files in a database anyway.

I'd suggest the exams be moved to the filesystem (a Kubernetes persistent volume) or e.g. a Google Cloud Storage bucket whenever we're migrated into the cloud.

Sort exams response on course code and date

Searching for an exam is pretty hard when the date and course are not sorted.

API serves files without extension

Currently, the API serves PDF exams at endpoints like /api/v1/document/exam/9. Some browsers (e.g. Firefox Developer Edition) do not append an extension to the filename, so you end up with a file called 9 instead of 9.pdf.

It would be even better to change the name of the downloaded file to [filename].pdf instead of [id](.pdf).

Fix not being able to add new exams

The TU Delft API is deprecated and should be decoupled from this project.

Disallow creating course with invalid predecessor.

Multiple course predecessors

For example: Calculus has two predecessors, Analyse 1 & 2.

Date field on 'add exam' doesn't accept browser date-picker formats

Temporary fix would be to make this a normal text field

Upgrade to Spring Boot 3

https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.0-Migration-Guide

Fix overflow in page overflow dashboard home page

Fix Dropdown Menus

When you select a study or study program in the dropdown menu, it doesn't change anything in the list of exams. Also, after that the search bar doesn't work anymore either. The console shows "Failed to load resource: the server responded with a status of 500 ()"

Also, the titles "study" and "study program" don't really make sense, I think they should be "study program" and "study year".

Create file uploading and integration with path.

Dashboard does not work, results in 404 error

Steps to reproduce:

Navigate to https://ch.tudelft.nl/choice2/dashboard
Log in

Expected behaviour

See the dashboard and be able to upload exams

Actual behaviour

The following error page is displayed:

There are no console messages. Also, very occasionally the page loads. But after a refresh the same error message is displayed.

System information

MacBook Pro (13-inch, 2017, Two Thunderbolt 3 ports)
Processor 2,5 GHz Intel Core i7
Memory 16 GB 2133 MHz LPDDR3
Graphics Intel Iris Plus Graphics 640 1536 MB
OS: macOS High Sierre Version 10.13.5

Browsers tested

Safari Version 11.1.1 (13605.2.8)
Google Chrome Version 69.0.3497.100 (Official Build) (64-bit)

Add health check endpoint

Add health check endpoint and configure it in Kubernetes

Add study program minor

Improve performance

The avarage GET /api/v1/course/active takes 450ms (p90) and does 1046(!) SQL queries. This one comes up a lot:

select exam0_.id, exam0_.course, exam0_.date, exam0_.including_answers, exam0_.name from exam exam0_ left outer join course course1_ on exam0_.course = course1_.code where course1_.code = ?

I think simple some optimisations (eager fetching) should take care of this and improve performance.

Add flatpickr for timestamps etc.

Cannot load documents

org.postgresql.util.PSQLException: Large Objects may not be used in auto-commit mode.
	at org.postgresql.largeobject.LargeObjectManager.open(LargeObjectManager.java:262) ~[postgresql-9.4.1212.jre7.jar!/:9.4.1212.jre7]
	at org.postgresql.largeobject.LargeObjectManager.open(LargeObjectManager.java:248) ~[postgresql-9.4.1212.jre7.jar!/:9.4.1212.jre7]
	at org.postgresql.jdbc.AbstractBlobClob.getLo(AbstractBlobClob.java:272) ~[postgresql-9.4.1212.jre7.jar!/:9.4.1212.jre7]
	at org.postgresql.jdbc.AbstractBlobClob.getBinaryStream(AbstractBlobClob.java:116) ~[postgresql-9.4.1212.jre7.jar!/:9.4.1212.jre7]

Sort Exams by Year

Currently, the exams seem to be displayed unsorted on the user-end. I think it would be more user-friendly to sort them by year.